[buddypress-trac] [BuddyPress Trac] #7734: BP-Nouveau Group Creation Previous-Next navigation: Links vs Buttons

buddypress-trac noreply at wordpress.org
Fri Jun 29 10:04:43 UTC 2018

#7734: BP-Nouveau Group Creation Previous-Next navigation: Links vs Buttons
 Reporter:  mercime                    |       Owner:  (none)
     Type:  defect (bug)               |      Status:  new
 Priority:  normal                     |   Milestone:  4.0
Component:  Templates                  |     Version:
 Severity:  normal                     |  Resolution:
 Keywords:  has-screenshots has-patch  |
Changes (by DJPaul):

 * milestone:  Under Consideration => 4.0


 Sorry no-one gave you feedback on this sooner, @mercime.

 Both variants of the patch have translation problems. e.g. `esc_html__`
 instead of `esc_html`, and the patch with the arrow, that arrow needs to
 be included in the translated string for RTL languages. I am also wary of
 styling links to look like buttons because that's hard to do reliably
 cross-browser. It seems that the button element is not appropriate here,
 either, which is annoying, as that would have solved the visual

 For the arrow patch, I think it just looks bad to have two different types
 of navigation style next to each other like that.
 I think if we can change the layout of these navigation buttons, then
 perhaps the arrow patch will be better. I don't have any time to play
 around with better button placement, but I would revisit the never-
 questioned-decision about whether the previous/next wizard buttons need to
 be next to each other.

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7734#comment:8>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac

More information about the buddypress-trac mailing list