[buddypress-trac] [BuddyPress Trac] #7866: Privacy: Privacy policy integration into registration process

[buddypress-trac]

#7866: Privacy: Privacy policy integration into registration process
--------------------------+---------------------
 Reporter:  boonebgorges  |       Owner:  (none)
     Type:  enhancement   |      Status:  new
 Priority:  normal        |   Milestone:  4.0
Component:  Core          |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  2nd-opinion   |
--------------------------+---------------------

Comment (by imath):

 @boonebgorges  i’m wondering If there’s a reason not to use the
 {{{bp_nouveau_get_signup_fields()}}} BP Nouveau is using to create markup
 for the other signup fields, because we could add around this line
 https://buddypress.trac.wordpress.org/browser/trunk/src/bp-templates/bp-
 nouveau/includes/functions.php#L1220 something like this :

 {{{
 if ( bp_signup_requires_privacy_policy_acceptance() ) {
   $fields[‘account_details’][‘signup-privacy-policy-accept‘] = array(
    // field args
 );
 }
 }}}

 This would save a template edit in nouveau.

 Then if I understand right, the problem is for template pack != ´nouveau’
 so instead of adding an hidden field to see if the check needs to be done
 i’d probably create a filterable function that checks {{{'nouveau' ===
 bp_get_theme_package_id()}}} to do the policy acceptance require check in
 {{{bp_core_screen_signup()}}}.

 Finally, I would advise to provide some « easy to put in place » for a
 site administrator back compat for legacy and default like an
 {{{
 add_action( ‘bp_account_details_fields’, function() {
  // if not BP Nouveau and site admin want privacy policy output some
 markup
 } );
 }}}

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7866#comment:7>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac