[buddypress-trac] [BuddyPress Trac] #7903: Nouveau - Don't use AJAX to refresh directories when filtered by type

buddypress-trac noreply at wordpress.org
Thu Jun 14 08:48:16 UTC 2018


#7903: Nouveau - Don't use AJAX to refresh directories when filtered by type
--------------------------+---------------------
 Reporter:  r-a-y         |       Owner:  (none)
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  3.2.0
Component:  Templates     |     Version:  3.0.0
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+---------------------

Comment (by imath):

 Hi @r-a-y

 Thanks for pinging me about it. 7903.01.patch is fine, I've tested it and
 it works as expected. So you can use it, no problem.

 But as a few lines above in {{{buddypress-nouveau.js}}}, there's already a
 {{{'no-ajax'}}} available class to escape from AJAX, I would recommend to
 use it. I think it will make more sense for developers to understand why
 the page is reloaded in this case.

 Moreover, I doubt the body class checks would work for Groups type, as so
 far this {{{'type'}}} class is only added when a **member** type is set.

 That's why I think 7903.02.patch:
 - would make more sense for the {{{'no-ajax'}}} thing,
 - would take the group type in account
 - could possibly take in account more components ''having a directory''
 types (eg: blogs)

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7903#comment:2>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list