[buddypress-trac] [BuddyPress Trac] #7931: Possible regression in bp_core_new_subnav_item()

buddypress-trac noreply at wordpress.org
Wed Jul 18 07:30:33 UTC 2018


#7931: Possible regression in bp_core_new_subnav_item()
--------------------------+---------------------
 Reporter:  dontdream     |       Owner:  (none)
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  3.2.0
Component:  Navigation    |     Version:  3.0.0
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+---------------------
Changes (by r-a-y):

 * keywords:  2nd-opinion => has-patch
 * milestone:  Awaiting Review => 3.2.0


Comment:

 Actually, you are right, @dontdream !

 Instead of returning if no parent nav is found, we can check if there is a
 parent nav, if so, we can use `reset()`.

 I tested the example code in #7659 and your test example and both test
 cases work.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7931#comment:2>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list