[buddypress-trac] [BuddyPress Trac] #7905: Upload photos broken in older bp-default themes

[buddypress-trac]

#7905: Upload photos broken in older bp-default themes
--------------------------+---------------------
 Reporter:  r-a-y         |       Owner:  (none)
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  3.2.0
Component:  Core          |     Version:  3.0.0
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+---------------------

Comment (by r-a-y):

 Thanks for your comments, imath.

 > I think I’d add the _attachments templates to BP Default if it’s
 possible.

 Are you recommending that we copy over bp-legacy's `_attachments` folder
 to `bp-default`?  If so, this wouldn't address themes that copied older,
 bp-default templates into their theme's directory.

 > It’s making me feel weird to create a dependency we risk to forget
 later, unless BP Legacy is eternal! In this case we should probably go
 with your patch.

 Yeah, I understand your apprehension, but in the admin area, we continue
 to have a dependency on bp-legacy ever since the Backbone upload
 functionality was introduced:
 https://buddypress.trac.wordpress.org/browser/tags/3.1.0/src/bp-core/bp-
 core-attachments.php?marks=981#L968

 Also check out #7672 for more about bp-legacy potentially being the
 fallback template pack, particularly:
 https://buddypress.trac.wordpress.org/ticket/7672#comment:11

 I think my patch is the easiest approach to address this problem, but we
 should definitely not forget about your comments, imath.

 Let me know what you think.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7905#comment:2>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac