[buddypress-trac] [BuddyPress Trac] #7732: BP-Nouveau: Group Creation Menu issues

buddypress-trac noreply at wordpress.org
Sat Apr 14 08:41:07 UTC 2018

#7732: BP-Nouveau: Group Creation Menu issues
 Reporter:  mercime       |       Owner:  dcavins
     Type:  defect (bug)  |      Status:  accepted
 Priority:  normal        |   Milestone:  3.0
Component:  Templates     |     Version:
 Severity:  blocker       |  Resolution:
 Keywords:                |

Comment (by hnla):

 Why are we removing Nouveau functions :( Folks half the point in many of
 Nouveaus approaches to things like core functions was to explicitly
 attempt to pull the more front end rendering functions out of core and to
 a position where they could be easily manipulated, so on face value it may
 seem that we are just duplicating code but there was a reason ( albeit
 possibly not in this case but I would need to review as it's been a while
 since I last dealt with this steps aspect)

 Can we please be careful not to rush to undo the work imath and I did for
 Nouveau unless there a definite issue identified.

 @mercime While the UL is not an unsemantic in itself I agree moving to an
 OL might be better for 'steps', think we can do that, had a quick check
 and we do have to update rules for tabbed links as a comp as they're based
 on 'UL' so would need to double up or probably better remove UL selector
 and ensure only class manages the tabs effect. I can look at that when the
 rest of this ticket is dealt with.

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7732#comment:14>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac

More information about the buddypress-trac mailing list