[buddypress-trac] [BuddyPress Trac] #7443: Hidden groups CSS specificity

[buddypress-trac]

#7443: Hidden groups CSS specificity
--------------------------+---------------------
 Reporter:  MikeGillihan  |       Owner:  r-a-y
     Type:  defect (bug)  |      Status:  closed
 Priority:  normal        |   Milestone:  2.9
Component:  Groups        |     Version:  1.7
 Severity:  minor         |  Resolution:  fixed
 Keywords:  has-patch     |
--------------------------+---------------------
Changes (by r-a-y):

 * owner:   => r-a-y
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"11613"]:
 {{{
 #!CommitTicketReference repository="" revision="11613"
 bp-legacy: Fix the display of hidden groups in group loops in some
 instances.

 Themes or plugins that use the `.hidden` CSS declaration to hide content
 can conflict with hidden groups in group loops.  Themes that utilize the
 Bootstrap framework are particularly prone to this problem.

 The issue is due to us using the group status as a CSS class and
 `'hidden'`
 is a valid BuddyPress group status option.

 To workaround this, we check the visibility of a hidden group in the group
 loop with JS.  If the group is hidden via CSS, we force the display of the
 group with the `!important` rule.

 In the future, we should probably deprecate the usage of the `hidden` CSS
 class in group loops for something else.

 Props r-a-y, MikeGillihan, hnla, henry.wright.

 Fixes #7443.
 }}}

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7443#comment:13>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac