[buddypress-trac] [BuddyPress Trac] #7548: bp_button_class needs to know what $container value is to set correct $parent_element

buddypress-trac noreply at wordpress.org
Fri Jun 23 13:37:34 UTC 2017

#7548: bp_button_class needs to know what $container value is to set correct
 Reporter:  hnla               |       Owner:
     Type:  enhancement        |      Status:  new
 Priority:  normal             |   Milestone:  3.0
Component:  Core               |     Version:
 Severity:  normal             |  Resolution:
 Keywords:  2nd-opinion early  |
Changes (by hnla):

 * keywords:  2nd-opinion => 2nd-opinion early
 * milestone:  2.9 => 3.0


 It's a core issue in that we re-factored core button class to accept
 changes to the element but while hardcoding a wrapper element, given
 Nouveau allows both to be modified we should provide a simple means to
 allow the button class to check what if any $container value set and
 switch elements, it seems to me to be something inconsequential for the
 class to maintain.

 However for this to work means I have to re-visit the Nouveau button args
 to pass $container into the arrays so BP button class has it available.
 For the moment I'm punting this to 3.0 I'll work up a patch then for it.

 >Can you create a Nouveau ticket and CC me on it?

 Think it was noted there but not sure a ticket on Nouveau makes huge
 sense, maybe though, if not existing I'll circle back around later.

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7548#comment:2>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac

More information about the buddypress-trac mailing list