[buddypress-trac] [BuddyPress Trac] #7395: embed_oembed_html not used on sitewide activity?

buddypress-trac noreply at wordpress.org
Fri Jun 23 05:21:09 UTC 2017

#7395: embed_oembed_html not used on sitewide activity?
 Reporter:  petervandoorn  |       Owner:
     Type:  defect (bug)   |      Status:  new
 Priority:  normal         |   Milestone:  2.9
Component:  Core           |     Version:  1.5
 Severity:  normal         |  Resolution:
 Keywords:                 |

Comment (by r-a-y):

 > @r-a-y How do you feel about calling this action in addition to ours? I
 ended up doing this for the email code with wp_mail, and I think it'd help
 more here, too.

 The problem is the `'embed_oembed_html'` filter doesn't quite have the
 same filter signature.  The `'embed_oembed_html'` filter has a fourth
 parameter used for the WP post ID, but we do not utilize the item ID in
 our `'bp_embed_oembed_html'` filter -- we use the raw shortcode attributes

 In `01.patch`, I've implemented the `'embed_oembed_html'` filter, but for
 the fourth parameter, I've just passed integer `0` in its place.

 I'll leave it up to you if we want to commit this or not as I don't really
 have any strong opinions about this ticket.

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7395#comment:6>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac

More information about the buddypress-trac mailing list