[buddypress-trac] [BuddyPress Trac] #5079: Modify hook for posting new activity comment

buddypress-trac noreply at wordpress.org
Sun Jun 4 01:38:12 UTC 2017


#5079: Modify hook for posting new activity comment
----------------------------------------------------+------------------
 Reporter:  digitalminion                           |       Owner:
     Type:  enhancement                             |      Status:  new
 Priority:  normal                                  |   Milestone:  2.9
Component:  Activity                                |     Version:
 Severity:  normal                                  |  Resolution:
 Keywords:  needs-patch good-first-bug 2nd-opinion  |
----------------------------------------------------+------------------
Changes (by tw2113):

 * keywords:  needs-patch good-first-bug => needs-patch good-first-bug 2nd-
     opinion
 * milestone:  Future Release => 2.9


Comment:

 I think instead of trying to create new filters that add overhead and
 spots of maintenance, as little as it may be, it'd be better to pass a 2nd
 parameter to both for context. I'm open to suggestions for wording, but
 perhaps for `bp_activity_new_comment` we pass in a 2nd parameter of "new"
 and for `bp_get_activity_comment_content` we pass in a 2nd parameter of
 "display".

 This will present a lot less headache, and would help developers
 conditionally modify the content.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5079#comment:3>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list