[buddypress-trac] [BuddyPress Trac] #7562: Activity's friends component filter fails since 4.8

buddypress-trac noreply at wordpress.org
Wed Jul 5 12:00:42 UTC 2017

#7562: Activity's friends component filter fails since 4.8
 Reporter:  imath         |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  2.8.3
Component:  Templates     |    Version:  2.8.0
 Severity:  normal        |   Keywords:  has-patch dev-feedback
 Hi everyone,

 I've just met `bp_activity_get_actions_for_context()`. This function was
 introduced in 4.8 and according to the inline comment targets to get a
 flat list of activity actions compatible with a given context.

 The problem of it happens when an action is a comma separated value like
 `'friendship_accepted,friendship_created'` (the value of the Activity
 friends component filter). In this case the action parameter of the query
 string is not build, and you get the entire activity stream instead of
 only the friends component activities. So it's a regression.

 I think we should simply handle comma separated values as filters more
 generally. We only use them for the friends component but it can make
 sense to create a new custom filter with more than one activity type.

 That's why i'm suggesting to edit the `bp-templates/bp-legacy/buddypress-
 functions.php` instead of the activity context function.

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7562>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac

More information about the buddypress-trac mailing list