From noreply at wordpress.org Mon Jul 3 06:47:21 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Mon, 03 Jul 2017 06:47:21 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7557: integrate BuddyPress
Activity Privacy plugin with BuddyPress
Message-ID: <045.155d9a00927f098a9bd737c6bae33399@wordpress.org>
#7557: integrate BuddyPress Activity Privacy plugin with BuddyPress
--------------------------+-----------------------------
Reporter: Mohammad Sy | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Core | Version:
Severity: normal | Keywords:
--------------------------+-----------------------------
Please integrate BuddyPress Activity Privacy plugin with BuddyPress.
this plugin is very important and should be present primarily in
BuddyPress, since I asked you for the same request and promised me well.
please add this plugin in version 2.9
Thank you
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Mon Jul 3 06:50:45 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Mon, 03 Jul 2017 06:50:45 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7557: integrate BuddyPress
Activity Privacy plugin with BuddyPress
In-Reply-To: <045.155d9a00927f098a9bd737c6bae33399@wordpress.org>
References: <045.155d9a00927f098a9bd737c6bae33399@wordpress.org>
Message-ID: <060.4ef7f6ac58bb9b8b411e686b7166d2e2@wordpress.org>
#7557: integrate BuddyPress Activity Privacy plugin with BuddyPress
-----------------------------+------------------
Reporter: Mohammad Sy | Owner:
Type: feature request | Status: new
Priority: normal | Milestone: 2.9
Component: Core | Version:
Severity: normal | Resolution:
Keywords: |
-----------------------------+------------------
Changes (by Mohammad Sy):
* type: defect (bug) => feature request
* milestone: Awaiting Review => 2.9
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Mon Jul 3 10:15:04 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Mon, 03 Jul 2017 10:15:04 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7557: integrate BuddyPress
Activity Privacy plugin with BuddyPress
In-Reply-To: <045.155d9a00927f098a9bd737c6bae33399@wordpress.org>
References: <045.155d9a00927f098a9bd737c6bae33399@wordpress.org>
Message-ID: <060.e8d154dad8f3dc1289cdf3c29e7bcc73@wordpress.org>
#7557: integrate BuddyPress Activity Privacy plugin with BuddyPress
-----------------------------+------------------------------
Reporter: Mohammad Sy | Owner:
Type: feature request | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Core | Version:
Severity: normal | Resolution:
Keywords: |
-----------------------------+------------------------------
Changes (by hnla):
* milestone: 2.9 => Awaiting Review
Comment:
2.9 is now in beta testing so I'm afraid new tickets can't be added.
Changing to 'Awaiting Review'.
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Mon Jul 3 12:26:51 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Mon, 03 Jul 2017 12:26:51 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7558: Add Pages Core like
Facebook Pages
Message-ID: <045.c67e548a3c98fe1f5ae325ebc7aaaf88@wordpress.org>
#7558: Add Pages Core like Facebook Pages
-----------------------------+-----------------------------
Reporter: Mohammad Sy | Owner:
Type: feature request | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Core | Version:
Severity: normal | Keywords:
-----------------------------+-----------------------------
Hello,
Please add Pages Core like Facebook Pages in next Version 3.0
Thank you :)
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Mon Jul 3 12:46:48 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Mon, 03 Jul 2017 12:46:48 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7559: Make @mention like
Facebook
Message-ID: <045.bda4271aba02018f0d62296a40e654d1@wordpress.org>
#7559: Make @mention like Facebook
-----------------------------+-----------------------------
Reporter: Mohammad Sy | Owner:
Type: feature request | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Settings | Version:
Severity: normal | Keywords:
-----------------------------+-----------------------------
Hello,
Please make @mention like Facebook, for example when posting @mention it
should appear without "@" and appear with an Nickname, not "nice_name" ,
like Facebook .
Thank you :)
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Mon Jul 3 13:29:18 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Mon, 03 Jul 2017 13:29:18 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7556: confirmation message
problem (on activity delete)
In-Reply-To: <042.eb04813e640f275c165f3a546ed407b9@wordpress.org>
References: <042.eb04813e640f275c165f3a546ed407b9@wordpress.org>
Message-ID: <057.34a6421c6f24bb3d40e0f1aa6aa08ac7@wordpress.org>
#7556: confirmation message problem (on activity delete)
--------------------------+------------------------------
Reporter: 7asobate | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting Review
Component: (not sure) | Version:
Severity: normal | Resolution:
Keywords: has-patch |
--------------------------+------------------------------
Changes (by yahil):
* keywords: => has-patch
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Tue Jul 4 09:35:48 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Tue, 04 Jul 2017 09:35:48 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7559: Make @mention like
Facebook
In-Reply-To: <045.bda4271aba02018f0d62296a40e654d1@wordpress.org>
References: <045.bda4271aba02018f0d62296a40e654d1@wordpress.org>
Message-ID: <060.4481beb02c27afe088e647587c739417@wordpress.org>
#7559: Make @mention like Facebook
-----------------------------+-----------------------------
Reporter: Mohammad Sy | Owner:
Type: feature request | Status: new
Priority: normal | Milestone: Future Release
Component: Settings | Version:
Severity: normal | Resolution:
Keywords: |
-----------------------------+-----------------------------
Changes (by DJPaul):
* milestone: Awaiting Review => Future Release
Comment:
We must have tickets for this but - for ease of technical implementation I
imagine the at-prefix is going to remain.
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Tue Jul 4 09:32:36 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Tue, 04 Jul 2017 09:32:36 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7558: Add Pages Core like
Facebook Pages
In-Reply-To: <045.c67e548a3c98fe1f5ae325ebc7aaaf88@wordpress.org>
References: <045.c67e548a3c98fe1f5ae325ebc7aaaf88@wordpress.org>
Message-ID: <060.2627e4110109a6014935a3c6dcdc0322@wordpress.org>
#7558: Add Pages Core like Facebook Pages
-----------------------------+----------------------
Reporter: Mohammad Sy | Owner:
Type: feature request | Status: closed
Priority: normal | Milestone:
Component: Core | Version:
Severity: normal | Resolution: invalid
Keywords: |
-----------------------------+----------------------
Changes (by DJPaul):
* status: new => closed
* resolution: => invalid
* milestone: Awaiting Review =>
Comment:
I don't think this is likely to be added to the project. We have lots of
improvements to do for existing features rather than just adding new ones.
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Tue Jul 4 09:53:36 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Tue, 04 Jul 2017 09:53:36 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7533: needs a filter on
group and activity list table sortable columns
In-Reply-To: <045.35b5a60a378c0ef5c17b71cbedfb709b@wordpress.org>
References: <045.35b5a60a378c0ef5c17b71cbedfb709b@wordpress.org>
Message-ID: <060.3881bb7a18d29ac351d19ae70ece887a@wordpress.org>
#7533: needs a filter on group and activity list table sortable columns
----------------------------+-----------------------------
Reporter: modemlooper | Owner:
Type: enhancement | Status: new
Priority: low | Milestone: Future Release
Component: Core | Version: 2.8.2
Severity: trivial | Resolution:
Keywords: good-first-bug |
----------------------------+-----------------------------
Changes (by DJPaul):
* keywords: => good-first-bug
* milestone: Awaiting Review => Future Release
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Tue Jul 4 09:52:02 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Tue, 04 Jul 2017 09:52:02 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7470: Codex Cleanup -
Function Examples
In-Reply-To: <049.53dcf18efce57d873abb5a45c8200c3e@wordpress.org>
References: <049.53dcf18efce57d873abb5a45c8200c3e@wordpress.org>
Message-ID: <064.ff728741169cc4728eec31caef4c6d23@wordpress.org>
#7470: Codex Cleanup - Function Examples
----------------------------------+-----------------------------
Reporter: garrett-eclipse | Owner:
Type: enhancement | Status: assigned
Priority: normal | Milestone: Future Release
Component: BuddyPress.org Sites | Version:
Severity: normal | Resolution:
Keywords: |
----------------------------------+-----------------------------
Changes (by DJPaul):
* owner: garrett-eclipse =>
* milestone: Awaiting Review => Future Release
Comment:
The function documentation is going to be automatically generated soon,
and probably live on a new site. So that should take care of this.
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Tue Jul 4 09:55:50 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Tue, 04 Jul 2017 09:55:50 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7541: Disabled
"select/deselect all components" checkbox on bp-components page
In-Reply-To: <050.777669e69b529a449c6e6f2a2a99df5e@wordpress.org>
References: <050.777669e69b529a449c6e6f2a2a99df5e@wordpress.org>
Message-ID: <065.2c2006787b0026f6460e9feb2be4aa54@wordpress.org>
#7541: Disabled "select/deselect all components" checkbox on bp-components page
------------------------------+-----------------------------
Reporter: pavlo.opanasenko | Owner: slaFFik
Type: enhancement | Status: new
Priority: low | Milestone: Future Release
Component: Administration | Version: 2.5.0
Severity: minor | Resolution:
Keywords: has-patch commit |
------------------------------+-----------------------------
Changes (by DJPaul):
* milestone: Awaiting Review => Future Release
Comment:
@slaFFik do you remember if this was ready to commit or did this still
have an edge case with something being preselected?
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Tue Jul 4 10:02:38 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Tue, 04 Jul 2017 10:02:38 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7337: PHP Fatal error:
Uncaught Error: Call to a member function get_do_autolink() on null
In-Reply-To: <041.ebfef37ff5e67865d896952a55c9ea01@wordpress.org>
References: <041.ebfef37ff5e67865d896952a55c9ea01@wordpress.org>
Message-ID: <056.862ed1ba760fe9533f6ff9df2fb0c58d@wordpress.org>
#7337: PHP Fatal error: Uncaught Error: Call to a member function
get_do_autolink() on null
-------------------------------------------------+-------------------------
Reporter: slaFFik | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting
Component: Extended Profile | Review
Severity: normal | Version:
Keywords: dev-feedback 2nd-opinion early | Resolution:
needs-patch |
-------------------------------------------------+-------------------------
Comment (by DJPaul):
Still unconvinced. Adapting a template loop function to be used outside
seems against the design intent of those functions.
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Tue Jul 4 10:05:13 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Tue, 04 Jul 2017 10:05:13 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7455: Js bug when first
second level reply is added
In-Reply-To: <043.fe0d31f1a7c076f7beb3a8e0e0df728b@wordpress.org>
References: <043.fe0d31f1a7c076f7beb3a8e0e0df728b@wordpress.org>
Message-ID: <058.d3476b0407651bf58de92a496b7e0da1@wordpress.org>
#7455: Js bug when first second level reply is added
-------------------------------+----------------------
Reporter: jlorenzon | Owner:
Type: defect (bug) | Status: closed
Priority: normal | Milestone:
Component: Activity | Version:
Severity: normal | Resolution: invalid
Keywords: reporter-feedback |
-------------------------------+----------------------
Changes (by DJPaul):
* status: new => closed
* resolution: => invalid
* milestone: Awaiting Review =>
Comment:
This is being reworked for our new template pack, Nouveau.
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Tue Jul 4 10:03:38 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Tue, 04 Jul 2017 10:03:38 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7433: XProfile: improve
group/field saving sanitization
In-Reply-To: <043.42b3add7b3dc948fa147b0fcf64b8577@wordpress.org>
References: <043.42b3add7b3dc948fa147b0fcf64b8577@wordpress.org>
Message-ID: <058.4681613776bdf5c814569c1097bd8a7e@wordpress.org>
#7433: XProfile: improve group/field saving sanitization
------------------------------+----------------------
Reporter: Offereins | Owner:
Type: defect (bug) | Status: closed
Priority: normal | Milestone:
Component: Extended Profile | Version:
Severity: normal | Resolution: invalid
Keywords: |
------------------------------+----------------------
Changes (by DJPaul):
* status: new => closed
* resolution: => invalid
* milestone: Awaiting Review =>
Comment:
No details provided in months, going to close this.
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Tue Jul 4 17:31:49 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Tue, 04 Jul 2017 17:31:49 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7541: Disabled
"select/deselect all components" checkbox on bp-components page
In-Reply-To: <050.777669e69b529a449c6e6f2a2a99df5e@wordpress.org>
References: <050.777669e69b529a449c6e6f2a2a99df5e@wordpress.org>
Message-ID: <065.7a1f295df8768a976463a0863f958937@wordpress.org>
#7541: Disabled "select/deselect all components" checkbox on bp-components page
------------------------------+-----------------------------
Reporter: pavlo.opanasenko | Owner: slaFFik
Type: enhancement | Status: new
Priority: low | Milestone: Future Release
Component: Administration | Version: 2.5.0
Severity: minor | Resolution:
Keywords: has-patch commit |
------------------------------+-----------------------------
Comment (by slaFFik):
@DJPaul
There are some edge cases that should be addressed. I will talk to
@pavlo.opanasenko to hunt them down.
But in general - can we hide checkboxes for components that can't be
deactivated?
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Wed Jul 5 08:51:11 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Wed, 05 Jul 2017 08:51:11 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7541: Disabled
"select/deselect all components" checkbox on bp-components page
In-Reply-To: <050.777669e69b529a449c6e6f2a2a99df5e@wordpress.org>
References: <050.777669e69b529a449c6e6f2a2a99df5e@wordpress.org>
Message-ID: <065.a6d4c296623ce3e6d698150dabc3b3aa@wordpress.org>
#7541: Disabled "select/deselect all components" checkbox on bp-components page
------------------------------+-----------------------------
Reporter: pavlo.opanasenko | Owner: slaFFik
Type: enhancement | Status: new
Priority: low | Milestone: Future Release
Component: Administration | Version: 2.5.0
Severity: minor | Resolution:
Keywords: has-patch commit |
------------------------------+-----------------------------
Comment (by DJPaul):
We trust you to make decisions. So, yes.
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Wed Jul 5 08:47:47 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Wed, 05 Jul 2017 08:47:47 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7560: make Activity Index
shows only the activities of...
Message-ID: <045.27257a17907118b1eaf3ebd05989c81d@wordpress.org>
#7560: make Activity Index shows only the activities of...
-----------------------------+-----------------------------
Reporter: Mohammad Sy | Owner:
Type: feature request | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Activity | Version:
Severity: normal | Keywords:
-----------------------------+-----------------------------
Hello,
please make Activity Index shows only the activities of "friends , groups,
and followers"
all activities should not appear this is very annoying, please apply in
the next version.
thanks
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Wed Jul 5 09:02:52 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Wed, 05 Jul 2017 09:02:52 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7561: merge BuddyPress Follow
with BuddyPress
Message-ID: <045.c2058068f0f2196194546fb114fd89f9@wordpress.org>
#7561: merge BuddyPress Follow with BuddyPress
-----------------------------+-----------------------------
Reporter: Mohammad Sy | Owner:
Type: feature request | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Core | Version:
Severity: normal | Keywords:
-----------------------------+-----------------------------
Hello,
Please merge BuddyPress Follow with BuddyPress Core
this extension is very important and must be inside BuddyPress, please
include it in the next version.
Thanks
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Wed Jul 5 09:11:13 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Wed, 05 Jul 2017 09:11:13 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7557: integrate BuddyPress
Activity Privacy plugin with BuddyPress
In-Reply-To: <045.155d9a00927f098a9bd737c6bae33399@wordpress.org>
References: <045.155d9a00927f098a9bd737c6bae33399@wordpress.org>
Message-ID: <060.c9e08866940a53ebe286527d7e2484bc@wordpress.org>
#7557: integrate BuddyPress Activity Privacy plugin with BuddyPress
-----------------------------+------------------------------
Reporter: Mohammad Sy | Owner:
Type: feature request | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Core | Version:
Severity: normal | Resolution:
Keywords: |
-----------------------------+------------------------------
Comment (by Mohammad Sy):
Replying to [comment:2 hnla]:
> 2.9 is now in beta testing so I'm afraid new tickets can't be added.
Changing to 'Awaiting Review'.
I have changed to Awaiting Review
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Wed Jul 5 10:39:35 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Wed, 05 Jul 2017 10:39:35 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7561: merge BuddyPress
Follow with BuddyPress
In-Reply-To: <045.c2058068f0f2196194546fb114fd89f9@wordpress.org>
References: <045.c2058068f0f2196194546fb114fd89f9@wordpress.org>
Message-ID: <060.771c29444620e21675dee43982e2904b@wordpress.org>
#7561: merge BuddyPress Follow with BuddyPress
-----------------------------+---------------------
Reporter: Mohammad Sy | Owner:
Type: feature request | Status: closed
Priority: normal | Milestone:
Component: Core | Version:
Severity: normal | Resolution:
Keywords: |
-----------------------------+---------------------
Changes (by espellcaste):
* status: new => closed
* milestone: Awaiting Review =>
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Wed Jul 5 11:56:50 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Wed, 05 Jul 2017 11:56:50 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7133: Merge BuddyPress
Followers into BuddyPress Core
In-Reply-To: <049.ce941b390769101795ceae104b558b6b@wordpress.org>
References: <049.ce941b390769101795ceae104b558b6b@wordpress.org>
Message-ID: <064.0c48263615867e48aadc6dcc1e2bb64b@wordpress.org>
#7133: Merge BuddyPress Followers into BuddyPress Core
-----------------------------+-----------------------------
Reporter: johnjamesjacoby | Owner:
Type: feature request | Status: new
Priority: normal | Milestone: Future Release
Component: Friends | Version:
Severity: normal | Resolution:
Keywords: dev-feedback |
-----------------------------+-----------------------------
Changes (by m_uysl):
* cc: m_uysl@? (added)
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Wed Jul 5 12:00:42 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Wed, 05 Jul 2017 12:00:42 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7562: Activity's friends
component filter fails since 4.8
Message-ID: <039.3446f90b1960bb398ba80bb481166156@wordpress.org>
#7562: Activity's friends component filter fails since 4.8
--------------------------+------------------------------------
Reporter: imath | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 2.8.3
Component: Templates | Version: 2.8.0
Severity: normal | Keywords: has-patch dev-feedback
--------------------------+------------------------------------
Hi everyone,
I've just met `bp_activity_get_actions_for_context()`. This function was
introduced in 4.8 and according to the inline comment targets to get a
flat list of activity actions compatible with a given context.
The problem of it happens when an action is a comma separated value like
`'friendship_accepted,friendship_created'` (the value of the Activity
friends component filter). In this case the action parameter of the query
string is not build, and you get the entire activity stream instead of
only the friends component activities. So it's a regression.
I think we should simply handle comma separated values as filters more
generally. We only use them for the friends component but it can make
sense to create a new custom filter with more than one activity type.
That's why i'm suggesting to edit the `bp-templates/bp-legacy/buddypress-
functions.php` instead of the activity context function.
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Wed Jul 5 19:14:09 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Wed, 05 Jul 2017 19:14:09 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7553: Xprofile field
default visibility not honored during POST processing of registration form
In-Reply-To: <043.853c47a372047b28db7dcc09f6861320@wordpress.org>
References: <043.853c47a372047b28db7dcc09f6861320@wordpress.org>
Message-ID: <058.773740f7741d4afb0716f3e1c1cf9dff@wordpress.org>
#7553: Xprofile field default visibility not honored during POST processing of
registration form
--------------------------+------------------
Reporter: uscore713 | Owner:
Type: defect (bug) | Status: new
Priority: high | Milestone: 2.9
Component: Registration | Version: 1.6
Severity: normal | Resolution:
Keywords: has-patch |
--------------------------+------------------
Changes (by r-a-y):
* keywords: has-patch needs-unit-tests => has-patch
Comment:
`02.patch` includes a unit test exhibiting the problem.
I think this is ready for commit.
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Wed Jul 5 19:28:54 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Wed, 05 Jul 2017 19:28:54 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7461: Allow BuddyPress to
fetch 'illegal_user_logins' from WordPress core hook
In-Reply-To: <045.924f1d8d7ad563661029d2227bc44f24@wordpress.org>
References: <045.924f1d8d7ad563661029d2227bc44f24@wordpress.org>
Message-ID: <060.77f0571308e8dc3675ba69d272f7e91a@wordpress.org>
#7461: Allow BuddyPress to fetch 'illegal_user_logins' from WordPress core hook
--------------------------+------------------
Reporter: espellcaste | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 3.0
Component: Core | Version:
Severity: normal | Resolution:
Keywords: |
--------------------------+------------------
Changes (by espellcaste):
* milestone: Awaiting Review => 3.0
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Wed Jul 5 19:36:15 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Wed, 05 Jul 2017 19:36:15 -0000
Subject: [buddypress-trac]
=?utf-8?q?=5BBuddyPress_Trac=5D_=237505=3A_Prob?=
=?utf-8?q?lems_with_special_characters_for_Member_Names_=28e=2Eg=2E_?=
=?utf-8?b?w6kgw6Agw6cgZXRjKQ==?=
In-Reply-To: <041.0eb994578ec39f05e37572ca3dfaf100@wordpress.org>
References: <041.0eb994578ec39f05e37572ca3dfaf100@wordpress.org>
Message-ID: <056.a38c5c541c50db105a80a208efa330f4@wordpress.org>
#7505: Problems with special characters for Member Names (e.g. ? ? ? etc)
---------------------------------------------+-----------------------------
Reporter: XrossGG | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting
Component: Core | Review
Severity: normal | Version: 2.8.2
Keywords: needs-testing reporter-feedback | Resolution:
---------------------------------------------+-----------------------------
Changes (by r-a-y):
* keywords: => needs-testing reporter-feedback
* priority: strategic => normal
* severity: critical => normal
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Wed Jul 5 19:34:48 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Wed, 05 Jul 2017 19:34:48 -0000
Subject: [buddypress-trac]
=?utf-8?q?=5BBuddyPress_Trac=5D_=237505=3A_Prob?=
=?utf-8?q?lems_with_special_characters_for_Member_Names_=28e=2Eg=2E_?=
=?utf-8?b?w6kgw6Agw6cgZXRjKQ==?=
In-Reply-To: <041.0eb994578ec39f05e37572ca3dfaf100@wordpress.org>
References: <041.0eb994578ec39f05e37572ca3dfaf100@wordpress.org>
Message-ID: <056.91393638c24267f33fa72252b24ff857@wordpress.org>
#7505: Problems with special characters for Member Names (e.g. ? ? ? etc)
--------------------------+------------------------------
Reporter: XrossGG | Owner:
Type: defect (bug) | Status: new
Priority: strategic | Milestone: Awaiting Review
Component: Core | Version: 2.8.2
Severity: critical | Resolution:
Keywords: |
--------------------------+------------------------------
Comment (by espellcaste):
I failed to replicate this problem. My community is in Brazilian
Portuguese and we have similar characters as you. But we don't have his
type of problem.
So I'm not so sure it is a BuddyPress issue. :/
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Wed Jul 5 19:43:26 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Wed, 05 Jul 2017 19:43:26 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7337: PHP Fatal error:
Uncaught Error: Call to a member function get_do_autolink() on null
In-Reply-To: <041.ebfef37ff5e67865d896952a55c9ea01@wordpress.org>
References: <041.ebfef37ff5e67865d896952a55c9ea01@wordpress.org>
Message-ID: <056.2a194b3317bac92e5e1a84236ffe5101@wordpress.org>
#7337: PHP Fatal error: Uncaught Error: Call to a member function
get_do_autolink() on null
-------------------------------------------------+-------------------------
Reporter: slaFFik | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting
Component: Extended Profile | Review
Severity: normal | Version:
Keywords: dev-feedback 2nd-opinion early | Resolution:
needs-patch |
-------------------------------------------------+-------------------------
Comment (by r-a-y):
I'm not convinced either, but do we want to safeguard the function from
being used outside the xprofile loop?
If so, the current patch or a variation of it could be done (like `empty(
$GLOBALS['field'] )`).
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Wed Jul 5 19:39:48 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Wed, 05 Jul 2017 19:39:48 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7549: Only load AJAX code
on AJAX requests
In-Reply-To: <039.ad12c2065d91cde68840e6b5eb1d0a4e@wordpress.org>
References: <039.ad12c2065d91cde68840e6b5eb1d0a4e@wordpress.org>
Message-ID: <054.1c92c1e8c0cea0dbddfffb911cbbce30@wordpress.org>
#7549: Only load AJAX code on AJAX requests
-------------------------+------------------
Reporter: r-a-y | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: 3.0
Component: Core | Version:
Severity: normal | Resolution:
Keywords: |
-------------------------+------------------
Changes (by espellcaste):
* cc: contato@? (added)
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Wed Jul 5 19:54:45 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Wed, 05 Jul 2017 19:54:45 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7563: Welcome Screen for BP
2.9.0
Message-ID: <041.eb12b99e3148f64a105dc5f1b4699949@wordpress.org>
#7563: Welcome Screen for BP 2.9.0
--------------------------+-----------------
Reporter: mercime | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 2.9
Component: Core | Version:
Severity: normal | Keywords:
--------------------------+-----------------
See https://buddypress.org/2017/06/buddypress-2-9-0-beta-2/
String freeze: July 12, 2017
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Wed Jul 5 20:37:08 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Wed, 05 Jul 2017 20:37:08 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7563: Welcome Screen for
BP 2.9.0
In-Reply-To: <041.eb12b99e3148f64a105dc5f1b4699949@wordpress.org>
References: <041.eb12b99e3148f64a105dc5f1b4699949@wordpress.org>
Message-ID: <056.0ad53d584ea8992f29641b18cabdc99f@wordpress.org>
#7563: Welcome Screen for BP 2.9.0
--------------------------+------------------
Reporter: mercime | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 2.9
Component: Core | Version:
Severity: normal | Resolution:
Keywords: |
--------------------------+------------------
Comment (by r-a-y):
Thanks for opening this ticket, mercime.
Headline feature should probably be the edit slug feature for Groups in
the WP admin dashboard (#6014).
Secondary highlights (pick some of these, but probably not all):
- a11y (#7348, #7421, #7546)
- Tooltips (#7188)
- Better support for private message thread links in emails (#7349)
- Better compatibility with WordPress themes powered by Bootstrap (Fixes
issues with content being hidden in the groups loop and activity
comments). (#7443, #7490, #7542)
- Better support for uploads (Fixes issues with uploading in iOS Safari
and uploading files with non-ASCII filenames) (#7416, #7484)
This is just a guideline. Feel free to make whatever changes, everyone!
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Thu Jul 6 18:44:44 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Thu, 06 Jul 2017 18:44:44 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7564: A forgotten %s in french
translation is making the Activity JavaScript to fail with favorites.
Message-ID: <039.c275d95edd0c4032eec3b0a5eef30e32@wordpress.org>
#7564: A forgotten %s in french translation is making the Activity JavaScript to
fail with favorites.
--------------------------+-------------------------------------
Reporter: imath | Owner: slaFFik
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting Review
Component: I18N | Version: 2.8.2
Severity: normal | Keywords: i18n-change 2nd-opinion
--------------------------+-------------------------------------
The favorites count on the activity directory tab is used to check if we
need to remove this nav in case the total favourites is 0.
As the current translation is missing the `%s` placeholder, the count is
not appearing and when you remove 2 favorites from there, it's removing
the tab although there are still favorites.
I've just suggested this fix on the Polyglots tool:
https://translate.wordpress.org/projects/wp-
plugins/buddypress/stable/fr/default?filters%5Bstatus%5D=either&filters%5Boriginal_id%5D=1383980&filters%5Btranslation_id%5D=50488227
But i think something should be done to avoid the translation to make a
feature fail.
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Fri Jul 7 00:43:30 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Fri, 07 Jul 2017 00:43:30 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7556: confirmation message
problem (on activity delete)
In-Reply-To: <042.eb04813e640f275c165f3a546ed407b9@wordpress.org>
References: <042.eb04813e640f275c165f3a546ed407b9@wordpress.org>
Message-ID: <057.d765746f09ee4dffed5c28e8e4c529c4@wordpress.org>
#7556: confirmation message problem (on activity delete)
--------------------------+------------------------------
Reporter: 7asobate | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting Review
Component: (not sure) | Version:
Severity: normal | Resolution:
Keywords: has-patch |
--------------------------+------------------------------
Comment (by 7asobate):
Does it normally take that long for a mod to reply?
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Fri Jul 7 08:16:20 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Fri, 07 Jul 2017 08:16:20 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7563: Welcome Screen for
BP 2.9.0
In-Reply-To: <041.eb12b99e3148f64a105dc5f1b4699949@wordpress.org>
References: <041.eb12b99e3148f64a105dc5f1b4699949@wordpress.org>
Message-ID: <056.c170917189ea8e2b1a4f62a56fc7a17e@wordpress.org>
#7563: Welcome Screen for BP 2.9.0
--------------------------+------------------
Reporter: mercime | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 2.9
Component: Core | Version:
Severity: normal | Resolution:
Keywords: |
--------------------------+------------------
Comment (by mercime):
Thanks for the guideline r-a-y :D Screenshots: 800px x 500px for featured
items.
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Fri Jul 7 18:05:46 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Fri, 07 Jul 2017 18:05:46 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7424: filter
get_avatar_url to parse URLs from BP avatars
In-Reply-To: <043.41c6f78af4d81fb32702afa1298d65c0@wordpress.org>
References: <043.41c6f78af4d81fb32702afa1298d65c0@wordpress.org>
Message-ID: <058.24bf9fcb6b203acdc9a58128e5d6114d@wordpress.org>
#7424: filter get_avatar_url to parse URLs from BP avatars
------------------------------+---------------------------
Reporter: elhardoum | Owner: boonebgorges
Type: defect (bug) | Status: reopened
Priority: normal | Milestone: 2.9
Component: Extended Profile | Version:
Severity: normal | Resolution:
Keywords: has-patch commit |
------------------------------+---------------------------
Changes (by lne1030):
* status: closed => reopened
* type: enhancement => defect (bug)
* resolution: fixed =>
Comment:
Function '''bp_core_get_avatar_data_url_filter''' in the patch return
'''null''' when the second param ''$id_or_email'' is an email address.
Here is the Code: [bp-core/bp-core-
avatars.php#L1378](https://buddypress.trac.wordpress.org/browser/trunk/src
/bp-core/bp-core-avatars.php#L1374)
Just add this code to line 1380 would fix this bug
{{{#!php
} elseif (is_string( $id_or_email )) {
$user = get_user_by( 'email', $id_or_email );
}}}
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Fri Jul 7 18:21:49 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Fri, 07 Jul 2017 18:21:49 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7424: filter
get_avatar_url to parse URLs from BP avatars
In-Reply-To: <043.41c6f78af4d81fb32702afa1298d65c0@wordpress.org>
References: <043.41c6f78af4d81fb32702afa1298d65c0@wordpress.org>
Message-ID: <058.b2f3a5aa34892a0c274a87de89e97dc3@wordpress.org>
#7424: filter get_avatar_url to parse URLs from BP avatars
------------------------------+---------------------------
Reporter: elhardoum | Owner: boonebgorges
Type: defect (bug) | Status: reopened
Priority: normal | Milestone: 2.9
Component: Extended Profile | Version:
Severity: normal | Resolution:
Keywords: has-patch commit |
------------------------------+---------------------------
Comment (by r-a-y):
In [changeset:"11627"]:
{{{
#!CommitTicketReference repository="" revision="11627"
Avatars: Add missing email condition in
bp_core_get_avatar_data_url_filter()
Props lne1030.
See #7424.
}}}
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From buddypress-trac at lists.automattic.com Fri Jul 7 18:21:49 2017
From: buddypress-trac at lists.automattic.com (buddypress-trac at lists.automattic.com)
Date: Fri, 7 Jul 2017 18:21:49 +0000 (UTC)
Subject: [buddypress-trac] [BuddyPress][11627]
trunk/src/bp-core/bp-core-avatars.php: Avatars: Add missing email condition
in bp_core_get_avatar_data_url_filter()
Message-ID: <20170707182149.264C31080399@svn1.lax.wordpress.org>
An HTML attachment was scrubbed...
URL:
From noreply at wordpress.org Fri Jul 7 18:25:30 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Fri, 07 Jul 2017 18:25:30 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7424: filter
get_avatar_url to parse URLs from BP avatars
In-Reply-To: <043.41c6f78af4d81fb32702afa1298d65c0@wordpress.org>
References: <043.41c6f78af4d81fb32702afa1298d65c0@wordpress.org>
Message-ID: <058.59c375ef71c8d1345c54fb368271e84b@wordpress.org>
#7424: filter get_avatar_url to parse URLs from BP avatars
------------------------------+---------------------------
Reporter: elhardoum | Owner: boonebgorges
Type: defect (bug) | Status: reopened
Priority: normal | Milestone: 2.9
Component: Extended Profile | Version:
Severity: normal | Resolution:
Keywords: has-patch commit |
------------------------------+---------------------------
Comment (by r-a-y):
In [changeset:"11628"]:
{{{
#!CommitTicketReference repository="" revision="11628"
Avatars: After r11627, switch from using `is_string()` to `is_email()`
See #7424.
}}}
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From buddypress-trac at lists.automattic.com Fri Jul 7 18:25:30 2017
From: buddypress-trac at lists.automattic.com (buddypress-trac at lists.automattic.com)
Date: Fri, 7 Jul 2017 18:25:30 +0000 (UTC)
Subject: [buddypress-trac] [BuddyPress][11628]
trunk/src/bp-core/bp-core-avatars.php: Avatars: After r11627,
switch from using `is_string()` to `is_email()`
Message-ID: <20170707182530.4555B1080399@svn1.lax.wordpress.org>
An HTML attachment was scrubbed...
URL:
From buddypress-trac at lists.automattic.com Fri Jul 7 18:37:56 2017
From: buddypress-trac at lists.automattic.com (buddypress-trac at lists.automattic.com)
Date: Fri, 7 Jul 2017 18:37:56 +0000 (UTC)
Subject: [buddypress-trac] [BuddyPress][11629] branches/2.8: Activation:
Ensure we use the XProfile field' s default visibility level during
activation.
Message-ID: <20170707183756.0F9081080399@svn1.lax.wordpress.org>
An HTML attachment was scrubbed...
URL:
From noreply at wordpress.org Fri Jul 7 18:37:56 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Fri, 07 Jul 2017 18:37:56 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7553: Xprofile field
default visibility not honored during POST processing of registration form
In-Reply-To: <043.853c47a372047b28db7dcc09f6861320@wordpress.org>
References: <043.853c47a372047b28db7dcc09f6861320@wordpress.org>
Message-ID: <058.cb12b1b3fc8fb49923228d575c1c2cc5@wordpress.org>
#7553: Xprofile field default visibility not honored during POST processing of
registration form
--------------------------+---------------------
Reporter: uscore713 | Owner: r-a-y
Type: defect (bug) | Status: closed
Priority: high | Milestone: 2.9
Component: Registration | Version: 1.6
Severity: normal | Resolution: fixed
Keywords: has-patch |
--------------------------+---------------------
Changes (by r-a-y):
* owner: => r-a-y
* status: new => closed
* resolution: => fixed
Comment:
In [changeset:"11629"]:
{{{
#!CommitTicketReference repository="" revision="11629"
Activation: Ensure we use the XProfile field's default visibility level
during activation.
Previously, if the visibility option for a XProfile field was removed from
the registration template, the visibility level for the user would always
fallback to 'public' instead of what the actual XProfile field's default
visibility level was.
Commit includes a unit test and rectifies the problem.
Props uscore713.
Fixes #7553 (2.8-branch)
}}}
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From buddypress-trac at lists.automattic.com Fri Jul 7 18:38:58 2017
From: buddypress-trac at lists.automattic.com (buddypress-trac at lists.automattic.com)
Date: Fri, 7 Jul 2017 18:38:58 +0000 (UTC)
Subject: [buddypress-trac] [BuddyPress][11630] trunk: Activation: Ensure we
use the XProfile field' s default visibility level during activation.
Message-ID: <20170707183858.0C4201080399@svn1.lax.wordpress.org>
An HTML attachment was scrubbed...
URL:
From noreply at wordpress.org Fri Jul 7 18:38:58 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Fri, 07 Jul 2017 18:38:58 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7553: Xprofile field
default visibility not honored during POST processing of registration form
In-Reply-To: <043.853c47a372047b28db7dcc09f6861320@wordpress.org>
References: <043.853c47a372047b28db7dcc09f6861320@wordpress.org>
Message-ID: <058.7a00bfe888c478d76908157e4eb65c6f@wordpress.org>
#7553: Xprofile field default visibility not honored during POST processing of
registration form
--------------------------+---------------------
Reporter: uscore713 | Owner: r-a-y
Type: defect (bug) | Status: closed
Priority: high | Milestone: 2.9
Component: Registration | Version: 1.6
Severity: normal | Resolution: fixed
Keywords: has-patch |
--------------------------+---------------------
Comment (by r-a-y):
In [changeset:"11630"]:
{{{
#!CommitTicketReference repository="" revision="11630"
Activation: Ensure we use the XProfile field's default visibility level
during activation.
Previously, if the visibility option for a XProfile field was removed from
the registration template, the visibility level for the user would always
fallback to 'public' instead of what the actual XProfile field's default
visibility level was.
Commit includes a unit test and rectifies the problem.
Props uscore713.
Fixes #7553 (trunk)
}}}
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Fri Jul 7 18:46:29 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Fri, 07 Jul 2017 18:46:29 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7424: filter
get_avatar_url to parse URLs from BP avatars
In-Reply-To: <043.41c6f78af4d81fb32702afa1298d65c0@wordpress.org>
References: <043.41c6f78af4d81fb32702afa1298d65c0@wordpress.org>
Message-ID: <058.85c6d3ca4a42b96b91a27a25b6200c76@wordpress.org>
#7424: filter get_avatar_url to parse URLs from BP avatars
------------------------------+---------------------------
Reporter: elhardoum | Owner: boonebgorges
Type: defect (bug) | Status: closed
Priority: normal | Milestone: 2.9
Component: Extended Profile | Version:
Severity: normal | Resolution: fixed
Keywords: has-patch commit |
------------------------------+---------------------------
Changes (by r-a-y):
* status: reopened => closed
* resolution: => fixed
Comment:
Thanks for the report, @lne1030!
Just committed the fix.
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From buddypress-trac at lists.automattic.com Fri Jul 7 19:46:42 2017
From: buddypress-trac at lists.automattic.com (buddypress-trac at lists.automattic.com)
Date: Fri, 7 Jul 2017 19:46:42 +0000 (UTC)
Subject: [buddypress-trac] [BuddyPress][11631]
trunk/src/bp-core/bp-core-avatars.php: Avatars: After r11627,
ensure that `$user `is a `WP_User` object.
Message-ID: <20170707194642.959A71080399@svn1.lax.wordpress.org>
An HTML attachment was scrubbed...
URL:
From noreply at wordpress.org Fri Jul 7 19:46:43 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Fri, 07 Jul 2017 19:46:43 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7424: filter
get_avatar_url to parse URLs from BP avatars
In-Reply-To: <043.41c6f78af4d81fb32702afa1298d65c0@wordpress.org>
References: <043.41c6f78af4d81fb32702afa1298d65c0@wordpress.org>
Message-ID: <058.5978fbb0679f51b02b7d1990ade47c3c@wordpress.org>
#7424: filter get_avatar_url to parse URLs from BP avatars
------------------------------+---------------------------
Reporter: elhardoum | Owner: boonebgorges
Type: defect (bug) | Status: closed
Priority: normal | Milestone: 2.9
Component: Extended Profile | Version:
Severity: normal | Resolution: fixed
Keywords: has-patch commit |
------------------------------+---------------------------
Comment (by r-a-y):
In [changeset:"11631"]:
{{{
#!CommitTicketReference repository="" revision="11631"
Avatars: After r11627, ensure that `$user `is a `WP_User` object.
In `bp_core_get_avatar_data_url_filter()`, passing an email address that
is
not a WP user would throw a notice.
See #7424.
}}}
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Fri Jul 7 22:08:44 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Fri, 07 Jul 2017 22:08:44 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #6736: Allow users to
create WP posts on Buddypress Profile
In-Reply-To: <040.aa9bb8ffbc0db31c08cb559cc94d64d4@wordpress.org>
References: <040.aa9bb8ffbc0db31c08cb559cc94d64d4@wordpress.org>
Message-ID: <055.aaace2173012eaa1b3a48b0835edb0f3@wordpress.org>
#6736: Allow users to create WP posts on Buddypress Profile
--------------------------+----------------------
Reporter: Dono12 | Owner:
Type: enhancement | Status: closed
Priority: normal | Milestone:
Component: Members | Version: 2.4.0
Severity: normal | Resolution: invalid
Keywords: dev-feedback |
--------------------------+----------------------
Comment (by Dono12):
Hey @boonebgorges and @DJPaul,
Can you guys please remove the instance of the site name in this URL:
'''http://PLEASE CHANGE THIS NAME TO SITE-NAME/wp-
content/uploads/2015/10/userpost.jpg.
'''
At the time of this post I was a newbie and I didn't take into account
Indexing by search engines.
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Sat Jul 8 08:45:30 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Sat, 08 Jul 2017 08:45:30 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7188: Remove/Replace
`title` attributes with Tooltips usable in all devices
In-Reply-To: <041.83fb7f5cbce9a414fb2d094fdf12c0aa@wordpress.org>
References: <041.83fb7f5cbce9a414fb2d094fdf12c0aa@wordpress.org>
Message-ID: <056.1ecfa8fd156177351c72469c287df9b5@wordpress.org>
#7188: Remove/Replace `title` attributes with Tooltips usable in all devices
----------------------------------------------+----------------------
Reporter: mercime | Owner: mercime
Type: enhancement | Status: closed
Priority: normal | Milestone: 2.9
Component: Core | Version:
Severity: normal | Resolution: fixed
Keywords: has-screenshots has-patch commit |
----------------------------------------------+----------------------
Changes (by mercime):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"11632"]:
{{{
#!CommitTicketReference repository="" revision="11632"
Adjust and organize BP Tooltip styles.
Fixes #7188.
}}}
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Sat Jul 8 13:13:10 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Sat, 08 Jul 2017 13:13:10 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #6736: Allow users to
create WP posts on Buddypress Profile
In-Reply-To: <040.aa9bb8ffbc0db31c08cb559cc94d64d4@wordpress.org>
References: <040.aa9bb8ffbc0db31c08cb559cc94d64d4@wordpress.org>
Message-ID: <055.3617e2297582249d0d73243ca92e0294@wordpress.org>
#6736: Allow users to create WP posts on Buddypress Profile
--------------------------+----------------------
Reporter: Dono12 | Owner:
Type: enhancement | Status: closed
Priority: normal | Milestone:
Component: Members | Version: 2.4.0
Severity: normal | Resolution: invalid
Keywords: dev-feedback |
--------------------------+----------------------
Old description:
> Can the developers/contributors add a post on profile button to show user
> posts in the next update. It makes sense to have this function as it
> incorporates Wordpress and Buddypress respectively. There is only one
> plugin that I found which accomplished this feet:
>
> BP Posts On
> Profile
>
> by Huseyin Berberoglu. The plugin is out of date and it takes tons of
> modifications to get it going with an up to date Buddypress install.
>
> The second method is a block of code placed in functions.php
>
> {{{
>
> function importSomething(){
> return include_once 'bp-custom.php';
> }
> add_action( 'bp_setup_nav', 'buddyboss_child_bp_nav_adder' );
> add_action( 'bp_template_content', 'profile_buddyboss_child_loop' );
> bp_core_load_template( apply_filters( 'bp_core_template_plugin',
> 'members/single/plugins' ) );
>
> function buddyboss_child_bp_nav_adder() {
> global $bp;
> $post_count = count_user_posts_by_type( $bp->displayed_user->id );
> bp_core_new_nav_item(
> array(
> 'name' => sprintf( __( 'Posts %d', 'my-poems' ), $post_count
> ),
> 'slug' => 'Articles',
> 'position' => 250,
> 'show_for_displayed_user' => true,
> 'screen_function' => 'buddyboss_child_list',
> 'item_css_id' => 'articles',
> 'default_subnav_slug' => 'public'
> ));
> }
> function buddyboss_child_list() {
> add_action( 'bp_template_content', 'profile_buddyboss_child_loop' );
> bp_core_load_template( apply_filters( 'bp_core_template_plugin',
> 'members/single/plugins' ) );
> }
> /*------- This is end of the code for above function ---------*/
> function profile_buddyboss_child_loop() {
> $myposts = get_posts( array(
> 'posts_per_page' => -1,
> 'author' => bp_displayed_user_id(),
> 'post_type' => 'post'
> ));
> if( ! empty($myposts) ) {
> foreach($myposts as $post) {
> setup_postdata( $post );
> if (has_post_thumbnail( $post->ID ) ):
> $image = wp_get_attachment_image_src( get_post_thumbnail_id( $post->ID ),
> 'sidebar-smallthumbnew' );
> else :
>
> $image[0] = "http://www.movemie.com/wp-
> content/uploads/2015/10/userpost.jpg";
> endif;
>
> echo '';
> }
> echo '';
> wp_reset_postdata();
> } else { ?>
>
> }
> /* This is end of the code for above function */
> remove_filter('bp_setup_nav','');
> function count_user_posts_by_type( $userid, $post_type = 'post' ) {
> global $wpdb;
> $where = get_posts_by_author_sql( $post_type, true, $userid, true);
> $count = $wpdb->get_var( "SELECT COUNT(*) FROM $wpdb->posts $where" );
> return apply_filters( 'get_usernumposts', $count, $userid );
> }
> }}}
>
>
> This works fine but it's quite limited. It also messes with Buddypress
> updates rendering the two latest Buddypress updates useless (Star
> message, and Upload Background image).
>
> Guys please get around to integrating this ability in Buddypress so one
> doesn't have to spend hours searching and trouble shooting for a function
> which I believe and others should be an already main component.
New description:
Can the developers/contributors add a post on profile button to show user
posts in the next update. It makes sense to have this function as it
incorporates Wordpress and Buddypress respectively. There is only one
plugin that I found which accomplished this feet:
BP Posts On
Profile
by Huseyin Berberoglu. The plugin is out of date and it takes tons of
modifications to get it going with an up to date Buddypress install.
The second method is a block of code placed in functions.php
{{{
function importSomething(){
return include_once 'bp-custom.php';
}
add_action( 'bp_setup_nav', 'buddyboss_child_bp_nav_adder' );
add_action( 'bp_template_content', 'profile_buddyboss_child_loop' );
bp_core_load_template( apply_filters( 'bp_core_template_plugin',
'members/single/plugins' ) );
function buddyboss_child_bp_nav_adder() {
global $bp;
$post_count = count_user_posts_by_type( $bp->displayed_user->id );
bp_core_new_nav_item(
array(
'name' => sprintf( __( 'Posts %d', 'my-poems' ), $post_count
),
'slug' => 'Articles',
'position' => 250,
'show_for_displayed_user' => true,
'screen_function' => 'buddyboss_child_list',
'item_css_id' => 'articles',
'default_subnav_slug' => 'public'
));
}
function buddyboss_child_list() {
add_action( 'bp_template_content', 'profile_buddyboss_child_loop' );
bp_core_load_template( apply_filters( 'bp_core_template_plugin',
'members/single/plugins' ) );
}
/*------- This is end of the code for above function ---------*/
function profile_buddyboss_child_loop() {
$myposts = get_posts( array(
'posts_per_page' => -1,
'author' => bp_displayed_user_id(),
'post_type' => 'post'
));
if( ! empty($myposts) ) {
foreach($myposts as $post) {
setup_postdata( $post );
if (has_post_thumbnail( $post->ID ) ):
$image = wp_get_attachment_image_src( get_post_thumbnail_id( $post->ID ),
'sidebar-smallthumbnew' );
else :
$image[0] = "http://www.example.com/wp-
content/uploads/2015/10/userpost.jpg";
endif;
echo '';
}
echo '';
wp_reset_postdata();
} else { ?>
get_var( "SELECT COUNT(*) FROM $wpdb->posts $where" );
return apply_filters( 'get_usernumposts', $count, $userid );
}
}}}
This works fine but it's quite limited. It also messes with Buddypress
updates rendering the two latest Buddypress updates useless (Star message,
and Upload Background image).
Guys please get around to integrating this ability in Buddypress so one
doesn't have to spend hours searching and trouble shooting for a function
which I believe and others should be an already main component.
--
Comment (by boonebgorges):
Changed.
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Mon Jul 10 17:17:00 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Mon, 10 Jul 2017 17:17:00 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7565: Multisite signups do not
have a WordPress role
Message-ID: <039.533f6d24a01420d7cd498592c07ab475@wordpress.org>
#7565: Multisite signups do not have a WordPress role
--------------------------+-----------------------------
Reporter: r-a-y | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Members | Version:
Severity: normal | Keywords: has-patch
--------------------------+-----------------------------
When a user registers on a multisite install, after the user activates
their account, that user does not have a WordPress role on the BP root
blog.
To duplicate:
- Set up a multisite install and enable user registration.
- Go to the BP signup page (example.com/register) and register a new user.
- Activate the new user.
- Now, login as an administrator to the root blog's admin dashboard
"Users" page.
- You'll notice that the user is not listed because the new user has no
WordPress role on the root blog.
The problem is during the activation process, `wpmu_create_user()` (via
`wpmu_activate_signup()`) does not add a role:
https://github.com/WordPress/WordPress/blob/4.8-branch/wp-includes/ms-
functions.php#L1116
However, we do add a role for single site signups, but not multisite:
https://buddypress.trac.wordpress.org/browser/tags/2.8.2/src/bp-members
/bp-members-functions.php?marks=2001-2002#L1991
Attached patch will add a default role regardless of the WP install after
activation. Also includes a unit test.
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From buddypress-trac at lists.automattic.com Mon Jul 10 17:34:25 2017
From: buddypress-trac at lists.automattic.com (buddypress-trac at lists.automattic.com)
Date: Mon, 10 Jul 2017 17:34:25 +0000 (UTC)
Subject: [buddypress-trac] [BuddyPress][11633]
trunk/src/bp-core/bp-core-avatars.php: Avatars: After r11627,
move email check after user object checks.
Message-ID: <20170710173425.A535A10803B7@svn1.lax.wordpress.org>
An HTML attachment was scrubbed...
URL:
From noreply at wordpress.org Mon Jul 10 17:34:26 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Mon, 10 Jul 2017 17:34:26 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7424: filter
get_avatar_url to parse URLs from BP avatars
In-Reply-To: <043.41c6f78af4d81fb32702afa1298d65c0@wordpress.org>
References: <043.41c6f78af4d81fb32702afa1298d65c0@wordpress.org>
Message-ID: <058.b43c4d61f334ac6f78ec8d84ffaada3e@wordpress.org>
#7424: filter get_avatar_url to parse URLs from BP avatars
------------------------------+---------------------------
Reporter: elhardoum | Owner: boonebgorges
Type: defect (bug) | Status: closed
Priority: normal | Milestone: 2.9
Component: Extended Profile | Version:
Severity: normal | Resolution: fixed
Keywords: has-patch commit |
------------------------------+---------------------------
Comment (by r-a-y):
In [changeset:"11633"]:
{{{
#!CommitTicketReference repository="" revision="11633"
Avatars: After r11627, move email check after user object checks.
Avoids notices from occurring.
See #7424.
}}}
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Tue Jul 11 11:22:38 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Tue, 11 Jul 2017 11:22:38 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7566: Activity: block 2nd
click on .activity-read-more
Message-ID: <041.40022f553bd204f6b5e2d6274366e5d8@wordpress.org>
#7566: Activity: block 2nd click on .activity-read-more
--------------------------+-----------------------------
Reporter: slaFFik | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Activity | Version:
Severity: normal | Keywords:
--------------------------+-----------------------------
If the activity record has a long content, it will have a Read more link
that upon click will expand and reveal the whole content.
This link is ajaxified, but it doesn't have a blocker, that prevents
multiple clicks and several requests sending and UI issue as well (see
attached gif).
Might be a good idea to block clicks after the 1st one until response is
received and processed.
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Tue Jul 11 11:24:06 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Tue, 11 Jul 2017 11:24:06 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7566: Activity: block 2nd
click on .activity-read-more
In-Reply-To: <041.40022f553bd204f6b5e2d6274366e5d8@wordpress.org>
References: <041.40022f553bd204f6b5e2d6274366e5d8@wordpress.org>
Message-ID: <056.2adf22959355279648589ed5be34b4e4@wordpress.org>
#7566: Activity: block 2nd click on .activity-read-more
----------------------------------------+------------------------------
Reporter: slaFFik | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Activity | Version:
Severity: normal | Resolution:
Keywords: needs-patch good-first-bug |
----------------------------------------+------------------------------
Changes (by slaFFik):
* keywords: => needs-patch good-first-bug
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Wed Jul 12 04:56:44 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Wed, 12 Jul 2017 04:56:44 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7567: Switch Travis CI
environment to Trusty - PHP 5.2 to be no longer available Sept 2017
Message-ID: <040.02ae7932ffbd5766c7c8acf4e7b7f3c0@wordpress.org>
#7567: Switch Travis CI environment to Trusty - PHP 5.2 to be no longer available
Sept 2017
------------------------------+--------------------
Reporter: netweb | Owner: netweb
Type: defect (bug) | Status: new
Priority: normal | Milestone: 2.9
Component: Build/Test Tools | Version:
Severity: normal | Keywords:
------------------------------+--------------------
Via #WP41292
Travis CI have announced they are going to switch to Trusty as the default
distro come July 18th 2017
> https://blog.travis-ci.com/2017-07-11-trusty-as-default-linux-is-coming
Incoming patch will allow us to continue having PHP 5.2 Travis CI jobs
until September 2017
----
The current availability of PHP 5.2 in the Travis CI build environment is
the following:
1. ? `dist: precise` with `sudo: false`
2. ? `dist: trusty` with `sudo: false`
3. ? `dist: precise` with `sudo: false`
4. ? `dist: precise` with `sudo: required`
BuddyPress' current Travis CI config uses option `1` above
Travis CI will override this configuration with option `2` come July 18th
2017
We can work around this issue for PHP 5.2 until September 2017 using
option `3` for the PHP 5.2 Travis CI job
Come September 2017 Travis CI will overwrite option `3` above with option
`4`
I've created the following Travis CI issue on the subject:
https://github.com/travis-ci/travis-ci/issues/8072
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Wed Jul 12 05:36:02 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Wed, 12 Jul 2017 05:36:02 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7567: Switch Travis CI
environment to Trusty - PHP 5.2 & 5.3 no longer available Sept 2017 (was:
Switch Travis CI environment to Trusty - PHP 5.2 to be no longer available
Sept 2017)
In-Reply-To: <040.02ae7932ffbd5766c7c8acf4e7b7f3c0@wordpress.org>
References: <040.02ae7932ffbd5766c7c8acf4e7b7f3c0@wordpress.org>
Message-ID: <055.66311c61e0fe4bf9a2f6ae6cd4d79eb6@wordpress.org>
#7567: Switch Travis CI environment to Trusty - PHP 5.2 & 5.3 no longer available
Sept 2017
------------------------------+---------------------
Reporter: netweb | Owner: netweb
Type: defect (bug) | Status: new
Priority: normal | Milestone: 2.9
Component: Build/Test Tools | Version:
Severity: normal | Resolution:
Keywords: |
------------------------------+---------------------
Description changed by netweb:
Old description:
> Via #WP41292
>
> Travis CI have announced they are going to switch to Trusty as the
> default distro come July 18th 2017
> > https://blog.travis-ci.com/2017-07-11-trusty-as-default-linux-is-coming
>
> Incoming patch will allow us to continue having PHP 5.2 Travis CI jobs
> until September 2017
>
> ----
>
> The current availability of PHP 5.2 in the Travis CI build environment
> is the following:
>
> 1. ? `dist: precise` with `sudo: false`
> 2. ? `dist: trusty` with `sudo: false`
> 3. ? `dist: precise` with `sudo: false`
> 4. ? `dist: precise` with `sudo: required`
>
> BuddyPress' current Travis CI config uses option `1` above
> Travis CI will override this configuration with option `2` come July 18th
> 2017
> We can work around this issue for PHP 5.2 until September 2017 using
> option `3` for the PHP 5.2 Travis CI job
> Come September 2017 Travis CI will overwrite option `3` above with option
> `4`
>
> I've created the following Travis CI issue on the subject:
> https://github.com/travis-ci/travis-ci/issues/8072
New description:
Via #WP41292
Travis CI have announced they are going to switch to Trusty as the default
distro come July 18th 2017
> https://blog.travis-ci.com/2017-07-11-trusty-as-default-linux-is-coming
Incoming patch will allow us to continue having PHP 5.2 & 5.3 Travis CI
jobs until September 2017
----
The current availability of PHP 5.2 & 5.3 in the Travis CI build
environment is the following:
1. ? `dist: precise` with `sudo: false`
2. ? `dist: trusty` with `sudo: false`
3. ? `dist: precise` with `sudo: false`
4. ? `dist: precise` with `sudo: required`
BuddyPress' current Travis CI config uses option `1` above
Travis CI will override this configuration with option `2` come July 18th
2017
We can work around this issue for PHP 5.2 & 5.3 until September 2017 using
option `3` for the PHP 5.2 & 5.3 Travis CI job
Come September 2017 Travis CI will overwrite option `3` above with option
`4`
I've created the following Travis CI issue on the subject:
https://github.com/travis-ci/travis-ci/issues/8072
--
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Wed Jul 12 05:55:55 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Wed, 12 Jul 2017 05:55:55 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7567: Switch Travis CI
environment to Trusty - PHP 5.3 no longer available Sept 2017 (was: Switch
Travis CI environment to Trusty - PHP 5.2 & 5.3 no longer available Sept
2017)
In-Reply-To: <040.02ae7932ffbd5766c7c8acf4e7b7f3c0@wordpress.org>
References: <040.02ae7932ffbd5766c7c8acf4e7b7f3c0@wordpress.org>
Message-ID: <055.5961e6c819977f1c79d99f1c42b2b696@wordpress.org>
#7567: Switch Travis CI environment to Trusty - PHP 5.3 no longer available Sept
2017
------------------------------+---------------------
Reporter: netweb | Owner: netweb
Type: defect (bug) | Status: new
Priority: normal | Milestone: 2.9
Component: Build/Test Tools | Version:
Severity: normal | Resolution:
Keywords: |
------------------------------+---------------------
Old description:
> Via #WP41292
>
> Travis CI have announced they are going to switch to Trusty as the
> default distro come July 18th 2017
> > https://blog.travis-ci.com/2017-07-11-trusty-as-default-linux-is-coming
>
> Incoming patch will allow us to continue having PHP 5.2 & 5.3 Travis CI
> jobs until September 2017
>
> ----
>
> The current availability of PHP 5.2 & 5.3 in the Travis CI build
> environment is the following:
>
> 1. ? `dist: precise` with `sudo: false`
> 2. ? `dist: trusty` with `sudo: false`
> 3. ? `dist: precise` with `sudo: false`
> 4. ? `dist: precise` with `sudo: required`
>
> BuddyPress' current Travis CI config uses option `1` above
> Travis CI will override this configuration with option `2` come July 18th
> 2017
> We can work around this issue for PHP 5.2 & 5.3 until September 2017
> using option `3` for the PHP 5.2 & 5.3 Travis CI job
> Come September 2017 Travis CI will overwrite option `3` above with option
> `4`
>
> I've created the following Travis CI issue on the subject:
> https://github.com/travis-ci/travis-ci/issues/8072
New description:
Via #WP41292
Travis CI have announced they are going to switch to Trusty as the default
distro come July 18th 2017
> https://blog.travis-ci.com/2017-07-11-trusty-as-default-linux-is-coming
Incoming patch will allow us to continue having PHP 5.3 Travis CI jobs
until September 2017
----
The current availability of PHP 5.3 in the Travis CI build environment is
the following:
1. ? `dist: precise` with `sudo: false`
2. ? `dist: trusty` with `sudo: false`
3. ? `dist: precise` with `sudo: false`
4. ? `dist: precise` with `sudo: required`
BuddyPress' current Travis CI config uses option `1` above
Travis CI will override this configuration with option `2` come July 18th
2017
We can work around this issue for PHP 5.3 until September 2017 using
option `3` for the PHP 5.3 Travis CI job
Come September 2017 Travis CI will overwrite option `3` above with option
`4`
I've created the following Travis CI issue on the subject:
https://github.com/travis-ci/travis-ci/issues/8072
--
Comment (by netweb):
Updated ticket to remove PHP 5.2 references as BP no longer supports PHP
5.2 :)
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Wed Jul 12 06:08:01 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Wed, 12 Jul 2017 06:08:01 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7567: Switch Travis CI
environment to Trusty - PHP 5.3 no longer available Sept 2017
In-Reply-To: <040.02ae7932ffbd5766c7c8acf4e7b7f3c0@wordpress.org>
References: <040.02ae7932ffbd5766c7c8acf4e7b7f3c0@wordpress.org>
Message-ID: <055.d5f302c8561f07a703adecd2c719ace1@wordpress.org>
#7567: Switch Travis CI environment to Trusty - PHP 5.3 no longer available Sept
2017
------------------------------+---------------------
Reporter: netweb | Owner: netweb
Type: defect (bug) | Status: closed
Priority: normal | Milestone: 2.9
Component: Build/Test Tools | Version:
Severity: normal | Resolution: fixed
Keywords: |
------------------------------+---------------------
Changes (by netweb):
* status: new => closed
* resolution: => fixed
Comment:
In [changeset:"11634"]:
{{{
#!CommitTicketReference repository="" revision="11634"
Build Tools: Switch to Ubuntu Trusty as the the default linux distro for
Travis CI.
* This changeset also explicitly adds `dist: precise` to the PHP 5.3 build
job.
* Travis CI will discontinue support of PHP 5.3 in September 2017 and a
further follow up will be required.
Fixes #7567.
}}}
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From buddypress-trac at lists.automattic.com Wed Jul 12 06:08:01 2017
From: buddypress-trac at lists.automattic.com (buddypress-trac at lists.automattic.com)
Date: Wed, 12 Jul 2017 06:08:01 +0000 (UTC)
Subject: [buddypress-trac] [BuddyPress][11634] trunk/.travis.yml: Build
Tools: Switch to Ubuntu Trusty as the the default linux distro for Travis
CI.
Message-ID: <20170712060801.0BDDE1080615@svn1.lax.wordpress.org>
An HTML attachment was scrubbed...
URL:
From noreply at wordpress.org Wed Jul 12 09:42:07 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Wed, 12 Jul 2017 09:42:07 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7565: Multisite signups do
not have a WordPress role
In-Reply-To: <039.533f6d24a01420d7cd498592c07ab475@wordpress.org>
References: <039.533f6d24a01420d7cd498592c07ab475@wordpress.org>
Message-ID: <054.66f72437c509a5b11f2e5d56a33a69e1@wordpress.org>
#7565: Multisite signups do not have a WordPress role
--------------------------+------------------------------
Reporter: r-a-y | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Members | Version:
Severity: normal | Resolution:
Keywords: has-patch |
--------------------------+------------------------------
Comment (by needle):
@r-a-y Heh, well it seems I've been labouring under the misapprehension
that this was by design (i.e. leaving it up to the developer to decide how
and when to assign a role to new users) and I've always included code
along the lines of your patch in each of my BuddyPress installs. However I
tend to use BP Registration Options (or similar) to moderate signups, so I
hook into later actions provided by BPRO when moderation has taken place.
Doing so will mean BPRO (and similar plugins) will need to unhook this to
prevent unmoderated users from receiving the default role.
tl;dr Worth publicising this before committing?
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Wed Jul 12 11:26:25 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Wed, 12 Jul 2017 11:26:25 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7555: BuddyPress Canonical
Redirects and Trailing Slashes
In-Reply-To: <039.df74e39e73f907930ee3a85199392968@wordpress.org>
References: <039.df74e39e73f907930ee3a85199392968@wordpress.org>
Message-ID: <054.812b0037989a837777ae4f1c2669f003@wordpress.org>
#7555: BuddyPress Canonical Redirects and Trailing Slashes
--------------------------+------------------
Reporter: MegaZ | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 3.0
Component: Core | Version: 1.5
Severity: normal | Resolution:
Keywords: needs-patch |
--------------------------+------------------
Changes (by hnla):
* milestone: 2.9 => 3.0
Comment:
Will have to be dealt with in 3.0 now.
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From buddypress-trac at lists.automattic.com Wed Jul 12 12:07:13 2017
From: buddypress-trac at lists.automattic.com (buddypress-trac at lists.automattic.com)
Date: Wed, 12 Jul 2017 12:07:13 +0000 (UTC)
Subject: [buddypress-trac] [BuddyPress][11635] trunk/.travis.yml: Build
Tools: Move PHP 5.3 Travis CI job from the `php` section to the `matrix`
section.
Message-ID: <20170712120713.7FB3F1080287@svn1.lax.wordpress.org>
An HTML attachment was scrubbed...
URL:
From noreply at wordpress.org Wed Jul 12 12:07:14 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Wed, 12 Jul 2017 12:07:14 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7567: Switch Travis CI
environment to Trusty - PHP 5.3 no longer available Sept 2017
In-Reply-To: <040.02ae7932ffbd5766c7c8acf4e7b7f3c0@wordpress.org>
References: <040.02ae7932ffbd5766c7c8acf4e7b7f3c0@wordpress.org>
Message-ID: <055.2765af97984d87c949fd1f18c0291102@wordpress.org>
#7567: Switch Travis CI environment to Trusty - PHP 5.3 no longer available Sept
2017
------------------------------+---------------------
Reporter: netweb | Owner: netweb
Type: defect (bug) | Status: closed
Priority: normal | Milestone: 2.9
Component: Build/Test Tools | Version:
Severity: normal | Resolution: fixed
Keywords: |
------------------------------+---------------------
Comment (by netweb):
In [changeset:"11635"]:
{{{
#!CommitTicketReference repository="" revision="11635"
Build Tools: Move PHP 5.3 Travis CI job from the `php` section to the
`matrix` section.
This changeset is a follow up to [11634] where the "build matrix" was
broken, my bad.
See #7567.
}}}
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From buddypress-trac at lists.automattic.com Wed Jul 12 12:17:33 2017
From: buddypress-trac at lists.automattic.com (buddypress-trac at lists.automattic.com)
Date: Wed, 12 Jul 2017 12:17:33 +0000 (UTC)
Subject: [buddypress-trac] [BuddyPress][11636]
trunk/src/bp-core/classes/class-bp-admin.php: Update credits list -
`'Contributors to BuddyPress 2.9'`
Message-ID: <20170712121733.C3F661080287@svn1.lax.wordpress.org>
An HTML attachment was scrubbed...
URL:
From noreply at wordpress.org Wed Jul 12 16:33:28 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Wed, 12 Jul 2017 16:33:28 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7565: Multisite signups do
not have a WordPress role
In-Reply-To: <039.533f6d24a01420d7cd498592c07ab475@wordpress.org>
References: <039.533f6d24a01420d7cd498592c07ab475@wordpress.org>
Message-ID: <054.3a7b80d59f788f512de45e62ba529734@wordpress.org>
#7565: Multisite signups do not have a WordPress role
------------------------------------------------+--------------------------
Reporter: r-a-y | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting
Component: Members | Review
Severity: normal | Version:
Keywords: has-patch dev-feedback 2nd-opinion | Resolution:
------------------------------------------------+--------------------------
Changes (by r-a-y):
* keywords: has-patch => has-patch dev-feedback 2nd-opinion
Comment:
I would say that the role addition is currently inconsistent. If we add
the default role on single site, then why don't we add the default role on
multisite?
I understand that plugins such as Multisite User Management have had to
workaround this issue by adding their own role, so there is a potential
conflict here. However, WordPress allows a user to have multiple roles,
but addding the default role might be unwanted like what you mention
above.
Maybe we do nothing here?
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Wed Jul 12 16:44:19 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Wed, 12 Jul 2017 16:44:19 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7568: Avoid passing WP_Comment
object to `is_email()` when filtering avatar URL
Message-ID: <040.5e5dbc6b9999a5ed40e3e0c4e01634fc@wordpress.org>
#7568: Avoid passing WP_Comment object to `is_email()` when filtering avatar URL
--------------------------+-----------------------------
Reporter: needle | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Core | Version:
Severity: minor | Keywords:
--------------------------+-----------------------------
Comments by anonymous comment authors (i.e. without a user account) fall
through the current logic in `bp_core_get_avatar_data_url_filter` and the
`WP_Comment` object is passed to `is_email()` which expects a string - and
therefore throws a PHP Warning: "strlen() expects parameter 1 to be
string".
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Wed Jul 12 16:49:40 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Wed, 12 Jul 2017 16:49:40 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7568: Avoid passing
WP_Comment object to `is_email()` when filtering avatar URL
In-Reply-To: <040.5e5dbc6b9999a5ed40e3e0c4e01634fc@wordpress.org>
References: <040.5e5dbc6b9999a5ed40e3e0c4e01634fc@wordpress.org>
Message-ID: <055.2ba92381116a29f650cb3bb8b554d217@wordpress.org>
#7568: Avoid passing WP_Comment object to `is_email()` when filtering avatar URL
--------------------------+------------------
Reporter: needle | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 2.9
Component: Core | Version:
Severity: minor | Resolution:
Keywords: needs-patch |
--------------------------+------------------
Changes (by r-a-y):
* keywords: => needs-patch
* milestone: Awaiting Review => 2.9
Comment:
Ugh. Good catch.
I hate that we have to do our own user checking in the `'get_avatar_url'`
filter. WordPress shouldn't make us have to do that.
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Wed Jul 12 17:00:45 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Wed, 12 Jul 2017 17:00:45 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7568: Avoid passing
WP_Comment object to `is_email()` when filtering avatar URL
In-Reply-To: <040.5e5dbc6b9999a5ed40e3e0c4e01634fc@wordpress.org>
References: <040.5e5dbc6b9999a5ed40e3e0c4e01634fc@wordpress.org>
Message-ID: <055.65372054ea21ef18066467a187b72066@wordpress.org>
#7568: Avoid passing WP_Comment object to `is_email()` when filtering avatar URL
--------------------------+------------------
Reporter: needle | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 2.9
Component: Core | Version:
Severity: minor | Resolution:
Keywords: has-patch |
--------------------------+------------------
Changes (by r-a-y):
* keywords: needs-patch => has-patch
Comment:
Oops, didn't see your patch there, @needle! Same as mine :)
Will commit in the next hour.
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Wed Jul 12 17:06:40 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Wed, 12 Jul 2017 17:06:40 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7568: Avoid passing
WP_Comment object to `is_email()` when filtering avatar URL
In-Reply-To: <040.5e5dbc6b9999a5ed40e3e0c4e01634fc@wordpress.org>
References: <040.5e5dbc6b9999a5ed40e3e0c4e01634fc@wordpress.org>
Message-ID: <055.be27911112bd67333d8ea382a4b34388@wordpress.org>
#7568: Avoid passing WP_Comment object to `is_email()` when filtering avatar URL
--------------------------+------------------
Reporter: needle | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 2.9
Component: Core | Version:
Severity: minor | Resolution:
Keywords: has-patch |
--------------------------+------------------
Comment (by needle):
@r-a-y No problem and thanks!
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From buddypress-trac at lists.automattic.com Wed Jul 12 18:04:19 2017
From: buddypress-trac at lists.automattic.com (buddypress-trac at lists.automattic.com)
Date: Wed, 12 Jul 2017 18:04:19 +0000 (UTC)
Subject: [buddypress-trac] [BuddyPress][11637] trunk/src/bp-notifications/
bp-notifications-template.php: Add bp-tooltip class for notification
actions.
Message-ID: <20170712180419.18B491080287@svn1.lax.wordpress.org>
An HTML attachment was scrubbed...
URL:
From noreply at wordpress.org Wed Jul 12 18:04:19 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Wed, 12 Jul 2017 18:04:19 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7188: Remove/Replace
`title` attributes with Tooltips usable in all devices
In-Reply-To: <041.83fb7f5cbce9a414fb2d094fdf12c0aa@wordpress.org>
References: <041.83fb7f5cbce9a414fb2d094fdf12c0aa@wordpress.org>
Message-ID: <056.7677a68caa8ce8815529606d602680fa@wordpress.org>
#7188: Remove/Replace `title` attributes with Tooltips usable in all devices
----------------------------------------------+----------------------
Reporter: mercime | Owner: mercime
Type: enhancement | Status: closed
Priority: normal | Milestone: 2.9
Component: Core | Version:
Severity: normal | Resolution: fixed
Keywords: has-screenshots has-patch commit |
----------------------------------------------+----------------------
Comment (by mercime):
In [changeset:"11637"]:
{{{
#!CommitTicketReference repository="" revision="11637"
Add bp-tooltip class for notification actions.
Fixes #7188.
}}}
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From buddypress-trac at lists.automattic.com Wed Jul 12 18:21:08 2017
From: buddypress-trac at lists.automattic.com (buddypress-trac at lists.automattic.com)
Date: Wed, 12 Jul 2017 18:21:08 +0000 (UTC)
Subject: [buddypress-trac] [BuddyPress][11638]
trunk/src/bp-core/bp-core-avatars.php: Avatars: After r11627,
fix notices appearing for anonymous commenters.
Message-ID: <20170712182108.311041080287@svn1.lax.wordpress.org>
An HTML attachment was scrubbed...
URL:
From noreply at wordpress.org Wed Jul 12 18:21:08 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Wed, 12 Jul 2017 18:21:08 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7424: filter
get_avatar_url to parse URLs from BP avatars
In-Reply-To: <043.41c6f78af4d81fb32702afa1298d65c0@wordpress.org>
References: <043.41c6f78af4d81fb32702afa1298d65c0@wordpress.org>
Message-ID: <058.b9d7ee1a44157c8bdf0b9389125d42da@wordpress.org>
#7424: filter get_avatar_url to parse URLs from BP avatars
------------------------------+---------------------------
Reporter: elhardoum | Owner: boonebgorges
Type: defect (bug) | Status: closed
Priority: normal | Milestone: 2.9
Component: Extended Profile | Version:
Severity: normal | Resolution: fixed
Keywords: has-patch commit |
------------------------------+---------------------------
Comment (by r-a-y):
In [changeset:"11638"]:
{{{
#!CommitTicketReference repository="" revision="11638"
Avatars: After r11627, fix notices appearing for anonymous commenters.
Props needle. See #7424.
Fixes #7568.
}}}
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Wed Jul 12 18:21:08 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Wed, 12 Jul 2017 18:21:08 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7568: Avoid passing
WP_Comment object to `is_email()` when filtering avatar URL
In-Reply-To: <040.5e5dbc6b9999a5ed40e3e0c4e01634fc@wordpress.org>
References: <040.5e5dbc6b9999a5ed40e3e0c4e01634fc@wordpress.org>
Message-ID: <055.a072d7b843ccf2e8604ece5bf6b59073@wordpress.org>
#7568: Avoid passing WP_Comment object to `is_email()` when filtering avatar URL
--------------------------+---------------------
Reporter: needle | Owner: r-a-y
Type: defect (bug) | Status: closed
Priority: normal | Milestone: 2.9
Component: Core | Version:
Severity: minor | Resolution: fixed
Keywords: has-patch |
--------------------------+---------------------
Changes (by r-a-y):
* owner: => r-a-y
* status: new => closed
* resolution: => fixed
Comment:
In [changeset:"11638"]:
{{{
#!CommitTicketReference repository="" revision="11638"
Avatars: After r11627, fix notices appearing for anonymous commenters.
Props needle. See #7424.
Fixes #7568.
}}}
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Wed Jul 12 19:45:07 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Wed, 12 Jul 2017 19:45:07 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7564: A forgotten %s in
french translation is making the Activity JavaScript to fail with
favorites.
In-Reply-To: <039.c275d95edd0c4032eec3b0a5eef30e32@wordpress.org>
References: <039.c275d95edd0c4032eec3b0a5eef30e32@wordpress.org>
Message-ID: <054.6683a96b0c5f2bc49eb14c9f8f41b365@wordpress.org>
#7564: A forgotten %s in french translation is making the Activity JavaScript to
fail with favorites.
-------------------------------------+------------------------------
Reporter: imath | Owner: slaFFik
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting Review
Component: I18N | Version: 2.8.2
Severity: normal | Resolution:
Keywords: i18n-change 2nd-opinion |
-------------------------------------+------------------------------
Comment (by r-a-y):
Hi @imath,
Is this something that needs to be done on GlotPress? It looks like you
are a Contributor, but not an Editor. I'm not sure if GlotPress
contributors can accept changes.
@danbp appears to be the French editor:
https://translate.wordpress.org/locale/fr/default/wp-plugins/buddypress
Maybe he can confirm your change?
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Wed Jul 12 23:15:52 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Wed, 12 Jul 2017 23:15:52 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7553: Xprofile field
default visibility not honored during POST processing of registration form
In-Reply-To: <043.853c47a372047b28db7dcc09f6861320@wordpress.org>
References: <043.853c47a372047b28db7dcc09f6861320@wordpress.org>
Message-ID: <058.b5e17565ebcf6c03d29bdb6170635692@wordpress.org>
#7553: Xprofile field default visibility not honored during POST processing of
registration form
--------------------------+---------------------
Reporter: uscore713 | Owner: r-a-y
Type: defect (bug) | Status: closed
Priority: high | Milestone: 2.9
Component: Registration | Version: 1.6
Severity: normal | Resolution: fixed
Keywords: has-patch |
--------------------------+---------------------
Comment (by r-a-y):
In [changeset:"11639"]:
{{{
#!CommitTicketReference repository="" revision="11639"
Activation: After r11630, fix issues with multisite unit test.
The unit test written for #7553 can cause a database error when
`wpmu_create_blog()` fires when running the multisite test suite.
To workaround this, we remove the `'domain'` and `'path'` from the signup
user to prevent `wpmu_create_blog()` from firing.
Props netweb.
See #7553.
}}}
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From buddypress-trac at lists.automattic.com Wed Jul 12 23:15:51 2017
From: buddypress-trac at lists.automattic.com (buddypress-trac at lists.automattic.com)
Date: Wed, 12 Jul 2017 23:15:51 +0000 (UTC)
Subject: [buddypress-trac] [BuddyPress][11639]
trunk/tests/phpunit/testcases/members/ class-bp-signup.php: Activation:
After r11630, fix issues with multisite unit test.
Message-ID: <20170712231551.966641080287@svn1.lax.wordpress.org>
An HTML attachment was scrubbed...
URL:
From noreply at wordpress.org Thu Jul 13 01:04:59 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Thu, 13 Jul 2017 01:04:59 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7564: A forgotten %s in
french translation is making the Activity JavaScript to fail with
favorites.
In-Reply-To: <039.c275d95edd0c4032eec3b0a5eef30e32@wordpress.org>
References: <039.c275d95edd0c4032eec3b0a5eef30e32@wordpress.org>
Message-ID: <054.a4b87e05899cdbc0a176c71c36b5c140@wordpress.org>
#7564: A forgotten %s in french translation is making the Activity JavaScript to
fail with favorites.
-------------------------------------+------------------------------
Reporter: imath | Owner: slaFFik
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting Review
Component: I18N | Version: 2.8.2
Severity: normal | Resolution:
Keywords: i18n-change 2nd-opinion |
-------------------------------------+------------------------------
Comment (by imath):
hi r-a-y,
Yes the glotpress suggestion should be validated. But i also think we
could use a context or a `/* Transalors: */` comment to inform why it's
important to include the placeholder in the translation.
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Thu Jul 13 04:31:25 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Thu, 13 Jul 2017 04:31:25 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7563: Welcome Screen for
BP 2.9.0
In-Reply-To: <041.eb12b99e3148f64a105dc5f1b4699949@wordpress.org>
References: <041.eb12b99e3148f64a105dc5f1b4699949@wordpress.org>
Message-ID: <056.0e820edf2cad1b3059cc955f9ecf5713@wordpress.org>
#7563: Welcome Screen for BP 2.9.0
---------------------------------------+------------------
Reporter: mercime | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 2.9
Component: Core | Version:
Severity: normal | Resolution:
Keywords: has-patch has-screenshots |
---------------------------------------+------------------
Changes (by mercime):
* keywords: => has-patch has-screenshots
Comment:
[attachment:7563.patch] - first pass for welcome screen
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From buddypress-trac at lists.automattic.com Thu Jul 13 04:41:23 2017
From: buddypress-trac at lists.automattic.com (buddypress-trac at lists.automattic.com)
Date: Thu, 13 Jul 2017 04:41:23 +0000 (UTC)
Subject: [buddypress-trac] [BuddyPress][11640]
trunk/src/bp-core/classes/class-bp-admin.php: Hugo: 2.9 Release Lead
Message-ID: <20170713044124.012911080448@svn1.lax.wordpress.org>
An HTML attachment was scrubbed...
URL:
From buddypress-trac at lists.automattic.com Thu Jul 13 10:27:15 2017
From: buddypress-trac at lists.automattic.com (buddypress-trac at lists.automattic.com)
Date: Thu, 13 Jul 2017 10:27:15 +0000 (UTC)
Subject: [buddypress-trac] [BuddyPress][11641]
trunk/src/bp-core/classes/class-bp-admin.php: Revised & updated
contributors credits list.
Message-ID: <20170713102715.76A0010801A0@svn1.lax.wordpress.org>
An HTML attachment was scrubbed...
URL:
From noreply at wordpress.org Thu Jul 13 14:27:02 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Thu, 13 Jul 2017 14:27:02 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7563: Welcome Screen for
BP 2.9.0
In-Reply-To: <041.eb12b99e3148f64a105dc5f1b4699949@wordpress.org>
References: <041.eb12b99e3148f64a105dc5f1b4699949@wordpress.org>
Message-ID: <056.47c2aefbbc3b2e7eb4a05969e0a14c43@wordpress.org>
#7563: Welcome Screen for BP 2.9.0
---------------------------------------+------------------
Reporter: mercime | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 2.9
Component: Core | Version:
Severity: normal | Resolution:
Keywords: has-patch has-screenshots |
---------------------------------------+------------------
Comment (by hnla):
I was going to suggest running a block of four primary features, given we
lack huge big features this release i.e a11y, tooltip, edit slug,7397 omit
sending invites to users already received invites.
But you have things underway so do what you think best.
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Thu Jul 13 15:39:21 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Thu, 13 Jul 2017 15:39:21 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7096: Messages: member
page messages are queried for the loggedin user
In-Reply-To: <043.d651d725166384f9bb96dbbb95638cdd@wordpress.org>
References: <043.d651d725166384f9bb96dbbb95638cdd@wordpress.org>
Message-ID: <058.47a7c777cf2b0a19622fdca30a15f17e@wordpress.org>
#7096: Messages: member page messages are queried for the loggedin user
--------------------------+----------------------
Reporter: Offereins | Owner: dcavins
Type: defect (bug) | Status: closed
Priority: normal | Milestone: 2.9
Component: Messages | Version:
Severity: normal | Resolution: fixed
Keywords: has-patch |
--------------------------+----------------------
Comment (by boonebgorges):
[11578] broke message notifications. The link generated in
`messages_format_notifications()` should always be relative to the logged-
in user. Now it's relative to the displayed user, and when there's no
displayed user, it simply ends up returning a malformed link, such as
`href="messages/view/55"` in the case of a single message.
Simply adding a `$user_id` parameter (which would fall back on
`bp_displayed_user_id()`) would allow for an easy fix in BP. That being
said, the change in [11578] could potentially affect third-party
implementations that are using `bp_get_message_thread_view_link()` in non-
standard ways. So, the conservative strategy would be to (a) add the
`$user_id` param, but have it default to `bp_loggedin_user_id()`; then, we
pass the displayed user ID in the context of the loop.
I'll attach a patch for review by people who've thought about this more :)
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Thu Jul 13 16:08:24 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Thu, 13 Jul 2017 16:08:24 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7569: Bulk message actions
(Mark as Read) do not affect corresponding notifications
Message-ID: <046.17b0e82d9f10e795ddc1a3dac98c1672@wordpress.org>
#7569: Bulk message actions (Mark as Read) do not affect corresponding
notifications
--------------------------+-----------------
Reporter: boonebgorges | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 3.0
Component: Messages | Version:
Severity: normal | Keywords:
--------------------------+-----------------
If you have one or more new messages, manually marking those messages as
read - whether via bulk actions or "Read" links in bp-legacy or some other
mechanism - should cause the corresponding "new_message" notifications to
be marked as read. Currently, this is not the case: the only way a
new_message notification is marked as read is if you visit the thread
directly.
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Thu Jul 13 16:13:12 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Thu, 13 Jul 2017 16:13:12 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7569: Bulk message actions
(Mark as Read) do not affect corresponding notifications
In-Reply-To: <046.17b0e82d9f10e795ddc1a3dac98c1672@wordpress.org>
References: <046.17b0e82d9f10e795ddc1a3dac98c1672@wordpress.org>
Message-ID: <061.e55cb3ac761dd8f6158cdceb3b2af458@wordpress.org>
#7569: Bulk message actions (Mark as Read) do not affect corresponding
notifications
-----------------------------------+------------------
Reporter: boonebgorges | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 3.0
Component: Messages | Version:
Severity: normal | Resolution:
Keywords: has-patch 2nd-opinion |
-----------------------------------+------------------
Changes (by boonebgorges):
* keywords: => has-patch 2nd-opinion
Comment:
[attachment:7569.diff] fixes this by hooking directly to the
`messages_thread_mark_as_read` action.
I think, though I haven't tested, that this is a better and more general
way of handling message notifications than the technique used in
`bp_messages_screen_conversation_mark_notifications()`, and so perhaps
could replace it. But for this, I'd like a second opinion from
@johnjamesjacoby (who originally wrote this [7621]) or @r-a-y (who touched
it last [8202]).
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Thu Jul 13 16:41:21 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Thu, 13 Jul 2017 16:41:21 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7096: Messages: member
page messages are queried for the loggedin user
In-Reply-To: <043.d651d725166384f9bb96dbbb95638cdd@wordpress.org>
References: <043.d651d725166384f9bb96dbbb95638cdd@wordpress.org>
Message-ID: <058.82a5e0fc01591a7467bdd3b041982446@wordpress.org>
#7096: Messages: member page messages are queried for the loggedin user
--------------------------+----------------------
Reporter: Offereins | Owner: dcavins
Type: defect (bug) | Status: closed
Priority: normal | Milestone: 2.9
Component: Messages | Version:
Severity: normal | Resolution: fixed
Keywords: has-patch |
--------------------------+----------------------
Comment (by dcavins):
Yes, I agree that Boone's fix is the simplest answer and is good for
backward compatibility.
As I understand it:
The change to `bp-messages/bp-messages-template.php` restores the desired
behavior to the links generated in the notifications list.
That change breaks the new behavior of the links in a message list (using
the displayed user as the link base) when an admin is viewing another
member's messages screen, though, and is fixed by specifying the user ID
in `bp-templates/bp-legacy/buddypress/members/single/messages/messages-
loop.php`.
@boonebgorges Thanks for fixing the problem I introduced!
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Thu Jul 13 16:42:55 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Thu, 13 Jul 2017 16:42:55 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7569: Bulk message actions
(Mark as Read) do not affect corresponding notifications
In-Reply-To: <046.17b0e82d9f10e795ddc1a3dac98c1672@wordpress.org>
References: <046.17b0e82d9f10e795ddc1a3dac98c1672@wordpress.org>
Message-ID: <061.5e76ebc88c52cd8f9f3ad10180229ea5@wordpress.org>
#7569: Bulk message actions (Mark as Read) do not affect corresponding
notifications
-----------------------------------+------------------
Reporter: boonebgorges | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 3.0
Component: Messages | Version:
Severity: normal | Resolution:
Keywords: has-patch 2nd-opinion |
-----------------------------------+------------------
Comment (by johnjamesjacoby):
I agree this patch seems more inline with what we would expect to happen,
at the time it would naturally happen at.
I imagine it was originally deferred to the inbox view of the recipient to
avoid a bunch of pre-processing should that user never actually log in,
but it's also kinda silly to keep those notifications around forever too.
+1
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From buddypress-trac at lists.automattic.com Thu Jul 13 17:07:10 2017
From: buddypress-trac at lists.automattic.com (buddypress-trac at lists.automattic.com)
Date: Thu, 13 Jul 2017 17:07:10 +0000 (UTC)
Subject: [buddypress-trac] [BuddyPress][11642] trunk: Bump version strings
to RC1 from Beta1 for 2.9.0.
Message-ID: <20170713170710.3561F10801A0@svn1.lax.wordpress.org>
An HTML attachment was scrubbed...
URL:
From noreply at wordpress.org Thu Jul 13 17:58:58 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Thu, 13 Jul 2017 17:58:58 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7569: Bulk message actions
(Mark as Read) do not affect corresponding notifications
In-Reply-To: <046.17b0e82d9f10e795ddc1a3dac98c1672@wordpress.org>
References: <046.17b0e82d9f10e795ddc1a3dac98c1672@wordpress.org>
Message-ID: <061.b714a419834e1e19df1a73678d598418@wordpress.org>
#7569: Bulk message actions (Mark as Read) do not affect corresponding
notifications
-----------------------------------+------------------
Reporter: boonebgorges | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 3.0
Component: Messages | Version:
Severity: normal | Resolution:
Keywords: has-patch 2nd-opinion |
-----------------------------------+------------------
Comment (by r-a-y):
Good catch. I guess no one ever really uses the bulk "mark as read"
option much! Commit at will.
----
> I think, though I haven't tested, that this is a better and more general
way of handling message notifications than the technique used in
`bp_messages_screen_conversation_mark_notifications()`
Not necessarily.
- `bp_messages_screen_conversation_mark_notifications()` grabs the logged-
in user's unread messages and cross-references it with the messages in the
current message thread before marking the message as read. The con here
is grabbing the logged-in user's unread messages, which could be a big
lookup. The positive is this will only run
`bp_notifications_mark_notifications_by_item_id()` as necessary, which is
important as this runs when one visits a private message thread all the
time.
- The patch takes the approach of grabbing all the messages in the current
message thread. Then, it loops through that and attempts to mark each
message as read for the logged-in user. This is somewhat okay because
this runs on the `'messages_thread_mark_as_read'` hook. Howver, this
means that `bp_notifications_mark_notifications_by_item_id()` will run a
DB query for the number of messages in the thread. For large message
threads, this will not be so great.
I guess what would be better is to introduce a bulk read / unread method
so we can just mark a bunch of messages in bulk with one DB query.
Currently, we have to do a loop through a message thread and then mark
each mesasge one at a time.
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Thu Jul 13 18:31:17 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Thu, 13 Jul 2017 18:31:17 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7563: Welcome Screen for
BP 2.9.0
In-Reply-To: <041.eb12b99e3148f64a105dc5f1b4699949@wordpress.org>
References: <041.eb12b99e3148f64a105dc5f1b4699949@wordpress.org>
Message-ID: <056.b4a732bd55b46b2543d904c168b12baa@wordpress.org>
#7563: Welcome Screen for BP 2.9.0
---------------------------------------+------------------
Reporter: mercime | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 2.9
Component: Core | Version:
Severity: normal | Resolution:
Keywords: has-patch has-screenshots |
---------------------------------------+------------------
Comment (by mercime):
@hnla Comments/feedback/suggestions most welcome from everyone as usual.
Just to be clear, no main feature just the four you mentioned: a11y =
profile fieldsets, tooltip, edit slug, and 7397.
At this time, I only have images for the profile fieldset, tooltip, and
edit slug. None for 7397 that I can think of. So will be coming up with a
patch using dashicons.
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Thu Jul 13 18:34:42 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Thu, 13 Jul 2017 18:34:42 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7563: Welcome Screen for
BP 2.9.0
In-Reply-To: <041.eb12b99e3148f64a105dc5f1b4699949@wordpress.org>
References: <041.eb12b99e3148f64a105dc5f1b4699949@wordpress.org>
Message-ID: <056.d819248d8a541913908a54c528a82ada@wordpress.org>
#7563: Welcome Screen for BP 2.9.0
---------------------------------------+------------------
Reporter: mercime | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 2.9
Component: Core | Version:
Severity: normal | Resolution:
Keywords: has-patch has-screenshots |
---------------------------------------+------------------
Comment (by hnla):
Well my thought was we don't really have a single big splash feature to
set on it's own so better to do a group and ? list some smaller ones
below, but you've done good with previous screens so trust in your
judgement on it.
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Thu Jul 13 18:45:21 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Thu, 13 Jul 2017 18:45:21 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7096: Messages: member
page messages are queried for the loggedin user
In-Reply-To: <043.d651d725166384f9bb96dbbb95638cdd@wordpress.org>
References: <043.d651d725166384f9bb96dbbb95638cdd@wordpress.org>
Message-ID: <058.36d3ae7ecaef7a6be5d2100a637bc0c3@wordpress.org>
#7096: Messages: member page messages are queried for the loggedin user
--------------------------+----------------------
Reporter: Offereins | Owner: dcavins
Type: defect (bug) | Status: closed
Priority: normal | Milestone: 2.9
Component: Messages | Version:
Severity: normal | Resolution: fixed
Keywords: has-patch |
--------------------------+----------------------
Comment (by boonebgorges):
[attachment:7096.2.diff] gives the suggested treatment to the functions
that output a link that might conceivably be used in a different context:
`bp_message_thread_view_link()`, `bp_message_thread_delete_link()`,
`bp_the_message_thread_mark_unread_url()`,
`bp_the_message_thread_mark_read_url()`.
URLs that are used for redirects in screen/action functions can be
hardcoded to reference the displayed user, I think. The same goes for the
`form_action`.
I wasn't sure whether to touch notice-related URLs. I think notices can
appear in any context, even when there's no displayed user. Is there a
situation where notice-related links should *not* be generated relative to
the logged-in user? IMO these parts of [11578] should probably be rolled
back.
@dcavins Can you please give a sanity check to the above?
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Thu Jul 13 19:05:48 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Thu, 13 Jul 2017 19:05:48 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7096: Messages: member
page messages are queried for the loggedin user
In-Reply-To: <043.d651d725166384f9bb96dbbb95638cdd@wordpress.org>
References: <043.d651d725166384f9bb96dbbb95638cdd@wordpress.org>
Message-ID: <058.ef8d7e3dafb29fb2a5464a28c503a76a@wordpress.org>
#7096: Messages: member page messages are queried for the loggedin user
--------------------------+----------------------
Reporter: Offereins | Owner: dcavins
Type: defect (bug) | Status: closed
Priority: normal | Milestone: 2.9
Component: Messages | Version:
Severity: normal | Resolution: fixed
Keywords: has-patch |
--------------------------+----------------------
Comment (by dcavins):
@boonebgorges 7096.2 looks like it will prevent some (many?) issues caused
by my earlier change. Thanks for finding them during the beta! I also
prefer changing the function signature by adding a user ID. I think that
will make these functions more useful in more contexts.
Thanks!
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Thu Jul 13 19:11:00 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Thu, 13 Jul 2017 19:11:00 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7096: Messages: member
page messages are queried for the loggedin user
In-Reply-To: <043.d651d725166384f9bb96dbbb95638cdd@wordpress.org>
References: <043.d651d725166384f9bb96dbbb95638cdd@wordpress.org>
Message-ID: <058.b59bb350b180282e397ae9a975b31e88@wordpress.org>
#7096: Messages: member page messages are queried for the loggedin user
--------------------------+----------------------
Reporter: Offereins | Owner: dcavins
Type: defect (bug) | Status: closed
Priority: normal | Milestone: 2.9
Component: Messages | Version:
Severity: normal | Resolution: fixed
Keywords: has-patch |
--------------------------+----------------------
Comment (by boonebgorges):
In [changeset:"11644"]:
{{{
#!CommitTicketReference repository="" revision="11644"
Restore default behavior of message link generating functions.
Prior to [11578], functions for generating links in the context of
messages (Mark Read, Delete, etc) were generated relative to the
logged-in user. This made it impossible for an administrator to
manage another user's messages. [11578] changed the default behavior
of these functions to reference the displayed user. But this change
breaks backward compatibility for functions expecting the prior
behavior, including BP's own message notification format functions.
We work around the limitation by introducing `$user_id` parameters
to the functions in question. `$user_id` defaults to the logged-in
user (for backward compatibilty), and the bp-legacy template passes
in the displayed user ID as appropriate.
Fixes #7096.
}}}
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From buddypress-trac at lists.automattic.com Thu Jul 13 19:11:00 2017
From: buddypress-trac at lists.automattic.com (buddypress-trac at lists.automattic.com)
Date: Thu, 13 Jul 2017 19:11:00 +0000 (UTC)
Subject: [buddypress-trac] [BuddyPress][11644] trunk/src: Restore default
behavior of message link generating functions.
Message-ID: <20170713191100.3DEBF10801A0@svn1.lax.wordpress.org>
An HTML attachment was scrubbed...
URL:
From buddypress-trac at lists.automattic.com Thu Jul 13 19:10:44 2017
From: buddypress-trac at lists.automattic.com (buddypress-trac at lists.automattic.com)
Date: Thu, 13 Jul 2017 19:10:44 +0000 (UTC)
Subject: [buddypress-trac] [BuddyPress][11643]
trunk/src/bp-messages/bp-messages-template.php: Ensure that links for
managing sitewide notices are specific to logged-in user.
Message-ID: <20170713191044.83ED810801A0@svn1.lax.wordpress.org>
An HTML attachment was scrubbed...
URL:
From noreply at wordpress.org Thu Jul 13 19:10:45 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Thu, 13 Jul 2017 19:10:45 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7096: Messages: member
page messages are queried for the loggedin user
In-Reply-To: <043.d651d725166384f9bb96dbbb95638cdd@wordpress.org>
References: <043.d651d725166384f9bb96dbbb95638cdd@wordpress.org>
Message-ID: <058.cb32e0d2dfd7a1a11c01e5da6dc00d18@wordpress.org>
#7096: Messages: member page messages are queried for the loggedin user
--------------------------+----------------------
Reporter: Offereins | Owner: dcavins
Type: defect (bug) | Status: closed
Priority: normal | Milestone: 2.9
Component: Messages | Version:
Severity: normal | Resolution: fixed
Keywords: has-patch |
--------------------------+----------------------
Comment (by boonebgorges):
In [changeset:"11643"]:
{{{
#!CommitTicketReference repository="" revision="11643"
Ensure that links for managing sitewide notices are specific to logged-in
user.
These links were incorrectly converted to the displayed user as
part of the work in [11578]. Notices are always relative to the
logged-in user, and can be displayed anywhere on a site - regardless
of the displayed user (or lack thereof).
See #7096.
}}}
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Thu Jul 13 20:25:47 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Thu, 13 Jul 2017 20:25:47 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7563: Welcome Screen for
BP 2.9.0
In-Reply-To: <041.eb12b99e3148f64a105dc5f1b4699949@wordpress.org>
References: <041.eb12b99e3148f64a105dc5f1b4699949@wordpress.org>
Message-ID: <056.92fc09270ce00f60ebff62c9a1acf431@wordpress.org>
#7563: Welcome Screen for BP 2.9.0
---------------------------------------+------------------
Reporter: mercime | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 2.9
Component: Core | Version:
Severity: normal | Resolution:
Keywords: has-patch has-screenshots |
---------------------------------------+------------------
Comment (by mercime):
Feedback please on new patch with screenshot attached. Thanks :D
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From buddypress-trac at lists.automattic.com Thu Jul 13 21:06:34 2017
From: buddypress-trac at lists.automattic.com (buddypress-trac at lists.automattic.com)
Date: Thu, 13 Jul 2017 21:06:34 +0000 (UTC)
Subject: [buddypress-trac] [BuddyPress][11645]
trunk/src/bp-xprofile/classes: Add ARIA attr to associate single field with
description.
Message-ID: <20170713210634.56A8610801A0@svn1.lax.wordpress.org>
An HTML attachment was scrubbed...
URL:
From noreply at wordpress.org Thu Jul 13 21:06:34 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Thu, 13 Jul 2017 21:06:34 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7348: Accessibility: Group
related form elements within fieldsets in Profile > Edit screen
In-Reply-To: <041.6c4a28282fe7606272665690f4f1f893@wordpress.org>
References: <041.6c4a28282fe7606272665690f4f1f893@wordpress.org>
Message-ID: <056.c3ecb84cf911331695438058fc435665@wordpress.org>
#7348: Accessibility: Group related form elements within fieldsets in Profile >
Edit screen
------------------------------+----------------------
Reporter: mercime | Owner: mercime
Type: enhancement | Status: closed
Priority: normal | Milestone: 2.9
Component: Extended Profile | Version:
Severity: normal | Resolution: fixed
Keywords: has-patch early |
------------------------------+----------------------
Comment (by mercime):
In [changeset:"11645"]:
{{{
#!CommitTicketReference repository="" revision="11645"
Add ARIA attr to associate single field with description.
Fixes #7348.
}}}
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Fri Jul 14 01:51:51 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Fri, 14 Jul 2017 01:51:51 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7535: Add npm
`package-lock.json` for npm v5.x
In-Reply-To: <040.2afddde53001cdc1af41a45eda7f0812@wordpress.org>
References: <040.2afddde53001cdc1af41a45eda7f0812@wordpress.org>
Message-ID: <055.6f7c3a906503c6262bf3136a7cfb9a6b@wordpress.org>
#7535: Add npm `package-lock.json` for npm v5.x
------------------------------+-----------------------------
Reporter: netweb | Owner: netweb
Type: task | Status: accepted
Priority: normal | Milestone: Future Release
Component: Build/Test Tools | Version:
Severity: normal | Resolution:
Keywords: |
------------------------------+-----------------------------
Comment (by netweb):
I've nearly grok'd all there is know about npm 5...
To that end some recent knowledge ingestion a `package-lock.json` and
`npm-shrinkwrap.json` are interchangeable, in essence one could be renamed
to other and it will work as intended.
Another is that npm has no ''LTS'' releases, everyone should be running
the latest version of npm, at the time of writing that is npm `5.2.0` see
also http://blog.npmjs.org/post/162451604515/the-npm-clis-long-term-
support-lts-policy
The plan I have now to move forward with this is to rename `npm-
shrinkwrap.json` to `package-lock.json`, then using npm `5.2.0` to update
the file `package-lock.json` with the updated file format added as part of
npm `5.1.0` release.
This will also help to avoid scenarios where unexpected changes to `npm-
shrinkwrap.json` occurs such as
[https://buddypress.trac.wordpress.org/changeset/11642/trunk/npm-
shrinkwrap.json this].
I'm pretty keen on this change as it both benefits contributors and the
repo, for contributors things become a little simpler in that `npm
install` is for the most part the only command you'll ever need to run
ever again, for the repo, this changes ensures a consistent set of build
tool versions across all platforms that install faster than ever before.
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Fri Jul 14 02:19:13 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Fri, 14 Jul 2017 02:19:13 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7563: Welcome Screen for
BP 2.9.0
In-Reply-To: <041.eb12b99e3148f64a105dc5f1b4699949@wordpress.org>
References: <041.eb12b99e3148f64a105dc5f1b4699949@wordpress.org>
Message-ID: <056.4d85d72059588db73df9dd3d77bb3502@wordpress.org>
#7563: Welcome Screen for BP 2.9.0
---------------------------------------+------------------
Reporter: mercime | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 2.9
Component: Core | Version:
Severity: normal | Resolution:
Keywords: has-patch has-screenshots |
---------------------------------------+------------------
Comment (by netweb):
Replying to [comment:8 mercime]:
> Feedback please on new patch with screenshot attached. Thanks :D
I love it :)
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Fri Jul 14 03:30:57 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Fri, 14 Jul 2017 03:30:57 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7563: Welcome Screen for
BP 2.9.0
In-Reply-To: <041.eb12b99e3148f64a105dc5f1b4699949@wordpress.org>
References: <041.eb12b99e3148f64a105dc5f1b4699949@wordpress.org>
Message-ID: <056.dcdd8483940c2b5fa77c5bd3db5605c3@wordpress.org>
#7563: Welcome Screen for BP 2.9.0
---------------------------------------+------------------
Reporter: mercime | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 2.9
Component: Core | Version:
Severity: normal | Resolution:
Keywords: has-patch has-screenshots |
---------------------------------------+------------------
Comment (by mercime):
Thanks for your feedback @netweb :D
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Fri Jul 14 09:24:24 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Fri, 14 Jul 2017 09:24:24 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7563: Welcome Screen for
BP 2.9.0
In-Reply-To: <041.eb12b99e3148f64a105dc5f1b4699949@wordpress.org>
References: <041.eb12b99e3148f64a105dc5f1b4699949@wordpress.org>
Message-ID: <056.114fec30b45b9a81c5e1cd5e965aee34@wordpress.org>
#7563: Welcome Screen for BP 2.9.0
---------------------------------------+------------------
Reporter: mercime | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 2.9
Component: Core | Version:
Severity: normal | Resolution:
Keywords: has-patch has-screenshots |
---------------------------------------+------------------
Comment (by hnla):
Last iteration looks great.
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Fri Jul 14 10:00:58 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Fri, 14 Jul 2017 10:00:58 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7563: Welcome Screen for
BP 2.9.0
In-Reply-To: <041.eb12b99e3148f64a105dc5f1b4699949@wordpress.org>
References: <041.eb12b99e3148f64a105dc5f1b4699949@wordpress.org>
Message-ID: <056.8cf0bbf181ae854a406e53d623df4083@wordpress.org>
#7563: Welcome Screen for BP 2.9.0
----------------------------------------------+------------------
Reporter: mercime | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 2.9
Component: Core | Version:
Severity: normal | Resolution:
Keywords: has-patch has-screenshots commit |
----------------------------------------------+------------------
Changes (by hnla):
* keywords: has-patch has-screenshots => has-patch has-screenshots commit
Comment:
@mercime Going ahead and committing this, if we need to make changes so be
it, hopefully it will be minor so shouldn't cause translators too much
work.
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Fri Jul 14 10:13:15 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Fri, 14 Jul 2017 10:13:15 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7563: Welcome Screen for
BP 2.9.0
In-Reply-To: <041.eb12b99e3148f64a105dc5f1b4699949@wordpress.org>
References: <041.eb12b99e3148f64a105dc5f1b4699949@wordpress.org>
Message-ID: <056.d3008d756c1845e1e364c10c5c880376@wordpress.org>
#7563: Welcome Screen for BP 2.9.0
----------------------------------------------+------------------
Reporter: mercime | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 2.9
Component: Core | Version:
Severity: normal | Resolution:
Keywords: has-patch has-screenshots commit |
----------------------------------------------+------------------
Comment (by hnla):
And forgot to reference the ticket: #11646
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From buddypress-trac at lists.automattic.com Fri Jul 14 11:59:17 2017
From: buddypress-trac at lists.automattic.com (buddypress-trac at lists.automattic.com)
Date: Fri, 14 Jul 2017 11:59:17 +0000 (UTC)
Subject: [buddypress-trac] [BuddyPress][11647] tags/2.9.0-RC1/: Create tag
2.9.0-RC1
Message-ID: <20170714115917.E59F11080335@svn1.lax.wordpress.org>
An HTML attachment was scrubbed...
URL:
From noreply at wordpress.org Fri Jul 14 21:00:55 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Fri, 14 Jul 2017 21:00:55 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7570: fatal error
Message-ID: <043.e6b11c4292499708ade004b673307745@wordpress.org>
#7570: fatal error
--------------------------+-----------------------------
Reporter: jaeyholic | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Groups | Version:
Severity: normal | Keywords:
--------------------------+-----------------------------
This is a follow-up to #4311.
someone wants to sign up, after typing the info and press the sign up
button, this error appears
Fatal error: Call to undefined function bp_get_settings_slug() in
/home/yeboah2/public_html/winderrands/wp-content/plugins/buddypress/bp-
core/bp-core-filters.php on line 1072
instead of redirecting the new user to the activation page, it doesn?t,
that error shows up but on the users page, i see the new user created but
the user can?t activate his/her account.
someone kindly help me fix this problem please.
thanks in advance
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Fri Jul 14 21:57:39 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Fri, 14 Jul 2017 21:57:39 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7570: fatal error
In-Reply-To: <043.e6b11c4292499708ade004b673307745@wordpress.org>
References: <043.e6b11c4292499708ade004b673307745@wordpress.org>
Message-ID: <058.cdb868838738553d20bc20e6cd0c8806@wordpress.org>
#7570: fatal error
--------------------------+------------------------------
Reporter: jaeyholic | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Groups | Version:
Severity: normal | Resolution:
Keywords: |
--------------------------+------------------------------
Comment (by espellcaste):
I could not reproduce the error mentioned. :/ :(
Could you share the BuddyPress version and your set up?
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Sat Jul 15 14:33:44 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Sat, 15 Jul 2017 14:33:44 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7563: Welcome Screen for
BP 2.9.0
In-Reply-To: <041.eb12b99e3148f64a105dc5f1b4699949@wordpress.org>
References: <041.eb12b99e3148f64a105dc5f1b4699949@wordpress.org>
Message-ID: <056.767d8a8459c7ecb354871935c7530a38@wordpress.org>
#7563: Welcome Screen for BP 2.9.0
----------------------------------------------+------------------
Reporter: mercime | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 2.9
Component: Core | Version:
Severity: normal | Resolution:
Keywords: has-patch has-screenshots commit |
----------------------------------------------+------------------
Comment (by hnla):
There are a couple of translation concerns as mentioned on slack:
https://wordpress.slack.com/archives/C02RQBYUG/p1500114992978161
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Sun Jul 16 14:08:29 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Sun, 16 Jul 2017 14:08:29 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7563: Welcome Screen for
BP 2.9.0
In-Reply-To: <041.eb12b99e3148f64a105dc5f1b4699949@wordpress.org>
References: <041.eb12b99e3148f64a105dc5f1b4699949@wordpress.org>
Message-ID: <056.26344ea4420c1810c1fe67cd4eae3526@wordpress.org>
#7563: Welcome Screen for BP 2.9.0
----------------------------------------------+------------------
Reporter: mercime | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 2.9
Component: Core | Version:
Severity: normal | Resolution:
Keywords: has-patch has-screenshots commit |
----------------------------------------------+------------------
Comment (by netweb):
In [attachment:7563-5.patch] I've formatted the string the same as
WordPress Core does for a similar string that contains code.
Here's the WordPress string for #en-au
https://translate.wordpress.org/projects/wp/dev/admin/en-
au/default?filters%5Bstatus%5D=either&filters%5Boriginal_id%5D=4572975&filters%5Btranslation_id%5D=49922078
And the string source: https://core.trac.wordpress.org/browser/trunk/src
/wp-admin/about.php#L196
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Sun Jul 16 16:58:50 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Sun, 16 Jul 2017 16:58:50 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7563: Welcome Screen for
BP 2.9.0
In-Reply-To: <041.eb12b99e3148f64a105dc5f1b4699949@wordpress.org>
References: <041.eb12b99e3148f64a105dc5f1b4699949@wordpress.org>
Message-ID: <056.6bea07742e72e16a7826a97eb2d0b589@wordpress.org>
#7563: Welcome Screen for BP 2.9.0
----------------------------------------------+------------------
Reporter: mercime | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 2.9
Component: Core | Version:
Severity: normal | Resolution:
Keywords: has-patch has-screenshots commit |
----------------------------------------------+------------------
Comment (by hnla):
@netweb thanks.
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Thu Jul 20 13:24:57 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Thu, 20 Jul 2017 13:24:57 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7571: "load more" button
doesn't load activities as expected ( when the user deletes one or more of
the currently shown activities )
Message-ID: <042.81c17aa4a2276324e59f2a960eab492d@wordpress.org>
#7571: "load more" button doesn't load activities as expected ( when the user
deletes one or more of the currently shown activities )
--------------------------+-----------------------------
Reporter: 7asobate | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Core | Version:
Severity: normal | Keywords:
--------------------------+-----------------------------
say for example that a group has 40 elements..
20 elements are being shown and 20 are hidden..
if the user deletes the 20 elements that are being shown then clicks "load
more" no activities shows to him.
that's because the "load more" button tries to call "acpage 2" which
doesn't exist because there's only 20 elements left ( there's no page 2
but there's 20 elements left which exist in page 1 )
I hope the developers pay more attention to problems like this
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Thu Jul 20 16:14:34 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Thu, 20 Jul 2017 16:14:34 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7571: "load more" button
doesn't load activities as expected ( when the user deletes one or more of
the currently shown activities )
In-Reply-To: <042.81c17aa4a2276324e59f2a960eab492d@wordpress.org>
References: <042.81c17aa4a2276324e59f2a960eab492d@wordpress.org>
Message-ID: <057.9ef4990538ffa1b591c671413168bb60@wordpress.org>
#7571: "load more" button doesn't load activities as expected ( when the user
deletes one or more of the currently shown activities )
--------------------------+------------------------------
Reporter: 7asobate | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Templates | Version: 1.2
Severity: minor | Resolution:
Keywords: needs-patch |
--------------------------+------------------------------
Changes (by r-a-y):
* keywords: => needs-patch
* version: => 1.2
* component: Core => Templates
* severity: normal => minor
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Thu Jul 20 16:19:31 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Thu, 20 Jul 2017 16:19:31 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7556: confirmation message
problem (on activity delete)
In-Reply-To: <042.eb04813e640f275c165f3a546ed407b9@wordpress.org>
References: <042.eb04813e640f275c165f3a546ed407b9@wordpress.org>
Message-ID: <057.dce51f2235e53803926aad1d890e2526@wordpress.org>
#7556: confirmation message problem (on activity delete)
--------------------------+------------------
Reporter: 7asobate | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 3.0
Component: Core | Version: 1.2
Severity: normal | Resolution:
Keywords: has-patch |
--------------------------+------------------
Changes (by r-a-y):
* version: => 1.2
* component: (not sure) => Core
* milestone: Awaiting Review => 3.0
Comment:
@7asobate - Thanks for your ticket, but it was too late to add this to the
2.9 development cycle.
We'll be sure to fix this for 3.0.
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Thu Jul 20 16:24:21 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Thu, 20 Jul 2017 16:24:21 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7570: fatal error
In-Reply-To: <043.e6b11c4292499708ade004b673307745@wordpress.org>
References: <043.e6b11c4292499708ade004b673307745@wordpress.org>
Message-ID: <058.bb87f1906a670cafd94007405c1ba14e@wordpress.org>
#7570: fatal error
-------------------------------+------------------------------
Reporter: jaeyholic | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Groups | Version:
Severity: normal | Resolution:
Keywords: reporter-feedback |
-------------------------------+------------------------------
Changes (by r-a-y):
* keywords: => reporter-feedback
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Sat Jul 22 16:06:48 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Sat, 22 Jul 2017 16:06:48 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7563: Welcome Screen for
BP 2.9.0
In-Reply-To: <041.eb12b99e3148f64a105dc5f1b4699949@wordpress.org>
References: <041.eb12b99e3148f64a105dc5f1b4699949@wordpress.org>
Message-ID: <056.c98445ade407002d52d369504cb60e2b@wordpress.org>
#7563: Welcome Screen for BP 2.9.0
----------------------------------------------+------------------
Reporter: mercime | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 2.9
Component: Core | Version:
Severity: normal | Resolution:
Keywords: has-patch has-screenshots commit |
----------------------------------------------+------------------
Comment (by hnla):
We need to revisit this the second change is echoing html elements as
strings.
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From buddypress-trac at lists.automattic.com Tue Jul 25 08:45:42 2017
From: buddypress-trac at lists.automattic.com (buddypress-trac at lists.automattic.com)
Date: Tue, 25 Jul 2017 08:45:42 +0000 (UTC)
Subject: [buddypress-trac] [BuddyPress][11648]
trunk/src/bp-core/classes/class-bp-admin.php: Credits screen: improve
translation accessibility of certain strings.
Message-ID: <20170725084542.D0C23108041D@svn1.lax.wordpress.org>
An HTML attachment was scrubbed...
URL:
From noreply at wordpress.org Tue Jul 25 08:45:43 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Tue, 25 Jul 2017 08:45:43 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7563: Welcome Screen for
BP 2.9.0
In-Reply-To: <041.eb12b99e3148f64a105dc5f1b4699949@wordpress.org>
References: <041.eb12b99e3148f64a105dc5f1b4699949@wordpress.org>
Message-ID: <056.f2aefbf4ce090455605609500e89e16c@wordpress.org>
#7563: Welcome Screen for BP 2.9.0
----------------------------------------------+---------------------
Reporter: mercime | Owner: djpaul
Type: defect (bug) | Status: closed
Priority: normal | Milestone: 2.9
Component: Core | Version:
Severity: normal | Resolution: fixed
Keywords: has-patch has-screenshots commit |
----------------------------------------------+---------------------
Changes (by djpaul):
* owner: => djpaul
* status: new => closed
* resolution: => fixed
Comment:
In [changeset:"11648"]:
{{{
#!CommitTicketReference repository="" revision="11648"
Credits screen: improve translation accessibility of certain strings.
Fixes #7563
Props mercime, hnla, netweb, slaffik, offereins.
}}}
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Tue Jul 25 14:45:28 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Tue, 25 Jul 2017 14:45:28 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7572: Buddypress Activity
Filter not displaying the results for multiple filters
Message-ID: <046.35d8c4b375c2c472f440ff78f9014f59@wordpress.org>
#7572: Buddypress Activity Filter not displaying the results for multiple filters
--------------------------+-----------------------------
Reporter: seventhqueen | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Core | Version: 2.8.2
Severity: normal | Keywords: has-screenshots
--------------------------+-----------------------------
Hi,
There it's a bug with the activity show filter.
It can be reproduced when you select from show filter (see screenshot)
'Group Updates', 'New Groups' or 'Comments' using twenty sixteen WordPress
theme no results will be displayed and the next info appears ''"Sorry,
there was no activity found. Please try a different filter."''
Screenshot 1 - Group Updates
[[Image(http://seventhqueen.com/public-files/radu/Site-Wide_Activity_-
_Kleo_Development_2017-07-25_17-32-20.png)]]
Screenshot 2 - New Groups
[[Image(http://seventhqueen.com/public-files/radu/Site-Wide_Activity_-
_Kleo_Development_2017-07-25_17-34-31.png)]]
Screenshot 3 - New Groups
[[Image(http://seventhqueen.com/public-files/radu/Site-Wide_Activity_-
_Kleo_Development_2017-07-25_17-40-31.png)]]
The issue was reported by more KLEO Theme users, also the bug can be seen
on our live demo.
Cheers
Radu
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Tue Jul 25 15:38:12 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Tue, 25 Jul 2017 15:38:12 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7572: Buddypress Activity
Filter not displaying the results for multiple filters
In-Reply-To: <046.35d8c4b375c2c472f440ff78f9014f59@wordpress.org>
References: <046.35d8c4b375c2c472f440ff78f9014f59@wordpress.org>
Message-ID: <061.0ae787bb67d5081b23999e13d21ed75e@wordpress.org>
#7572: Buddypress Activity Filter not displaying the results for multiple filters
-----------------------------------------------+---------------------------
Reporter: seventhqueen | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting
Component: Core | Review
Severity: normal | Version:
Keywords: has-screenshots reporter-feedback | Resolution:
-----------------------------------------------+---------------------------
Changes (by r-a-y):
* keywords: has-screenshots => has-screenshots reporter-feedback
* version: 2.8.2 =>
Comment:
I cannot duplicate your problem.
It looks like you have the "My Groups" tab selected and then you are
attempting to use the select dropdown filter. Perhaps that is where your
problem lies?
Click on "All Members" and attempt your dropdown filter?
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Tue Jul 25 19:01:17 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Tue, 25 Jul 2017 19:01:17 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7573: BP_Group_Member_Query
should support multiple group IDs
Message-ID: <039.d8f23f55df2f973e6637fe28ede50ee9@wordpress.org>
#7573: BP_Group_Member_Query should support multiple group IDs
-------------------------+-----------------------------
Reporter: r-a-y | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Groups | Version: 1.8
Severity: normal | Keywords: has-patch
-------------------------+-----------------------------
Sometimes it is useful to query for members from multiple groups.
Currently, we cannot do this with `BP_Group_Member_Query` since it only
supports one group ID.
Attached patch allows for passing multiple group IDs.
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Tue Jul 25 22:07:44 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Tue, 25 Jul 2017 22:07:44 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7573:
BP_Group_Member_Query should support multiple group IDs
In-Reply-To: <039.d8f23f55df2f973e6637fe28ede50ee9@wordpress.org>
References: <039.d8f23f55df2f973e6637fe28ede50ee9@wordpress.org>
Message-ID: <054.afbeda2040413bb0fc2e17bbe5fc4c0c@wordpress.org>
#7573: BP_Group_Member_Query should support multiple group IDs
-------------------------+------------------------------
Reporter: r-a-y | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Groups | Version: 1.8
Severity: normal | Resolution:
Keywords: has-patch |
-------------------------+------------------------------
Comment (by dcavins):
Hi @r-a-y-
I think this is a great idea. In your attached patch, what would trigger
the else condition:
{{{
else {
$group_ids_sql = $wpdb->prepare( "group_id = %d",
$this->query_vars['group_id'] );
}
}}}
Maybe if an empty array or empty string was passed into the function? I
guess I'm wondering, is there a value that you could pass that would be
stripped down to an empty array by `wp_parse_id_list()`, but would be
useful to do an equals check on?
Thanks for setting me straight. :)
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Wed Jul 26 00:52:15 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Wed, 26 Jul 2017 00:52:15 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7573:
BP_Group_Member_Query should support multiple group IDs
In-Reply-To: <039.d8f23f55df2f973e6637fe28ede50ee9@wordpress.org>
References: <039.d8f23f55df2f973e6637fe28ede50ee9@wordpress.org>
Message-ID: <054.d60dd098a08f2adba22cec3a8a0b5350@wordpress.org>
#7573: BP_Group_Member_Query should support multiple group IDs
-------------------------+------------------------------
Reporter: r-a-y | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Groups | Version: 1.8
Severity: normal | Resolution:
Keywords: has-patch |
-------------------------+------------------------------
Comment (by r-a-y):
@dcavins - You're right. The `else` condition is not necessary.
I guess I was just being extra cautious, but `wp_parse_id_list()` should
handle most empty instances and default to `0`, so we should be safe to
remove the `else` condition.
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Wed Jul 26 01:03:08 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Wed, 26 Jul 2017 01:03:08 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7573:
BP_Group_Member_Query should support multiple group IDs
In-Reply-To: <039.d8f23f55df2f973e6637fe28ede50ee9@wordpress.org>
References: <039.d8f23f55df2f973e6637fe28ede50ee9@wordpress.org>
Message-ID: <054.41c7fe1c631e401290dcb1cdf3ffcdf3@wordpress.org>
#7573: BP_Group_Member_Query should support multiple group IDs
-------------------------+------------------------------
Reporter: r-a-y | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Groups | Version: 1.8
Severity: normal | Resolution:
Keywords: has-patch |
-------------------------+------------------------------
Comment (by dcavins):
Replying to [comment:2 r-a-y]:
> @dcavins - You're right. The `else` condition is not necessary.
>
> I guess I was just being extra cautious, but `wp_parse_id_list()` should
handle most empty instances and default to `array( 0 )`, so we should be
safe to remove the `else` condition.
Not so fast! :)
I think we need an else condition, because `wp_parse_id_list( array() )`
does return an empty array. But maybe the else condition should be
explicitly not made to work, like `group_id = 0` or something. I was just
wondering, could there be a passed arg that would be useful? I can't think
of one.
Thanks again for this good idea!
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Wed Jul 26 01:14:56 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Wed, 26 Jul 2017 01:14:56 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7573:
BP_Group_Member_Query should support multiple group IDs
In-Reply-To: <039.d8f23f55df2f973e6637fe28ede50ee9@wordpress.org>
References: <039.d8f23f55df2f973e6637fe28ede50ee9@wordpress.org>
Message-ID: <054.5127008d697191e761e3bf74d96b5f2c@wordpress.org>
#7573: BP_Group_Member_Query should support multiple group IDs
-------------------------+------------------------------
Reporter: r-a-y | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Groups | Version: 1.8
Severity: normal | Resolution:
Keywords: has-patch |
-------------------------+------------------------------
Comment (by r-a-y):
Well, if you're passing an empty array, then you're SOL :)
I suppose we could do something like this:
{{{
$group_ids = wp_parse_id_list( $this->query_vars['group_id'] );
$group_ids = ! empty( $group_ids ) ? $group_ids : array( 0 );
}}}
Feels a little unnecessary, but meh!
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Wed Jul 26 02:44:38 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Wed, 26 Jul 2017 02:44:38 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7574: Update Travis CI build
matrix for PHP 7.2
Message-ID: <040.f9b8b31c34aeb832e3ba741ddc706878@wordpress.org>
#7574: Update Travis CI build matrix for PHP 7.2
------------------------------+--------------------
Reporter: netweb | Owner: netweb
Type: enhancement | Status: new
Priority: normal | Milestone: 2.9
Component: Build/Test Tools | Version:
Severity: normal | Keywords:
------------------------------+--------------------
Via https://core.trac.wordpress.org/ticket/40109#comment:15
> FYI: PHP 7.2 alpha has been tagged and is now [https://github.com
/travis-ci/travis-ci/issues/7989 available on Travis] as `7.2`.
* PHP 7.2 compatibility is only being added to WordPress 4.9 at this stage
(there is no current plans to backport for WordPress 4.8 or earlier) so
this job should only test against WP `master`
* As PHP 7.2 has not yet been released and there are current PHP 7.1 test
failures adding this 7.2 job should be ''allowed to fail''
* PHP ''nightly'' on Travis CI has now become PHP `7.3.0-dev` and no
change is required to include PHP 7.3 in allowed failures, see https
://travis-ci.org/buddypress/BuddyPress/jobs/257217162#L447
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From buddypress-trac at lists.automattic.com Wed Jul 26 02:50:33 2017
From: buddypress-trac at lists.automattic.com (buddypress-trac at lists.automattic.com)
Date: Wed, 26 Jul 2017 02:50:33 +0000 (UTC)
Subject: [buddypress-trac] [BuddyPress][11649] trunk/.travis.yml: Build
Tools: Run Travis CI tests on PHP 7.2,
and WordPress 4.9 (`master`) allowing to fail.
Message-ID: <20170726025033.47F5D1080629@svn1.lax.wordpress.org>
An HTML attachment was scrubbed...
URL:
From noreply at wordpress.org Wed Jul 26 02:50:33 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Wed, 26 Jul 2017 02:50:33 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7392: PHP 7.1 compat
In-Reply-To: <040.0fc119ce6f6ae20aab94d4bdf0048a97@wordpress.org>
References: <040.0fc119ce6f6ae20aab94d4bdf0048a97@wordpress.org>
Message-ID: <055.ac4e5dbd9a4022b08d5e7f1d6df65484@wordpress.org>
#7392: PHP 7.1 compat
--------------------------+---------------------------
Reporter: DJPaul | Owner: boonebgorges
Type: defect (bug) | Status: closed
Priority: highest | Milestone: 2.8.3
Component: Core | Version:
Severity: normal | Resolution: fixed
Keywords: |
--------------------------+---------------------------
Comment (by netweb):
In [changeset:"11649"]:
{{{
#!CommitTicketReference repository="" revision="11649"
Build Tools: Run Travis CI tests on PHP 7.2, and WordPress 4.9 (`master`)
allowing to fail.
Fixes #7574. See #7392.
}}}
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Wed Jul 26 02:50:33 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Wed, 26 Jul 2017 02:50:33 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7574: Update Travis CI
build matrix for PHP 7.2
In-Reply-To: <040.f9b8b31c34aeb832e3ba741ddc706878@wordpress.org>
References: <040.f9b8b31c34aeb832e3ba741ddc706878@wordpress.org>
Message-ID: <055.53a2cc9d212006b6887f4be8b639948d@wordpress.org>
#7574: Update Travis CI build matrix for PHP 7.2
------------------------------+---------------------
Reporter: netweb | Owner: netweb
Type: enhancement | Status: closed
Priority: normal | Milestone: 2.9
Component: Build/Test Tools | Version:
Severity: normal | Resolution: fixed
Keywords: |
------------------------------+---------------------
Changes (by netweb):
* status: new => closed
* resolution: => fixed
Comment:
In [changeset:"11649"]:
{{{
#!CommitTicketReference repository="" revision="11649"
Build Tools: Run Travis CI tests on PHP 7.2, and WordPress 4.9 (`master`)
allowing to fail.
Fixes #7574. See #7392.
}}}
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From buddypress-trac at lists.automattic.com Wed Jul 26 19:03:49 2017
From: buddypress-trac at lists.automattic.com (buddypress-trac at lists.automattic.com)
Date: Wed, 26 Jul 2017 19:03:49 +0000 (UTC)
Subject: [buddypress-trac] [BuddyPress][11651]
trunk/src/bp-templates/bp-legacy/ buddypress-functions.php: bp-legacy:
After r11356, fix issues with filtering multiple activity actions.
Message-ID: <20170726190349.D496D1080406@svn1.lax.wordpress.org>
An HTML attachment was scrubbed...
URL:
From noreply at wordpress.org Wed Jul 26 19:03:50 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Wed, 26 Jul 2017 19:03:50 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7562: Activity's friends
component filter fails since 4.8
In-Reply-To: <039.3446f90b1960bb398ba80bb481166156@wordpress.org>
References: <039.3446f90b1960bb398ba80bb481166156@wordpress.org>
Message-ID: <054.5c4ce1c3243d064c39b57118914fc621@wordpress.org>
#7562: Activity's friends component filter fails since 4.8
------------------------------------+---------------------
Reporter: imath | Owner: r-a-y
Type: defect (bug) | Status: closed
Priority: normal | Milestone: 2.8.3
Component: Templates | Version: 2.8.0
Severity: normal | Resolution: fixed
Keywords: has-patch dev-feedback |
------------------------------------+---------------------
Comment (by r-a-y):
In [changeset:"11651"]:
{{{
#!CommitTicketReference repository="" revision="11651"
bp-legacy: After r11356, fix issues with filtering multiple activity
actions.
In #4062, we started to validate activity actions against a given context.
However, we did not take into account the validation of multiple activity
actions during AJAX activity filtering. This broke the "Friendships"
dropdown filter since it uses a comma-separated action value of
`friendship_accepted,friendship_created`.
This commit remedies this by accepting multiple activity actions and
cross-referencing it against the registered activity actions for the AJAX
activity querystring.
Props imath.
Fixes #7562 (trunk).
}}}
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From buddypress-trac at lists.automattic.com Wed Jul 26 19:03:03 2017
From: buddypress-trac at lists.automattic.com (buddypress-trac at lists.automattic.com)
Date: Wed, 26 Jul 2017 19:03:03 +0000 (UTC)
Subject: [buddypress-trac] [BuddyPress][11650]
branches/2.8/src/bp-templates/bp-legacy/ buddypress-functions.php:
bp-legacy: After r11356,
fix issues with filtering multiple activity actions.
Message-ID: <20170726190303.6FE191080406@svn1.lax.wordpress.org>
An HTML attachment was scrubbed...
URL:
From noreply at wordpress.org Wed Jul 26 19:03:03 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Wed, 26 Jul 2017 19:03:03 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7562: Activity's friends
component filter fails since 4.8
In-Reply-To: <039.3446f90b1960bb398ba80bb481166156@wordpress.org>
References: <039.3446f90b1960bb398ba80bb481166156@wordpress.org>
Message-ID: <054.281ef64412f2ebff0a9016c7c6027baf@wordpress.org>
#7562: Activity's friends component filter fails since 4.8
------------------------------------+---------------------
Reporter: imath | Owner: r-a-y
Type: defect (bug) | Status: closed
Priority: normal | Milestone: 2.8.3
Component: Templates | Version: 2.8.0
Severity: normal | Resolution: fixed
Keywords: has-patch dev-feedback |
------------------------------------+---------------------
Changes (by r-a-y):
* owner: => r-a-y
* status: new => closed
* resolution: => fixed
Comment:
In [changeset:"11650"]:
{{{
#!CommitTicketReference repository="" revision="11650"
bp-legacy: After r11356, fix issues with filtering multiple activity
actions.
In #4062, we started to validate activity actions against a given context.
However, we did not take into account the validation of multiple activity
actions during AJAX activity filtering. This broke the "Friendships"
dropdown filter since it uses a comma-separated action value of
`friendship_accepted,friendship_created`.
This commit remedies this by accepting multiple activity actions and
cross-referencing it against the registered activity actions for the AJAX
activity querystring.
Props imath.
Fixes #7562 (2.8-branch).
}}}
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Wed Jul 26 19:05:04 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Wed, 26 Jul 2017 19:05:04 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7562: Activity's friends
component filter fails since 4.8
In-Reply-To: <039.3446f90b1960bb398ba80bb481166156@wordpress.org>
References: <039.3446f90b1960bb398ba80bb481166156@wordpress.org>
Message-ID: <054.c087d16359f4bbea449888ce75337d8d@wordpress.org>
#7562: Activity's friends component filter fails since 4.8
------------------------------------+---------------------
Reporter: imath | Owner: r-a-y
Type: defect (bug) | Status: closed
Priority: normal | Milestone: 2.8.3
Component: Templates | Version: 2.8.0
Severity: normal | Resolution: fixed
Keywords: has-patch dev-feedback |
------------------------------------+---------------------
Comment (by r-a-y):
Thanks for finding this bug, @imath!
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Wed Jul 26 21:22:51 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Wed, 26 Jul 2017 21:22:51 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7562: Activity's friends
component filter fails since 4.8
In-Reply-To: <039.3446f90b1960bb398ba80bb481166156@wordpress.org>
References: <039.3446f90b1960bb398ba80bb481166156@wordpress.org>
Message-ID: <054.4698a08c4b5ee1112c8b5d2cc0dcf4e0@wordpress.org>
#7562: Activity's friends component filter fails since 4.8
------------------------------------+---------------------
Reporter: imath | Owner: r-a-y
Type: defect (bug) | Status: closed
Priority: normal | Milestone: 2.8.3
Component: Templates | Version: 2.8.0
Severity: normal | Resolution: fixed
Keywords: has-patch dev-feedback |
------------------------------------+---------------------
Comment (by imath):
Replying to [comment:4 r-a-y]:
> Thanks for finding this bug, @imath!
You're very welcome @r-a-y :)
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Thu Jul 27 09:48:59 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Thu, 27 Jul 2017 09:48:59 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7337: PHP Fatal error:
Uncaught Error: Call to a member function get_do_autolink() on null
In-Reply-To: <041.ebfef37ff5e67865d896952a55c9ea01@wordpress.org>
References: <041.ebfef37ff5e67865d896952a55c9ea01@wordpress.org>
Message-ID: <056.132f66bb9c20e25e2138da903665ea1c@wordpress.org>
#7337: PHP Fatal error: Uncaught Error: Call to a member function
get_do_autolink() on null
-------------------------------------------------+-------------------------
Reporter: slaFFik | Owner:
Type: defect (bug) | Status: closed
Priority: normal | Milestone:
Component: Extended Profile | Version:
Severity: normal | Resolution: wontfix
Keywords: dev-feedback 2nd-opinion early |
needs-patch |
-------------------------------------------------+-------------------------
Changes (by DJPaul):
* status: new => closed
* resolution: => wontfix
* milestone: Awaiting Review =>
Comment:
Let's not do this.
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Thu Jul 27 09:50:50 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Thu, 27 Jul 2017 09:50:50 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7466: Activity Content
Filter Priority and Slashes
In-Reply-To: <042.4fcda405dcf0482dbf7846a21698f5b0@wordpress.org>
References: <042.4fcda405dcf0482dbf7846a21698f5b0@wordpress.org>
Message-ID: <057.a36bc281d5805ac8291ead67dc377497@wordpress.org>
#7466: Activity Content Filter Priority and Slashes
--------------------------+----------------------
Reporter: wilcosky | Owner:
Type: defect (bug) | Status: closed
Priority: normal | Milestone:
Component: Core | Version: 2.8.0
Severity: normal | Resolution: invalid
Keywords: |
--------------------------+----------------------
Changes (by DJPaul):
* status: new => closed
* resolution: => invalid
* milestone: Awaiting Review =>
Comment:
We'll need more information how to recreate before we can consider.
Thanks.
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Thu Jul 27 09:53:13 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Thu, 27 Jul 2017 09:53:13 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7478: Performance
improvement for bp_is_user_spammer in member loops
In-Reply-To: <042.dfe84cdb1fbb4b07f5ef9b313e630dbc@wordpress.org>
References: <042.dfe84cdb1fbb4b07f5ef9b313e630dbc@wordpress.org>
Message-ID: <057.99a2a3d0b5587272a2bdf3b46566232c@wordpress.org>
#7478: Performance improvement for bp_is_user_spammer in member loops
------------------------------+------------------
Reporter: sbrajesh | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: 3.0
Component: Members | Version:
Severity: normal | Resolution:
Keywords: has-patch commit |
------------------------------+------------------
Changes (by DJPaul):
* keywords: has-patch => has-patch commit
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Thu Jul 27 09:48:19 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Thu, 27 Jul 2017 09:48:19 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7550: Introduce new action
hooks for single group and member template
In-Reply-To: <043.2db361a6253c09facf20663726aee936@wordpress.org>
References: <043.2db361a6253c09facf20663726aee936@wordpress.org>
Message-ID: <058.e2d343329373a53424e31a13d4b99c3b@wordpress.org>
#7550: Introduce new action hooks for single group and member template
-------------------------+----------------------
Reporter: lenasterg | Owner:
Type: enhancement | Status: closed
Priority: low | Milestone:
Component: Templates | Version:
Severity: trivial | Resolution: wontfix
Keywords: |
-------------------------+----------------------
Changes (by DJPaul):
* status: new => closed
* resolution: => wontfix
* milestone: Awaiting Review =>
Comment:
We're not adding new to bp-legacy,. sorry.
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Thu Jul 27 09:53:05 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Thu, 27 Jul 2017 09:53:05 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7478: Performance
improvement for bp_is_user_spammer in member loops
In-Reply-To: <042.dfe84cdb1fbb4b07f5ef9b313e630dbc@wordpress.org>
References: <042.dfe84cdb1fbb4b07f5ef9b313e630dbc@wordpress.org>
Message-ID: <057.26612ab73e2deeaffca7b4a2ddd8f8ac@wordpress.org>
#7478: Performance improvement for bp_is_user_spammer in member loops
-------------------------+------------------
Reporter: sbrajesh | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: 3.0
Component: Members | Version:
Severity: normal | Resolution:
Keywords: has-patch |
-------------------------+------------------
Changes (by DJPaul):
* milestone: Awaiting Review => 3.0
Comment:
I like it!
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Thu Jul 27 09:50:21 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Thu, 27 Jul 2017 09:50:21 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7463: PHPUnit 6
compatibility
In-Reply-To: <040.5ef51ffacb2a144b0999c4b05f35ce35@wordpress.org>
References: <040.5ef51ffacb2a144b0999c4b05f35ce35@wordpress.org>
Message-ID: <055.92207d77a74e5cbc1e7ccd9e9dbdff71@wordpress.org>
#7463: PHPUnit 6 compatibility
------------------------------+------------------
Reporter: netweb | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 3.0
Component: Build/Test Tools | Version:
Severity: normal | Resolution:
Keywords: |
------------------------------+------------------
Changes (by DJPaul):
* keywords: reporter-feedback =>
* milestone: Awaiting Review => 3.0
Comment:
@netweb can you just get this done in trunk, please?
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Thu Jul 27 09:56:10 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Thu, 27 Jul 2017 09:56:10 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7550: Introduce new action
hooks for single group and member template
In-Reply-To: <043.2db361a6253c09facf20663726aee936@wordpress.org>
References: <043.2db361a6253c09facf20663726aee936@wordpress.org>
Message-ID: <058.b664ee5d3ff9f665a6753a54138477f3@wordpress.org>
#7550: Introduce new action hooks for single group and member template
-------------------------+----------------------
Reporter: lenasterg | Owner:
Type: enhancement | Status: closed
Priority: low | Milestone:
Component: Templates | Version:
Severity: trivial | Resolution: wontfix
Keywords: |
-------------------------+----------------------
Comment (by lenasterg):
Why? Is bp-legacy going to be deprecated?
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Thu Jul 27 09:57:40 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Thu, 27 Jul 2017 09:57:40 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7475: Component directory
sub pages / slugs
In-Reply-To: <045.e77525248679ecf7f985be5ed49df6b3@wordpress.org>
References: <045.e77525248679ecf7f985be5ed49df6b3@wordpress.org>
Message-ID: <060.3b6fc49682b6efb43242e80a9d31a511@wordpress.org>
#7475: Component directory sub pages / slugs
--------------------------+-------------------------
Reporter: modemlooper | Owner:
Type: enhancement | Status: closed
Priority: low | Milestone:
Component: Route Parser | Version: 2.8.2
Severity: minor | Resolution: maybelater
Keywords: 2nd-opinion |
--------------------------+-------------------------
Changes (by DJPaul):
* status: new => closed
* resolution: => maybelater
* component: Core => Route Parser
* milestone: Awaiting Review =>
Comment:
This would be nice but low priority/interest and I think effort spent into
working on an update URL routing system would be better.
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Thu Jul 27 09:58:47 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Thu, 27 Jul 2017 09:58:47 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7489: Filter hook for
groups_is_user_member()
In-Reply-To: <046.79cd163374da306dfec8e595f6a5b3ea@wordpress.org>
References: <046.79cd163374da306dfec8e595f6a5b3ea@wordpress.org>
Message-ID: <061.5941708c19dbee9b84e617eb3f8f3796@wordpress.org>
#7489: Filter hook for groups_is_user_member()
--------------------------+----------------------
Reporter: mikeboltonca | Owner:
Type: enhancement | Status: closed
Priority: normal | Milestone:
Component: Groups | Version:
Severity: trivial | Resolution: invalid
Keywords: |
--------------------------+----------------------
Changes (by DJPaul):
* status: new => closed
* resolution: => invalid
* milestone: Awaiting Review =>
Comment:
Closing per above.
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Thu Jul 27 10:01:13 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Thu, 27 Jul 2017 10:01:13 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7491: BuddyPress vs
WordPress registration
In-Reply-To: <040.1d2355df606db6fa8c4cad8fc6825baf@wordpress.org>
References: <040.1d2355df606db6fa8c4cad8fc6825baf@wordpress.org>
Message-ID: <055.f7cbe7b8a67ac5ecea0bd69a2766b9b2@wordpress.org>
#7491: BuddyPress vs WordPress registration
-----------------------------+----------------------
Reporter: bymiki | Owner:
Type: feature request | Status: closed
Priority: normal | Milestone:
Component: Core | Version: 2.8.2
Severity: normal | Resolution: invalid
Keywords: |
-----------------------------+----------------------
Changes (by DJPaul):
* status: new => closed
* resolution: => invalid
* milestone: Awaiting Review =>
Comment:
> which add an extra and innecesary obstacle to the registration process.
This is totally down to how the site's been configured. We insist on one
extra field, but I don't think that's a set-in-stone decision, nor,
frankly, an obstacle.
Not to mention, WordPress does a terrible job at user registration. It
exists and barely adequate for multisite. It would be nice to improve this
in a more holistic way but I don't think we have the people power to make
this change.
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Thu Jul 27 09:58:17 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Thu, 27 Jul 2017 09:58:17 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7487: Friends: Drop the
number of friends used for priming at-mention suggestions
In-Reply-To: <039.6a5f54382a41332be66cf1e5d6135604@wordpress.org>
References: <039.6a5f54382a41332be66cf1e5d6135604@wordpress.org>
Message-ID: <054.5edbf70ebcb8fa960a6758ec0167f647@wordpress.org>
#7487: Friends: Drop the number of friends used for priming at-mention suggestions
--------------------------+------------------
Reporter: r-a-y | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 3.0
Component: Friends | Version: 2.2
Severity: normal | Resolution:
Keywords: |
--------------------------+------------------
Changes (by DJPaul):
* milestone: Awaiting Review => 3.0
Comment:
Yes, let's.
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Thu Jul 27 10:06:37 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Thu, 27 Jul 2017 10:06:37 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7498: Activation with
BP_SIGNUPS_SKIP_USER_CREATION = true and same email
In-Reply-To: <040.ef318f6c7b63c150576641031b282655@wordpress.org>
References: <040.ef318f6c7b63c150576641031b282655@wordpress.org>
Message-ID: <055.1433edd38ee86472b96a179a07010b35@wordpress.org>
#7498: Activation with BP_SIGNUPS_SKIP_USER_CREATION = true and same email
--------------------------+-----------------------------
Reporter: Maniou | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: Future Release
Component: Registration | Version:
Severity: normal | Resolution:
Keywords: |
--------------------------+-----------------------------
Changes (by DJPaul):
* component: Members => Registration
* milestone: Awaiting Review => Future Release
Comment:
I haven't validated this in BP, but MS prevents this with the following
message, we should, too:
> That email address has already been used. Please check your inbox for an
activation email. It will become available in a couple of days if you do
nothing.
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Thu Jul 27 10:07:16 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Thu, 27 Jul 2017 10:07:16 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7502: Legacy forums do not
work with WordPress 4.7
In-Reply-To: <039.6e5838317196e664489875e8c2291a87@wordpress.org>
References: <039.6e5838317196e664489875e8c2291a87@wordpress.org>
Message-ID: <054.bf6e64825f89951a1b9950118194c3f4@wordpress.org>
#7502: Legacy forums do not work with WordPress 4.7
--------------------------+------------------------------
Reporter: r-a-y | Owner: johnjamesjacoby
Type: defect (bug) | Status: new
Priority: normal | Milestone: 3.0
Component: Forums | Version: 2.7.1
Severity: normal | Resolution:
Keywords: has-patch |
--------------------------+------------------------------
Changes (by DJPaul):
* milestone: Awaiting Review => 3.0
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Thu Jul 27 10:08:23 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Thu, 27 Jul 2017 10:08:23 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7503: Add identifying tag
parameter to bp_has_*() loop arguments.
In-Reply-To: <041.160f9c6951c88c0fab373e5fb44a1051@wordpress.org>
References: <041.160f9c6951c88c0fab373e5fb44a1051@wordpress.org>
Message-ID: <056.9cc49295f789a879479714d847dd3f4d@wordpress.org>
#7503: Add identifying tag parameter to bp_has_*() loop arguments.
--------------------------+-----------------------------
Reporter: dcavins | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: Future Release
Component: Templates | Version:
Severity: normal | Resolution:
Keywords: |
--------------------------+-----------------------------
Changes (by DJPaul):
* component: Core => Templates
* milestone: Awaiting Review => Future Release
Comment:
This is very low priority and I doubt anyone will get it done soon (this
ticket is already 3 months old), but sure.
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Thu Jul 27 10:11:12 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Thu, 27 Jul 2017 10:11:12 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7504: rename
groups_created_group to bp_groups_created_group
In-Reply-To: <044.74d364d4964a7dcca1f905b1d15cfc23@wordpress.org>
References: <044.74d364d4964a7dcca1f905b1d15cfc23@wordpress.org>
Message-ID: <059.93d8209328ca1e9229d024ad1623f44a@wordpress.org>
#7504: rename groups_created_group to bp_groups_created_group
--------------------------+----------------------
Reporter: joneiseman | Owner:
Type: defect (bug) | Status: closed
Priority: normal | Milestone:
Component: Groups | Version:
Severity: normal | Resolution: invalid
Keywords: |
--------------------------+----------------------
Changes (by DJPaul):
* status: new => closed
* resolution: => invalid
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Thu Jul 27 10:11:06 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Thu, 27 Jul 2017 10:11:06 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7504: rename
groups_created_group to bp_groups_created_group
In-Reply-To: <044.74d364d4964a7dcca1f905b1d15cfc23@wordpress.org>
References: <044.74d364d4964a7dcca1f905b1d15cfc23@wordpress.org>
Message-ID: <059.e63a01bf8ce6bc2438013d6e2a4bec4f@wordpress.org>
#7504: rename groups_created_group to bp_groups_created_group
--------------------------+------------------
Reporter: joneiseman | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone:
Component: Groups | Version:
Severity: normal | Resolution:
Keywords: |
--------------------------+------------------
Changes (by DJPaul):
* milestone: Awaiting Review =>
Comment:
The old naming convention dates back about 9 years (pre-v0.7, I think)
where each bit of BP was a separate plugin, and the original developer
didn't think to namespace them. I don't think we'll change the name of the
action now, if we've only had (at least one) report over 9 years.
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Thu Jul 27 10:22:54 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Thu, 27 Jul 2017 10:22:54 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7522: Use wp_login_url()
instead of site_url() where needed
In-Reply-To: <041.80a4910e3ca9d5ceaba370d5e7b149d8@wordpress.org>
References: <041.80a4910e3ca9d5ceaba370d5e7b149d8@wordpress.org>
Message-ID: <056.579e354e30cfbfc5fbe679df48c0fd43@wordpress.org>
#7522: Use wp_login_url() instead of site_url() where needed
-------------------------+------------------
Reporter: slaFFik | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: 3.0
Component: Core | Version:
Severity: normal | Resolution:
Keywords: |
-------------------------+------------------
Changes (by DJPaul):
* milestone: Awaiting Review => 3.0
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Thu Jul 27 10:21:46 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Thu, 27 Jul 2017 10:21:46 -0000
Subject: [buddypress-trac]
=?utf-8?q?=5BBuddyPress_Trac=5D_=237505=3A_Prob?=
=?utf-8?q?lems_with_special_characters_for_Member_Names_=28e=2Eg=2E_?=
=?utf-8?b?w6kgw6Agw6cgZXRjKQ==?=
In-Reply-To: <041.0eb994578ec39f05e37572ca3dfaf100@wordpress.org>
References: <041.0eb994578ec39f05e37572ca3dfaf100@wordpress.org>
Message-ID: <056.7b5493ac5a55b3a28b00460f4d885156@wordpress.org>
#7505: Problems with special characters for Member Names (e.g. ? ? ? etc)
---------------------------------------------+----------------------
Reporter: XrossGG | Owner:
Type: defect (bug) | Status: closed
Priority: normal | Milestone:
Component: Core | Version: 2.8.2
Severity: normal | Resolution: invalid
Keywords: needs-testing reporter-feedback |
---------------------------------------------+----------------------
Changes (by DJPaul):
* status: new => closed
* resolution: => invalid
* milestone: Awaiting Review =>
Comment:
Check your database table's encoding and character sets. If this site is
older than a few years, the BuddyPress database tables won't be utf8 (I
think they started out as latin1, due to a bug we had years and years ago)
and nowadays they should be utf8mb4.
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Thu Jul 27 10:27:57 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Thu, 27 Jul 2017 10:27:57 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7526: Counter for "All"
tab for activity and groups table
In-Reply-To: <051.902f707a10a1dd556633b3565361c898@wordpress.org>
References: <051.902f707a10a1dd556633b3565361c898@wordpress.org>
Message-ID: <066.8ce280b1d315366e58e5687410437305@wordpress.org>
#7526: Counter for "All" tab for activity and groups table
-----------------------------------------+-----------------------------
Reporter: bhargavbhandari90 | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: Future Release
Component: Activity | Version: 2.8.2
Severity: normal | Resolution:
Keywords: has-screenshots needs-patch |
-----------------------------------------+-----------------------------
Changes (by DJPaul):
* keywords: dev-feedback has-patch has-screenshots => has-screenshots
needs-patch
* milestone: Awaiting Review => Future Release
Comment:
I suspect it was because the number wasn't convenient in the database
queries we are making to build that page.
Your patch has the problem of the query not being cached, of hardcoding
the table name (I think we have this as a property on the main class for
each Component, e.g. `bp()->activity`), and because this is not using the
existing Activity API.
The last point is not a strict rule, but it's something we like. So, if
you can't find the same total number in the activities global object
somewhere, then you'd need to add caching around the query, and double-
check that we don't hard-code the query name elsewhere (I might be
remembering wrong).
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Thu Jul 27 10:29:25 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Thu, 27 Jul 2017 10:29:25 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7540: Adding a button and
function for a member to leave a multi-recipients conversation
In-Reply-To: <040.bab4a017790a19d4ad6d0f7bce3fca0d@wordpress.org>
References: <040.bab4a017790a19d4ad6d0f7bce3fca0d@wordpress.org>
Message-ID: <055.2b9fced7ec41546544b0050d318980d7@wordpress.org>
#7540: Adding a button and function for a member to leave a multi-recipients
conversation
-------------------------+-----------------------------
Reporter: Oelita | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: Future Release
Component: Messages | Version:
Severity: normal | Resolution:
Keywords: |
-------------------------+-----------------------------
Changes (by DJPaul):
* milestone: Awaiting Review => Future Release
Comment:
@boonebgorges was it you who did something around this a while ago? I
think I recall a Slack conversation, but I can't remember the details.
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Thu Jul 27 10:31:59 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Thu, 27 Jul 2017 10:31:59 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7545: Move composer.json
to project root
In-Reply-To: <040.178d8d816933bf11ddd6abe51a9201b8@wordpress.org>
References: <040.178d8d816933bf11ddd6abe51a9201b8@wordpress.org>
Message-ID: <055.9242702cb6339845dfbd404c79155324@wordpress.org>
#7545: Move composer.json to project root
------------------------------+---------------------
Reporter: DJPaul | Owner: netweb
Type: enhancement | Status: new
Priority: normal | Milestone: 3.0
Component: Build/Test Tools | Version:
Severity: normal | Resolution:
Keywords: |
------------------------------+---------------------
Changes (by DJPaul):
* milestone: Awaiting Review => 3.0
Comment:
great find Netweb!
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Thu Jul 27 10:38:52 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Thu, 27 Jul 2017 10:38:52 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7560: make Activity Index
shows only the activities of...
In-Reply-To: <045.27257a17907118b1eaf3ebd05989c81d@wordpress.org>
References: <045.27257a17907118b1eaf3ebd05989c81d@wordpress.org>
Message-ID: <060.c042ee517d11dd5059794ab280cfc534@wordpress.org>
#7560: make Activity Index shows only the activities of...
-------------------------------+----------------------------------
Reporter: Mohammad Sy | Owner:
Type: feature request | Status: new
Priority: normal | Milestone: Under Consideration
Component: Activity | Version:
Severity: normal | Resolution:
Keywords: reporter-feedback |
-------------------------------+----------------------------------
Changes (by DJPaul):
* keywords: => reporter-feedback
* milestone: Awaiting Review => Under Consideration
Comment:
What does it show that you think it shouldn't?
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Thu Jul 27 10:36:41 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Thu, 27 Jul 2017 10:36:41 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7228: Add PHPCS
In-Reply-To: <040.d6dc8d60474d8530ffeee9c71acb70d2@wordpress.org>
References: <040.d6dc8d60474d8530ffeee9c71acb70d2@wordpress.org>
Message-ID: <055.e87269c222686f21d61aa06c2f2bf16d@wordpress.org>
#7228: Add PHPCS
------------------------------+-------------------------
Reporter: DJPaul | Owner:
Type: enhancement | Status: closed
Priority: normal | Milestone:
Component: Build/Test Tools | Version:
Severity: normal | Resolution: maybelater
Keywords: |
------------------------------+-------------------------
Changes (by DJPaul):
* status: new => closed
* resolution: => maybelater
* milestone: Future Release =>
Comment:
At Human Made, we've had issues with wp-dev-lib and it being quite
brittle. Given that wp-dev-lib would be a key part of this - every file
would undoubtably through warnings if we weren't running this only on new
changes - i'm going to close this ticket for now and if we/Human Made come
up with something a bit more reliable and there's interest, we can re-
open.
Or switch to Github and have Travis-CI run PHPCS on pull requests. :p
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Thu Jul 27 10:41:45 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Thu, 27 Jul 2017 10:41:45 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7565: Multisite signups do
not have a WordPress role
In-Reply-To: <039.533f6d24a01420d7cd498592c07ab475@wordpress.org>
References: <039.533f6d24a01420d7cd498592c07ab475@wordpress.org>
Message-ID: <054.427ff2f4a603cf4da778f53dbdfad36e@wordpress.org>
#7565: Multisite signups do not have a WordPress role
------------------------------------------------+------------------
Reporter: r-a-y | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 3.0
Component: Members | Version:
Severity: normal | Resolution:
Keywords: has-patch dev-feedback 2nd-opinion |
------------------------------------------------+------------------
Changes (by DJPaul):
* milestone: Awaiting Review => 3.0
Comment:
Let's do this.
@r-a-y Your patch: why the `is_numeric` check? Is that not plastering over
some other bug in BP elsewhere?
Otherwise looks fine.
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Thu Jul 27 10:38:17 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Thu, 27 Jul 2017 10:38:17 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7557: integrate BuddyPress
Activity Privacy plugin with BuddyPress
In-Reply-To: <045.155d9a00927f098a9bd737c6bae33399@wordpress.org>
References: <045.155d9a00927f098a9bd737c6bae33399@wordpress.org>
Message-ID: <060.1a0bca9578e1385a8decd8c0e19ab376@wordpress.org>
#7557: integrate BuddyPress Activity Privacy plugin with BuddyPress
-----------------------------+-------------------------
Reporter: Mohammad Sy | Owner:
Type: feature request | Status: closed
Priority: normal | Milestone:
Component: Activity | Version:
Severity: normal | Resolution: maybelater
Keywords: |
-----------------------------+-------------------------
Changes (by DJPaul):
* status: new => closed
* resolution: => maybelater
* component: Core => Activity
* milestone: Awaiting Review =>
Comment:
Sorry, no -- this plugin hasn't been updated in two years. This sort of
feature is very complex and I suspect won't get worked on by any of our
regular contributors for the foreseeable future. We'd need more outside
help to take on a task of this scale.
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Thu Jul 27 10:43:18 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Thu, 27 Jul 2017 10:43:18 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7566: Activity: block 2nd
click on .activity-read-more
In-Reply-To: <041.40022f553bd204f6b5e2d6274366e5d8@wordpress.org>
References: <041.40022f553bd204f6b5e2d6274366e5d8@wordpress.org>
Message-ID: <056.37ea83d14519f2b023817e025799d5d3@wordpress.org>
#7566: Activity: block 2nd click on .activity-read-more
----------------------------------------+----------------------
Reporter: slaFFik | Owner:
Type: defect (bug) | Status: closed
Priority: normal | Milestone:
Component: Activity | Version:
Severity: normal | Resolution: wontfix
Keywords: needs-patch good-first-bug |
----------------------------------------+----------------------
Changes (by DJPaul):
* status: new => closed
* resolution: => wontfix
* milestone: Awaiting Review =>
Comment:
We aren't changing BP-Legacy, which I assume this is where the code
concerned is.
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Thu Jul 27 10:39:36 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Thu, 27 Jul 2017 10:39:36 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7564: A forgotten %s in
french translation is making the Activity JavaScript to fail with
favorites.
In-Reply-To: <039.c275d95edd0c4032eec3b0a5eef30e32@wordpress.org>
References: <039.c275d95edd0c4032eec3b0a5eef30e32@wordpress.org>
Message-ID: <054.4202d4d3846e2fa38d249fbda9cbc5f9@wordpress.org>
#7564: A forgotten %s in french translation is making the Activity JavaScript to
fail with favorites.
-------------------------------------+----------------------
Reporter: imath | Owner: slaFFik
Type: defect (bug) | Status: new
Priority: normal | Milestone: 3.0
Component: I18N | Version: 2.8.2
Severity: normal | Resolution:
Keywords: i18n-change 2nd-opinion |
-------------------------------------+----------------------
Changes (by DJPaul):
* milestone: Awaiting Review => 3.0
Comment:
Sure.
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Thu Jul 27 10:44:35 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Thu, 27 Jul 2017 10:44:35 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7571: "load more" button
doesn't load activities as expected ( when the user deletes one or more of
the currently shown activities )
In-Reply-To: <042.81c17aa4a2276324e59f2a960eab492d@wordpress.org>
References: <042.81c17aa4a2276324e59f2a960eab492d@wordpress.org>
Message-ID: <057.64a9f2ea9bb91221588e7cb863f047cd@wordpress.org>
#7571: "load more" button doesn't load activities as expected ( when the user
deletes one or more of the currently shown activities )
--------------------------+----------------------
Reporter: 7asobate | Owner:
Type: defect (bug) | Status: closed
Priority: normal | Milestone:
Component: Templates | Version: 1.2
Severity: minor | Resolution: wontfix
Keywords: needs-patch |
--------------------------+----------------------
Changes (by DJPaul):
* status: new => closed
* resolution: => wontfix
* milestone: Awaiting Review =>
Comment:
This is definitely an edge case, but it's in our legacy template. We
aren't accepting new issues for the legacy templates, and in our next
release, 3.0, we hope to ship new templates.
We'd accept this sort of bug report then (if it still exists).
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Thu Jul 27 10:50:04 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Thu, 27 Jul 2017 10:50:04 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7573:
BP_Group_Member_Query should support multiple group IDs
In-Reply-To: <039.d8f23f55df2f973e6637fe28ede50ee9@wordpress.org>
References: <039.d8f23f55df2f973e6637fe28ede50ee9@wordpress.org>
Message-ID: <054.02abce07b8d70a4e28f1f54610c64b2f@wordpress.org>
#7573: BP_Group_Member_Query should support multiple group IDs
------------------------------+------------------
Reporter: r-a-y | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: 3.0
Component: Groups | Version: 1.8
Severity: normal | Resolution:
Keywords: has-patch commit |
------------------------------+------------------
Changes (by DJPaul):
* keywords: has-patch => has-patch commit
* milestone: Awaiting Review => 3.0
Comment:
if someone passes a null-ish value to `group_id` and if we don't
explicitly support that already, we do not need to protect against
developer stupidity. This is our lowest-level query function for Groups
Members queries, and any handholding like this should happen up the chain.
tl;dr 02 patch looks good
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Thu Jul 27 10:50:39 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Thu, 27 Jul 2017 10:50:39 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7566: Activity: block 2nd
click on .activity-read-more
In-Reply-To: <041.40022f553bd204f6b5e2d6274366e5d8@wordpress.org>
References: <041.40022f553bd204f6b5e2d6274366e5d8@wordpress.org>
Message-ID: <056.c0cf927a2b75262ec3427dc4eca518ef@wordpress.org>
#7566: Activity: block 2nd click on .activity-read-more
----------------------------------------+----------------------
Reporter: slaFFik | Owner:
Type: defect (bug) | Status: closed
Priority: normal | Milestone:
Component: Activity | Version:
Severity: normal | Resolution: wontfix
Keywords: needs-patch good-first-bug |
----------------------------------------+----------------------
Comment (by slaFFik):
@DJPaul
But it's a bug, not a feature-request. Won't we fix bugs in bp-legacy as
well? So in general - no more changes in it at all?
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Thu Jul 27 10:46:12 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Thu, 27 Jul 2017 10:46:12 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7572: Buddypress Activity
Filter not displaying the results for multiple filters
In-Reply-To: <046.35d8c4b375c2c472f440ff78f9014f59@wordpress.org>
References: <046.35d8c4b375c2c472f440ff78f9014f59@wordpress.org>
Message-ID: <061.6452f5c920121669eef1876a0b464607@wordpress.org>
#7572: Buddypress Activity Filter not displaying the results for multiple filters
-----------------------------------------------+---------------------------
Reporter: seventhqueen | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting
Component: Core | Review
Severity: normal | Version:
Keywords: has-screenshots reporter-feedback | Resolution:
-----------------------------------------------+---------------------------
Comment (by DJPaul):
Also, if it is a bug, we aren't going to work on the bp-legacy templates,
which is where the code for this bug would live.
When we ship our new templates, hopefully 3.0, we'll re-accept template
reports then.
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Thu Jul 27 10:51:01 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Thu, 27 Jul 2017 10:51:01 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7529: Groups member loop
missing bp_parse_args
In-Reply-To: <045.abc31d952874a59f7319bfd4813dd16f@wordpress.org>
References: <045.abc31d952874a59f7319bfd4813dd16f@wordpress.org>
Message-ID: <060.2a5b2fddbe9c647df40a484f0a3cbae2@wordpress.org>
#7529: Groups member loop missing bp_parse_args
--------------------------+--------------------
Reporter: modemlooper | Owner:
Type: defect (bug) | Status: new
Priority: high | Milestone: 3.0
Component: Members | Version: 2.8.2
Severity: normal | Resolution:
Keywords: |
--------------------------+--------------------
Changes (by DJPaul):
* milestone: Awaiting Review => 3.0
Comment:
Sure, it shouldn't take very long to change these out.
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Thu Jul 27 11:00:03 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Thu, 27 Jul 2017 11:00:03 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7436: Very slow
check_is_friend function
In-Reply-To: <043.b59c9ddb2b9881fe3ff07fbdf381ef91@wordpress.org>
References: <043.b59c9ddb2b9881fe3ff07fbdf381ef91@wordpress.org>
Message-ID: <058.51367e21f1cb7129f9a103382cb1bdcf@wordpress.org>
#7436: Very slow check_is_friend function
--------------------------+------------------
Reporter: januzi_pl | Owner:
Type: defect (bug) | Status: new
Priority: high | Milestone: 3.0
Component: Friends | Version: 2.7
Severity: major | Resolution:
Keywords: dev-feedback |
--------------------------+------------------
Changes (by DJPaul):
* priority: low => high
* milestone: Under Consideration => 3.0
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Thu Jul 27 11:00:27 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Thu, 27 Jul 2017 11:00:27 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #2721: All activity streams
view link should have similar end points
In-Reply-To: <045.b1479d0a142fd47fd785a3c4fe211b3c@wordpress.org>
References: <045.b1479d0a142fd47fd785a3c4fe211b3c@wordpress.org>
Message-ID: <060.a9730256cb1d9b47b6957ffff803eb71@wordpress.org>
#2721: All activity streams view link should have similar end points
-------------------------+-----------------------------
Reporter: modemlooper | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: Future Release
Component: Activity | Version: 1.5
Severity: normal | Resolution:
Keywords: |
-------------------------+-----------------------------
Changes (by DJPaul):
* milestone: Under Consideration => Future Release
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Thu Jul 27 11:01:17 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Thu, 27 Jul 2017 11:01:17 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #6983: Failing UX for
replying to an activity-comment item's replies
In-Reply-To: <043.e158628665e8c124c38d25d693c56eaf@wordpress.org>
References: <043.e158628665e8c124c38d25d693c56eaf@wordpress.org>
Message-ID: <058.6efbeccc7a242c4a16294364aa0b8aae@wordpress.org>
#6983: Failing UX for replying to an activity-comment item's replies
-------------------------------+----------------------
Reporter: Offereins | Owner:
Type: defect (bug) | Status: closed
Priority: normal | Milestone:
Component: Activity | Version:
Severity: normal | Resolution: invalid
Keywords: reporter-feedback |
-------------------------------+----------------------
Changes (by DJPaul):
* status: new => closed
* resolution: => invalid
* milestone: Under Consideration =>
Comment:
See previous comments. If we can figure out recreate it, we can fix it.
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Thu Jul 27 11:02:11 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Thu, 27 Jul 2017 11:02:11 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7116: Move asset template
parts away from bp-legacy
In-Reply-To: <039.003d348d13fb41584f77c73152440485@wordpress.org>
References: <039.003d348d13fb41584f77c73152440485@wordpress.org>
Message-ID: <054.633ed1ba1244976da183729d971f4fc5@wordpress.org>
#7116: Move asset template parts away from bp-legacy
-----------------------------------------+----------------------
Reporter: r-a-y | Owner:
Type: enhancement | Status: closed
Priority: normal | Milestone:
Component: Templates | Version:
Severity: normal | Resolution: wontfix
Keywords: has-patch 2nd-opinion close |
-----------------------------------------+----------------------
Changes (by DJPaul):
* status: new => closed
* resolution: => wontfix
* milestone: Under Consideration =>
Comment:
This never went anywhere, I'm going to close a ticket, since Nouveau
everyone seems happy enough with duplicating the few template parts
affected etc.
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Thu Jul 27 11:06:59 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Thu, 27 Jul 2017 11:06:59 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7268: Feature Request:
Introduce 'Add Members' into front-end Group Manage
In-Reply-To: <049.3e12758ad1d8cee167be148508162ac1@wordpress.org>
References: <049.3e12758ad1d8cee167be148508162ac1@wordpress.org>
Message-ID: <064.2f579869ddf3a80d70d5d79ae157edd5@wordpress.org>
#7268: Feature Request: Introduce 'Add Members' into front-end Group Manage
-----------------------------+-----------------------------
Reporter: garrett-eclipse | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: Future Release
Component: Core | Version:
Severity: normal | Resolution:
Keywords: 2nd-opinion |
-----------------------------+-----------------------------
Changes (by DJPaul):
* milestone: Under Consideration => Future Release
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Thu Jul 27 11:07:24 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Thu, 27 Jul 2017 11:07:24 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7201: Support member types
hierarchy
In-Reply-To: <041.3ade751ba925491a42f3dadbe4ce46ce@wordpress.org>
References: <041.3ade751ba925491a42f3dadbe4ce46ce@wordpress.org>
Message-ID: <056.2d58664c875e115f1e6f1fe2f44f8271@wordpress.org>
#7201: Support member types hierarchy
-------------------------+-----------------------------
Reporter: slaFFik | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: Future Release
Component: Members | Version: 2.2
Severity: normal | Resolution:
Keywords: 2nd-opinion |
-------------------------+-----------------------------
Changes (by DJPaul):
* milestone: Under Consideration => Future Release
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Thu Jul 27 11:14:02 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Thu, 27 Jul 2017 11:14:02 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7333: Make it easier for
developers to add data to core classes
In-Reply-To: <046.f2f0b21fed79597295b0eeff13248969@wordpress.org>
References: <046.f2f0b21fed79597295b0eeff13248969@wordpress.org>
Message-ID: <061.9e8bd6a900826ba5eac8f2d869272c00@wordpress.org>
#7333: Make it easier for developers to add data to core classes
--------------------------+-------------------------
Reporter: boonebgorges | Owner:
Type: defect (bug) | Status: closed
Priority: normal | Milestone:
Component: Core | Version:
Severity: normal | Resolution: maybelater
Keywords: 2nd-opinion |
--------------------------+-------------------------
Changes (by DJPaul):
* status: new => closed
* resolution: => maybelater
* milestone: Under Consideration =>
Comment:
Given the lack of enthusiasm, let's close this for now.
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Thu Jul 27 11:22:23 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Thu, 27 Jul 2017 11:22:23 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7368: Allow activity
stream to be sorted by most recently commented
In-Reply-To: <040.6c0e0cf933ae1d69fb6dc3c6d73f870d@wordpress.org>
References: <040.6c0e0cf933ae1d69fb6dc3c6d73f870d@wordpress.org>
Message-ID: <055.bdf9d5e0fdf2844a91d5131b633a4c29@wordpress.org>
#7368: Allow activity stream to be sorted by most recently commented
-----------------------------+-----------------------------
Reporter: Sweeny | Owner:
Type: feature request | Status: new
Priority: normal | Milestone: Future Release
Component: Activity | Version: 2.7.2
Severity: normal | Resolution:
Keywords: |
-----------------------------+-----------------------------
Changes (by DJPaul):
* milestone: Under Consideration => Future Release
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Thu Jul 27 11:17:51 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Thu, 27 Jul 2017 11:17:51 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7361: PHP-FPM & Opcache
SIGSEGV on PHP 7.1RC6
In-Reply-To: <043.5c0508765038e5fab4d705d410e848cb@wordpress.org>
References: <043.5c0508765038e5fab4d705d410e848cb@wordpress.org>
Message-ID: <058.8d69f8291446dc1face95ed3284340bd@wordpress.org>
#7361: PHP-FPM & Opcache SIGSEGV on PHP 7.1RC6
--------------------------+----------------------------------
Reporter: lgreenwoo | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: Under Consideration
Component: Core | Version: 2.7.2
Severity: normal | Resolution:
Keywords: |
--------------------------+----------------------------------
Comment (by DJPaul):
We have tests on PHP 7.1 now, mostly failing, but we're aware.
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Thu Jul 27 11:19:06 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Thu, 27 Jul 2017 11:19:06 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7361: PHP-FPM & Opcache
SIGSEGV on PHP 7.1RC6
In-Reply-To: <043.5c0508765038e5fab4d705d410e848cb@wordpress.org>
References: <043.5c0508765038e5fab4d705d410e848cb@wordpress.org>
Message-ID: <058.00d6fc571c3269566dbfdf0964dc246e@wordpress.org>
#7361: PHP-FPM & Opcache SIGSEGV on PHP 7.1RC6
--------------------------+--------------------
Reporter: lgreenwoo | Owner:
Type: defect (bug) | Status: new
Priority: high | Milestone: 3.0
Component: Core | Version: 2.7.2
Severity: major | Resolution:
Keywords: |
--------------------------+--------------------
Changes (by DJPaul):
* priority: normal => high
* severity: normal => major
* milestone: Under Consideration => 3.0
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Thu Jul 27 11:27:25 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Thu, 27 Jul 2017 11:27:25 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7400: Allow Multiple
activity loop on same page work properly
In-Reply-To: <042.838d212363ebcafb076047bd85b74438@wordpress.org>
References: <042.838d212363ebcafb076047bd85b74438@wordpress.org>
Message-ID: <057.88d3d2ab67df256f920f8d622e8f2ef5@wordpress.org>
#7400: Allow Multiple activity loop on same page work properly
-----------------------------------+----------------------
Reporter: sbrajesh | Owner:
Type: enhancement | Status: closed
Priority: normal | Milestone:
Component: Templates | Version:
Severity: normal | Resolution: wontfix
Keywords: has-patch 2nd-opinion |
-----------------------------------+----------------------
Changes (by DJPaul):
* status: new => closed
* resolution: => wontfix
* milestone: Under Consideration =>
Comment:
This continues to be neat, but as Nouveau is legitimately close, let's not
enhance Legacy any more. Thank you for your effort here @sbrajesh and
sorry we didn't ship it earlier.
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Thu Jul 27 11:22:50 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Thu, 27 Jul 2017 11:22:50 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7396: "WHO's ONLINE"
widget not working.
In-Reply-To: <051.8a904d30d29d71c94321cf219fe7cee5@wordpress.org>
References: <051.8a904d30d29d71c94321cf219fe7cee5@wordpress.org>
Message-ID: <066.ff2d56d3d9808b1224e9fc503bd3e9c1@wordpress.org>
#7396: "WHO's ONLINE" widget not working.
-------------------------------+-------------------------
Reporter: courtneybostdorff | Owner:
Type: defect (bug) | Status: closed
Priority: normal | Milestone:
Component: Core | Version: 2.7
Severity: normal | Resolution: worksforme
Keywords: 2nd-opinion |
-------------------------------+-------------------------
Changes (by DJPaul):
* status: new => closed
* resolution: => worksforme
* milestone: Under Consideration =>
Comment:
Closing this, assumed it still works.
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Thu Jul 27 11:23:26 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Thu, 27 Jul 2017 11:23:26 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7444: Spelling of Style
Sheet is two words, not one
In-Reply-To: <040.7f46c97da411b1f242e6134e9e9aa932@wordpress.org>
References: <040.7f46c97da411b1f242e6134e9e9aa932@wordpress.org>
Message-ID: <055.fa8ebb6096b79e82ac550fb397608726@wordpress.org>
#7444: Spelling of Style Sheet is two words, not one
--------------------------+----------------------
Reporter: netweb | Owner:
Type: defect (bug) | Status: closed
Priority: normal | Milestone:
Component: Core | Version:
Severity: normal | Resolution: wontfix
Keywords: has-patch |
--------------------------+----------------------
Changes (by DJPaul):
* status: new => closed
* resolution: => wontfix
* milestone: Under Consideration =>
Comment:
Clearly no-one felt very strongly, so closing this.
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Thu Jul 27 11:30:20 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Thu, 27 Jul 2017 11:30:20 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7534: Remove read
notifications from the DB table after a specified time period
In-Reply-To: <039.22b002683319bd8f6adc7528c0549313@wordpress.org>
References: <039.22b002683319bd8f6adc7528c0549313@wordpress.org>
Message-ID: <054.69ed1e5f2e8b2c7a5afb74ec62c10f91@wordpress.org>
#7534: Remove read notifications from the DB table after a specified time period
--------------------------+------------------
Reporter: r-a-y | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: 3.0
Component: Performance | Version:
Severity: normal | Resolution:
Keywords: dev-feedback |
--------------------------+------------------
Changes (by DJPaul):
* milestone: Under Consideration => 3.0
Comment:
We gotta do something here.
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Thu Jul 27 11:32:32 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Thu, 27 Jul 2017 11:32:32 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7552: Introduce
'visibility' parameter for registering BP nav items
In-Reply-To: <039.e62b975f3e06a9ec25b8560b42ca8bac@wordpress.org>
References: <039.e62b975f3e06a9ec25b8560b42ca8bac@wordpress.org>
Message-ID: <054.d24139ea1047ee90819f0a3a6efe6894@wordpress.org>
#7552: Introduce 'visibility' parameter for registering BP nav items
------------------------------------+------------------
Reporter: r-a-y | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: 3.0
Component: Navigation | Version:
Severity: normal | Resolution:
Keywords: has-patch dev-feedback |
------------------------------------+------------------
Changes (by DJPaul):
* component: Core => Navigation
* milestone: Under Consideration => 3.0
Comment:
I like the principle, let's take a look.
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Thu Jul 27 11:32:56 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Thu, 27 Jul 2017 11:32:56 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7278: No content when
defining another default tab for profile settings
In-Reply-To: <039.b7e72a539dafe2230a615138a223fbe5@wordpress.org>
References: <039.b7e72a539dafe2230a615138a223fbe5@wordpress.org>
Message-ID: <054.5ade47b167e7dd16ffed6dcfc4f39443@wordpress.org>
#7278: No content when defining another default tab for profile settings
--------------------------------------+------------------------------
Reporter: danbp | Owner:
Type: defect (bug) | Status: new
Priority: high | Milestone: Awaiting Review
Component: Members | Version:
Severity: normal | Resolution:
Keywords: dev-feedback 2nd-opinion |
--------------------------------------+------------------------------
Changes (by DJPaul):
* milestone: Under Consideration => Awaiting Review
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Thu Jul 27 11:42:14 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Thu, 27 Jul 2017 11:42:14 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #6783: Groups: Add Profile
Fields and Profile Field Groups
In-Reply-To: <041.c6fbdef85e92040741ea65c6565cf97e@wordpress.org>
References: <041.c6fbdef85e92040741ea65c6565cf97e@wordpress.org>
Message-ID: <056.c1150e6261f5d1d06c6108058ae4e440@wordpress.org>
#6783: Groups: Add Profile Fields and Profile Field Groups
-------------------------+-------------------------
Reporter: mercime | Owner:
Type: enhancement | Status: closed
Priority: normal | Milestone:
Component: Groups | Version:
Severity: normal | Resolution: maybelater
Keywords: 2nd-opinion |
-------------------------+-------------------------
Changes (by DJPaul):
* status: reopened => closed
* resolution: => maybelater
* milestone: Under Consideration =>
Comment:
Given the understanding that Groups is conceptually a taxonomy, assigning
profile fields to a Group would fit, but this would require significant
engineering effort. We'll re-open the ticket in the future if anyone wants
to work on it, and see it through.
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Thu Jul 27 11:58:57 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Thu, 27 Jul 2017 11:58:57 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #4885: WPML page
translation with BuddyPress 1.7 beta 2 + Responsive theme working wrong.
In-Reply-To: <045.df1f85315df9534122f96df4f8e5be18@wordpress.org>
References: <045.df1f85315df9534122f96df4f8e5be18@wordpress.org>
Message-ID: <060.5309953a614f354398f6291ddad3572e@wordpress.org>
#4885: WPML page translation with BuddyPress 1.7 beta 2 + Responsive theme working
wrong.
---------------------------------------+----------------------
Reporter: gr0uch0mars | Owner:
Type: defect (bug) | Status: closed
Priority: normal | Milestone:
Component: Templates | Version: 1.7
Severity: minor | Resolution: invalid
Keywords: needs-testing needs-patch |
---------------------------------------+----------------------
Changes (by DJPaul):
* status: new => closed
* resolution: => invalid
* milestone: Future Release =>
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Thu Jul 27 11:56:39 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Thu, 27 Jul 2017 11:56:39 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7550: Introduce new action
hooks for single group and member template
In-Reply-To: <043.2db361a6253c09facf20663726aee936@wordpress.org>
References: <043.2db361a6253c09facf20663726aee936@wordpress.org>
Message-ID: <058.89fb618e90b4519e6ab8013359f441c0@wordpress.org>
#7550: Introduce new action hooks for single group and member template
-------------------------+----------------------
Reporter: lenasterg | Owner:
Type: enhancement | Status: closed
Priority: low | Milestone:
Component: Templates | Version:
Severity: trivial | Resolution: wontfix
Keywords: |
-------------------------+----------------------
Comment (by hnla):
Not necessarily (yet), but will be replaced shortly by Nouveau or at least
new installs will default to Nouveau with bp-legacy as a switchable option
(established installs will continue to use bp-legacy until they choose to
switch over)
Have a look at Nouveau, it approaches hooks in a different manner, largely
doing away with the notion of template do_actions.
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Thu Jul 27 12:01:09 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Thu, 27 Jul 2017 12:01:09 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #5715: Profile image
placeholders
In-Reply-To: <045.a8096c2bc62b62fdaebbe949cad97302@wordpress.org>
References: <045.a8096c2bc62b62fdaebbe949cad97302@wordpress.org>
Message-ID: <060.48c72c3a8b909299b90d25a01fba9b1b@wordpress.org>
#5715: Profile image placeholders
-------------------------------------------------+-------------------------
Reporter: sooskriszta | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: Future
Component: Extended Profile | Release
Severity: normal | Version:
Keywords: has-patch needs-testing dev- | Resolution:
feedback |
-------------------------------------------------+-------------------------
Changes (by DJPaul):
* component: Templates => Extended Profile
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Thu Jul 27 11:58:38 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Thu, 27 Jul 2017 11:58:38 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #4783: Front End editor
(and edit forum posts)
In-Reply-To: <046.3e2409260abd34fe53601274f58af956@wordpress.org>
References: <046.3e2409260abd34fe53601274f58af956@wordpress.org>
Message-ID: <061.f4b0c0f9f32b2867db3f264980035ea9@wordpress.org>
#4783: Front End editor (and edit forum posts)
--------------------------+----------------------
Reporter: stefwilliams | Owner:
Type: defect (bug) | Status: closed
Priority: normal | Milestone:
Component: Templates | Version: 1.7
Severity: minor | Resolution: invalid
Keywords: |
--------------------------+----------------------
Changes (by DJPaul):
* status: new => closed
* resolution: => invalid
* milestone: Future Release =>
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Thu Jul 27 12:00:39 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Thu, 27 Jul 2017 12:00:39 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #5583: Simplify registration
In-Reply-To: <045.6be5eb722dd265f2b0d191eb802365e3@wordpress.org>
References: <045.6be5eb722dd265f2b0d191eb802365e3@wordpress.org>
Message-ID: <060.299f8be778f982448551da52417e92bc@wordpress.org>
#5583: Simplify registration
--------------------------+-----------------------------
Reporter: sooskriszta | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: Future Release
Component: Registration | Version:
Severity: normal | Resolution:
Keywords: |
--------------------------+-----------------------------
Changes (by DJPaul):
* component: Templates => Registration
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Thu Jul 27 12:08:54 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Thu, 27 Jul 2017 12:08:54 -0000
Subject: [buddypress-trac] [BuddyPress Trac] Batch modify: #5566, #5911,
#4950, #6510, #6514, #6818, #7091, #7139, #4449, #4500, #4585, #4665, #4951,
#4966, #4968, #5153, #5564, #5739, #5761, #5797, #5895, #5931, #6048, #6172,
#6230, #6253, #6296, #6379, #6556, #6642, #6691, #6753, #6771, #6960, #7063,
#7102, #7191, #7352, #7158, #4855, #5759, #7338
Message-ID: <20170727120854.43C9E1080072@svn1.lax.wordpress.org>
Batch modification to #5566, #5911, #4950, #6510, #6514, #6818, #7091, #7139, #4449, #4500, #4585, #4665, #4951, #4966, #4968, #5153, #5564, #5739, #5761, #5797, #5895, #5931, #6048, #6172, #6230, #6253, #6296, #6379, #6556, #6642, #6691, #6753, #6771, #6960, #7063, #7102, #7191, #7352, #7158, #4855, #5759, #7338 by DJPaul:
milestone to
Action: resolve
Comment:
Closing most tickets related to BP-Default and BP-Legacy, since the upcoming BP-Nouveau template pack (planned for 3.0) will make these redundant.
--
Tickets URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Thu Jul 27 12:10:04 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Thu, 27 Jul 2017 12:10:04 -0000
Subject: [buddypress-trac] [BuddyPress Trac] Batch modify: #5566, #5911,
#4950, #6510, #6514, #6818, #7091, #7139, #4449, #4500, #4585, #4665, #4951,
#4966, #4968, #5153, #5564, #5739, #5761, #5797, #5895, #5931, #6048, #6172,
#6230, #6253, #6296, #6379, #6556, #6642, #6691, #6753, #6771, #6960, #7063,
#7102, #7191, #7352, #7158, #4855, #5759, #7338
Message-ID: <20170727121004.AE8591080072@svn1.lax.wordpress.org>
Batch modification to #5566, #5911, #4950, #6510, #6514, #6818, #7091, #7139, #4449, #4500, #4585, #4665, #4951, #4966, #4968, #5153, #5564, #5739, #5761, #5797, #5895, #5931, #6048, #6172, #6230, #6253, #6296, #6379, #6556, #6642, #6691, #6753, #6771, #6960, #7063, #7102, #7191, #7352, #7158, #4855, #5759, #7338 by DJPaul:
milestone to
Action: resolve
Comment:
Closing most tickets related to BP-Default and BP-Legacy, since the upcoming BP-Nouveau template pack (planned for 3.0) will make these redundant.
--
Tickets URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Thu Jul 27 19:07:27 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Thu, 27 Jul 2017 19:07:27 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7575: Admin common style
selectors must be more specific
Message-ID: <043.b7a2080e61ff1e08d084bd7ada1777f1@wordpress.org>
#7575: Admin common style selectors must be more specific
----------------------------+-----------------------------
Reporter: geminorum | Owner: slaFFik
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Administration | Version: 2.8.2
Severity: normal | Keywords:
----------------------------+-----------------------------
Apparently BuddyPress adds common styles to all admin pages, and appends a
`buddypress` class to the html body. for example:
{{{
.buddypress code {
background-color: #e0e0e0;
color: #636363;
font-size: 1em;
}
}}}
it affects all `code` tags on all admin page, and frankly not a good
practice.
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Thu Jul 27 19:38:21 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Thu, 27 Jul 2017 19:38:21 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7540: Adding a button and
function for a member to leave a multi-recipients conversation
In-Reply-To: <040.bab4a017790a19d4ad6d0f7bce3fca0d@wordpress.org>
References: <040.bab4a017790a19d4ad6d0f7bce3fca0d@wordpress.org>
Message-ID: <055.100f421fbfee3b2c36cb26b698c691b1@wordpress.org>
#7540: Adding a button and function for a member to leave a multi-recipients
conversation
----------------------------------------+-----------------------------
Reporter: Oelita | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: Future Release
Component: Messages | Version:
Severity: normal | Resolution:
Keywords: good-first-bug ux-feedback |
----------------------------------------+-----------------------------
Changes (by boonebgorges):
* keywords: => good-first-bug ux-feedback
Comment:
I don't recall doing this myself. I do recall talking with @Oelita at WCEU
about this feature.
The above could probably be converted to a patch without too much trouble.
It would be helpful to see screenshots of what the UI mods look like,
especially with respect to Nouveau.
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Thu Jul 27 22:23:40 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Thu, 27 Jul 2017 22:23:40 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7540: Adding a button and
function for a member to leave a multi-recipients conversation
In-Reply-To: <040.bab4a017790a19d4ad6d0f7bce3fca0d@wordpress.org>
References: <040.bab4a017790a19d4ad6d0f7bce3fca0d@wordpress.org>
Message-ID: <055.77b51df564d4bb7f21d5136c99f106ae@wordpress.org>
#7540: Adding a button and function for a member to leave a multi-recipients
conversation
----------------------------------------+-----------------------------
Reporter: Oelita | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: Future Release
Component: Messages | Version:
Severity: normal | Resolution:
Keywords: good-first-bug ux-feedback |
----------------------------------------+-----------------------------
Comment (by Oelita):
I will try to convert it to a patch and show a screenshot , after my
holidays, thanks
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From noreply at wordpress.org Fri Jul 28 05:05:47 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Fri, 28 Jul 2017 05:05:47 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7228: Add PHPCS
In-Reply-To: <040.d6dc8d60474d8530ffeee9c71acb70d2@wordpress.org>
References: <040.d6dc8d60474d8530ffeee9c71acb70d2@wordpress.org>
Message-ID: <055.d3416799690299ad82197a982257d1ef@wordpress.org>
#7228: Add PHPCS
------------------------------+-------------------------
Reporter: DJPaul | Owner:
Type: enhancement | Status: closed
Priority: normal | Milestone:
Component: Build/Test Tools | Version:
Severity: normal | Resolution: maybelater
Keywords: |
------------------------------+-------------------------
Comment (by netweb):
Replying to [comment:5 DJPaul]:
> At Human Made, we've had issues with wp-dev-lib and it being quite
brittle. Given that wp-dev-lib would be a key part of this - every file
would undoubtably through warnings if we weren't running this only on new
changes - i'm going to close this ticket for now and if we/Human Made come
up with something a bit more reliable and there's interest, we can re-
open.
I agree, it's also about to become a lot less generic, it's currently
implementing coding standards changes that differ to WordPress Coding
Standards.
> Or switch to Github and have Travis-CI run PHPCS on pull requests. :p
Or just run PHPCS across the entire codebase and be done with it,
WordPress itself is doing it in #WP41057
WordPress will also be adding pre-commit hooks as part of this, I've some
initial work done for this that looks promising
Anyways, I'll keep BP in mind as I will do for bbPress as this WordPress
initiative progresses, when I've got some solid plans I'll reopen this
ticket with a proposal.
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From buddypress-trac at lists.automattic.com Fri Jul 28 08:00:08 2017
From: buddypress-trac at lists.automattic.com (buddypress-trac at lists.automattic.com)
Date: Fri, 28 Jul 2017 08:00:08 +0000 (UTC)
Subject: [buddypress-trac] [BuddyPress][11652] trunk/.travis.yml: Build
Tools: Check for existence `xdebug.ini` using `phpenv` for Travis CI
Message-ID: <20170728080008.8FD8A1080399@svn1.lax.wordpress.org>
An HTML attachment was scrubbed...
URL:
From noreply at wordpress.org Fri Jul 28 08:00:09 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Fri, 28 Jul 2017 08:00:09 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7574: Update Travis CI
build matrix for PHP 7.2
In-Reply-To: <040.f9b8b31c34aeb832e3ba741ddc706878@wordpress.org>
References: <040.f9b8b31c34aeb832e3ba741ddc706878@wordpress.org>
Message-ID: <055.c336d0678e0a6652446a747bff0fbb86@wordpress.org>
#7574: Update Travis CI build matrix for PHP 7.2
------------------------------+---------------------
Reporter: netweb | Owner: netweb
Type: enhancement | Status: closed
Priority: normal | Milestone: 2.9
Component: Build/Test Tools | Version:
Severity: normal | Resolution: fixed
Keywords: |
------------------------------+---------------------
Comment (by netweb):
In [changeset:"11652"]:
{{{
#!CommitTicketReference repository="" revision="11652"
Build Tools: Check for existence `xdebug.ini` using `phpenv` for Travis CI
This changeset is a follow up to [11649] where XDebug wasn't being
detected correctly for the PHP 7.2 and 7.3 jobs
See #7574.
}}}
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From buddypress-trac at lists.automattic.com Fri Jul 28 08:08:27 2017
From: buddypress-trac at lists.automattic.com (buddypress-trac at lists.automattic.com)
Date: Fri, 28 Jul 2017 08:08:27 +0000 (UTC)
Subject: [buddypress-trac] [BuddyPress][11653] trunk/.travis.yml: Build
Tools: Run Travis-CI unit tests on WordPress 4.8.
Message-ID: <20170728080827.D39471080399@svn1.lax.wordpress.org>
An HTML attachment was scrubbed...
URL:
From noreply at wordpress.org Fri Jul 28 13:35:40 2017
From: noreply at wordpress.org (buddypress-trac)
Date: Fri, 28 Jul 2017 13:35:40 -0000
Subject: [buddypress-trac] [BuddyPress Trac] #7576: Get notification
description outside loop
Message-ID: <047.0914963a2f597a24a0d8bb5209532631@wordpress.org>
#7576: Get notification description outside loop
-------------------------------------+-----------------------------
Reporter: wordpressrene | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Toolbar & Notifications | Version: 2.8.2
Severity: normal | Keywords:
-------------------------------------+-----------------------------
Could you add the possibility to get the notification description (and to
choose whose format) of a specific notification outside the loop? You
could change the function bp_get_the_notification_description() to achieve
this:
{{{#!php
notifications->query_loop->notification : $notification;
// Callback function exists.
if ( isset( $bp->{ $notification->component_name
}->notification_callback ) && is_callable( $bp->{
$notification->component_name }->notification_callback ) ) {
$description = call_user_func( $bp->{
$notification->component_name }->notification_callback,
$notification->component_action, $notification->item_id,
$notification->secondary_item_id, 1, $format, $notification->id );
// @deprecated format_notification_function - 1.5
} elseif ( isset( $bp->{ $notification->component_name
}->format_notification_function ) && function_exists( $bp->{
$notification->component_name }->format_notification_function ) ) {
$description = call_user_func( $bp->{
$notification->component_name }->format_notification_function,
$notification->component_action, $notification->item_id,
$notification->secondary_item_id, 1 );
// Allow non BuddyPress components to hook in.
} else {
/** This filter is documented in bp-notifications/bp-
notifications-functions.php */
$description = apply_filters_ref_array(
'bp_notifications_get_notifications_for_user', array(
$notification->component_action, $notification->item_id,
$notification->secondary_item_id, 1, $format,
$notification->component_action, $notification->component_name,
$notification->id ) );
}
/**
* Filters the full-text description for a specific notification.
*
* @since 1.9.0
* @since 2.3.0 Added the `$notification` parameter.
*
* @param string $description Full-text description for a
specific notification.
* @param object $notification Notification object.
*/
return apply_filters( 'bp_get_the_notification_description',
$description, $notification );
}
}}}
--
Ticket URL:
BuddyPress Trac
BuddyPress Trac
From buddypress-trac at lists.automattic.com Fri Jul 28 17:53:25 2017
From: buddypress-trac at lists.automattic.com (buddypress-trac at lists.automattic.com)
Date: Fri, 28 Jul 2017 17:53:25 +0000 (UTC)
Subject: [buddypress-trac] [BuddyPress][11654] trunk: Update version numbers
and readme.txt - 2.9.0-RC1 to 2.9.0
Message-ID: <20170728175325.B83A01080399@svn1.lax.wordpress.org>
An HTML attachment was scrubbed...
URL:
From buddypress-trac at lists.automattic.com Fri Jul 28 19:45:50 2017
From: buddypress-trac at lists.automattic.com (buddypress-trac at lists.automattic.com)
Date: Fri, 28 Jul 2017 19:45:50 +0000 (UTC)
Subject: [buddypress-trac] [BuddyPress][11655] trunk/src/readme.txt: Change
`Tested up to` tag to 4.8 from 4.8.0 in readme.txt
Message-ID: <20170728194550.3D7AC1080399@svn1.lax.wordpress.org>
An HTML attachment was scrubbed...
URL:
From buddypress-trac at lists.automattic.com Fri Jul 28 20:08:32 2017
From: buddypress-trac at lists.automattic.com (buddypress-trac at lists.automattic.com)
Date: Fri, 28 Jul 2017 20:08:32 +0000 (UTC)
Subject: [buddypress-trac] [BuddyPress][11656] branches/2.9/: Create Branch
2.9
Message-ID: <20170728200832.BEBA51080399@svn1.lax.wordpress.org>
An HTML attachment was scrubbed...
URL:
From buddypress-trac at lists.automattic.com Fri Jul 28 20:12:41 2017
From: buddypress-trac at lists.automattic.com (buddypress-trac at lists.automattic.com)
Date: Fri, 28 Jul 2017 20:12:41 +0000 (UTC)
Subject: [buddypress-trac] [BuddyPress][11657] tags/2.9.0/: Create tag 2.9.0
from branch 2.9
Message-ID: <20170728201241.8A4811080399@svn1.lax.wordpress.org>
An HTML attachment was scrubbed...
URL: