[buddypress-trac] [BuddyPress Trac] #7450: Problem deleting comment activities

[buddypress-trac]

#7450: Problem deleting comment activities
--------------------------+--------------------
 Reporter:  Maniou        |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  highest       |   Milestone:  2.8.2
Component:  Activity      |     Version:  1.2
 Severity:  critical      |  Resolution:
 Keywords:  has-patch     |
--------------------------+--------------------
Changes (by r-a-y):

 * keywords:  needs-patch => has-patch
 * version:  2.8.0 => 1.2
 * milestone:  Awaiting Review => 2.8.2


Comment:

 @Maniou - Thanks for reporting this important bug.

 I can confirm the problem.  It's due to bp_activity_delete_children() (and
 less importantly, `bp_activity_delete_comment()`) not doing any empty
 checks against the passed `$activity_id`.

 It doesn't appear that this problem is a regression from v2.8.0, but I
 think it's important enough to fix in a 2.8.x release.

 I've attached a patch that should fix the problem.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7450#comment:1>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac