[buddypress-trac] [BuddyPress Trac] #7196: Prevent BP from being updated when minimum requirements are not met

buddypress-trac noreply at wordpress.org
Mon Sep 19 19:09:12 UTC 2016

#7196: Prevent BP from being updated when minimum requirements are not met
 Reporter:  boonebgorges           |       Owner:
     Type:  enhancement            |      Status:  new
 Priority:  normal                 |   Milestone:  2.7
Component:  Core                   |     Version:
 Severity:  normal                 |  Resolution:
 Keywords:  2nd-opinion has-patch  |

Comment (by boonebgorges):

 Thank you, @r-a-y!

 What about update-core.php? You removed my crummy `core_upgrade_preamble`
 bit, but I don't think any of your new Shiny stuff covers that case. Or am
 I wrong?

 It dawned on my after my last post that the update-core.php part of my
 patch didn't check for the BP version, so it would block 2.7.x in addition
 to 2.8; this suggests that we might need to use jQuery, which I'd been
 avoiding, or check the site transient to get the available update info.

 Your trick in `bp_core_admin_disable_bulk_activate()` is less ugly
 codewise, than disabling the checkbox, but it seems like suboptimal UX,
 since people might get confused about the fact that they're checking
 BuddyPress but it's not being updated. To be clear: I don't think it's
 worth spending a ton of time or effort making the experience seamless in
 these cases. But I mainly wanted to check to see if you'd removed this for
 a principled reason, or just because it was ugly :-D

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7196#comment:8>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac

More information about the buddypress-trac mailing list