[buddypress-trac] [BuddyPress Trac] #5451: Groups query overhaul

[buddypress-trac]

#5451: Groups query overhaul
--------------------------+-----------------------
 Reporter:  boonebgorges  |       Owner:
     Type:  enhancement   |      Status:  reopened
 Priority:  high          |   Milestone:  2.7
Component:  Groups        |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+-----------------------

Comment (by boonebgorges):

 Thanks for the patch, @r-a-y!

 If I'm reading [attachment:5451.isset.patch] correctly, it'll cause
 problems with falsey values.

 {{{
 // Say the user is *not* a member of the group
 $group = new BP_Groups_Group();

 // bool( false )
 var_dump( $group->is_member );

 // bool( true )
 var_dump( empty( $group->is_member ) )

 // bool( false )
 var_dump( isset( $group->is_member ) )
 }}}

 I think this last part is incorrect - the value is set, but it happens to
 be empty. Does that seem right to you? If so, I think the right solution
 is to return true for the keys that are accessible by magic method.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5451#comment:38>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac