[buddypress-trac] [BuddyPress Trac] #7300: xprofile date field year regression on existing fields

[buddypress-trac]

#7300: xprofile date field year regression on existing fields
------------------------------+-----------------------
 Reporter:  DJPaul            |       Owner:  djpaul
     Type:  defect (bug)      |      Status:  assigned
 Priority:  high              |   Milestone:  2.7.1
Component:  Extended Profile  |     Version:
 Severity:  major             |  Resolution:
 Keywords:  commit            |
------------------------------+-----------------------
Changes (by boonebgorges):

 * keywords:   => commit
 * owner:   => djpaul
 * status:  new => assigned


Comment:

 Thanks for tracking this down, @DJPaul. Fix looks good to me.

 > This contradicts our PHPDoc block for bp_xprofile_get_meta which says it
 returns a boolean false if the request value is not set... which is how
 WP's https://codex.wordpress.org/Function_Reference/get_user_meta works,
 so we probably need to go through all our custom meta functions, fix the
 docblocks, and check other instances we might be handling type strict.
 This second part itself should be its own ticket, but I want confirmation
 that I've looked at this correctly first. :)

 Ugh. I feel like I specifically looked at this when migrating the meta
 functions to WP's. I wonder if xprofile is a special case, because it
 translates object_id. In any case, definitely worth a separate ticket.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7300#comment:5>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac