[buddypress-trac] [BuddyPress Trac] #6275: Missing plural on activities for show all comments button

buddypress-trac noreply at wordpress.org
Sat Nov 5 21:54:17 UTC 2016


#6275: Missing plural on activities for show all comments button
--------------------------+-----------------------------
 Reporter:  danbp         |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Future Release
Component:  Activity      |     Version:  2.2.1
 Severity:  minor         |  Resolution:
 Keywords:  needs-patch   |
--------------------------+-----------------------------

Comment (by slaFFik):

 In my opinion the easiest solution will be instead of this:

 {{{
 'show_all'          => __( 'Show all', 'buddypress' ),
 'show_all_comments' => __( 'Show all comments for this thread',
 'buddypress' ),
 'show_x_comments'   => __( 'Show all %d comments', 'buddypress' ),
 }}}

 to have only 1 record:

 {{{
 'show_all' => __( 'Show all', 'buddypress' ),
 }}}

 As `show_all` includes all other possible special cases
 `show_all_comments` and `show_x_comments`.

 What do you think? Such fix is general and quite easy, and will eliminate
 this problem.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6275#comment:5>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list