[buddypress-trac] [BuddyPress Trac] #7104: oembed activity review

[buddypress-trac]

#7104: oembed activity review
--------------------------+------------------
 Reporter:  DJPaul        |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  2.6
Component:  API           |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+------------------
Changes (by r-a-y):

 * keywords:   => has-patch


Comment:

 Thanks for the feedback, @DJPaul.  I'm going to reply to each point in a
 separate comment.

 First:

 > css-activity.php; why isn't this just a CSS file?

 Initially, it's because we did not have dedicated functions to locate and
 load assets in Core, so I kind of hacked my way around by using a template
 part.  On hindsight, this is bad and breaks theme developer conventions.

 So `css.patch` is what I originally envisioned for locating and loading
 assets.  It introduces two functions:
 - `bp_locate_template_asset()` - which is almost exactly like
 `bp_locate_template()`
 - `bp_get_template_asset()` - which is almost exactly like
 `bp_get_template_part()`

 I feel this should replace `BP_Legacy::locate_asset_in_stack()`.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7104#comment:3>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac