[buddypress-trac] [BuddyPress Trac] #6896: Improve BP Emails templating

[buddypress-trac]

#6896: Improve BP Emails templating
-----------------------------------------+------------------
 Reporter:  imath                        |       Owner:
     Type:  defect (bug)                 |      Status:  new
 Priority:  normal                       |   Milestone:  2.5
Component:  Appearance - Template Parts  |     Version:
 Severity:  normal                       |  Resolution:
 Keywords:  has-patch                    |
-----------------------------------------+------------------

Comment (by DJPaul):

 Good catch with the hardcoded string. :)

 >  i had to add a new entry into the BuddyPress templates stack
 If you're trying to do this from inside a plugin, yes.

 > completely override the single-bp-email.php template just to add an
 image before the Site name
 Yes, theme templates normally work like this. ;)

 > bp_email_the_site_name()
 Are you doing this JUST to filter it?

 > bp_email_the_salutation() + bp_email_the_unsubsribe_mention()
 Why should these be filters? The strings are/will be run through i18n
 functions, so someone can use the gettext filters to change them if
 they're really desperate (or just copy/paste the template into their
 theme).

 > body.wp-customizer-unloading stuff
 This is another good test. What happens right now if this isn't present?
 How broken is it?
 Also, I think if we find we need to add CSS to fix the display in the
 Customiser, this should be in a new stylesheet -- not inside the actual
 markup sent in the email.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6896#comment:1>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac