[buddypress-trac] [BuddyPress Trac] #7390: Support List-Unsubscribe header in emails

[buddypress-trac]

#7390: Support List-Unsubscribe header in emails
-------------------------------------------------+-------------------------
 Reporter:  DJPaul                               |       Owner:
     Type:  enhancement                          |      Status:  new
 Priority:  normal                               |   Milestone:  2.8
Component:  Emails                               |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  good-first-bug has-patch dev-        |
  feedback 2nd-opinion                           |
-------------------------------------------------+-------------------------

Comment (by DJPaul):

 Thanks for the patch, @chiragpatel. Feedback:

 * You don't need to include the colon. BuddyPress takes care of that
 somewhere else when it builds the headers.
 * We can't support an email-based (mailto) unsubscribe mechanism. Please
 just use the web-based mechanism (i.e. the unsubscribe token).
 * If you look at `bp_email_set_default_tokens()`, you will see `token` is
 set to `site_url( 'wp-login.php' )` in certain situations.
  * We obviously can't use that link as the unsubscribe mechanism.
  * I would suggest something like `if ( ! empty( $tokens['unsubscribe'] )
 && $tokens['unsubscribe'] !== site_url( 'wp-login.php' ) ) {`
 * Did you test this in Gmail to verify the change works as expected?

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7390#comment:6>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac