[buddypress-trac] [BuddyPress Trac] #7314: Buddypress issue with Twenty Sixteen menu

buddypress-trac noreply at wordpress.org
Fri Dec 2 10:07:28 UTC 2016


#7314: Buddypress issue with Twenty Sixteen menu
---------------------------------+---------------------
 Reporter:  DarkWolf             |       Owner:  hnla
     Type:  defect (bug)         |      Status:  closed
 Priority:  normal               |   Milestone:  2.7.3
Component:  Templates            |     Version:  2.7
 Severity:  normal               |  Resolution:  fixed
 Keywords:  dev-feedback commit  |
---------------------------------+---------------------
Changes (by hnla):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"11264"]:
 {{{
 #!CommitTicketReference repository="" revision="11264"
 Correct twentysixteen `.no-js` class conflict with BP's version of same
 class on body element

 Commit adds a ruleset specific to twntysixteen to hide the onclick
 dropdown mobile menu on page load.

 Twentysixteen adds a hardcoded class to the html element & changes class
 if JS active scripted in the 'head'; BP runs similar but on body el &
 changes no-js class on DOM fully loaded.

 Menu remains in view after clicking due to 2016 updating js class early
 and BP lagging behind.

 Ruleset targets body element if it has a class `.no-js` and it's parent
 has class `.js` thus we only run if JS active and for initial page load
 sequence.

 Fixes #7314 ( Branch 2.7 )
 Props DarkWolf, DJPaul, r-a-y, hnla
 }}}

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7314#comment:19>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list