[buddypress-trac] [BuddyPress Trac] #7105: Improve group management members screen

buddypress-trac noreply at wordpress.org
Tue Aug 23 22:17:57 UTC 2016

#7105: Improve group management members screen
 Reporter:  dcavins        |       Owner:  dcavins
     Type:  enhancement    |      Status:  accepted
 Priority:  normal         |   Milestone:  2.7
Component:  Groups         |     Version:  1.1
 Severity:  normal         |  Resolution:
 Keywords:  needs-refresh  |

Comment (by dcavins):

 I’ve refreshed this patch as though #7079 has been committed. I’ve also
 made the following changes:

 * Change structure of list items to more closely match `members/members-
 loop.php` as suggested by @r-a-y. (Should we be also updating
 `groups/single/members.php` to be more like that?)
 * Added the action `bp_group_manage_members_admin_item` to the admin and
 moderator list items. (Already was applied to the member list.)
 * Added “none found” messages for each loop to support the addition of a
 search box in #6835.

 I thought more about using  `bp_groups_has_members()` instead of
 `bp_has_members()` for the admin and mod loops, and, while I'm not
 assuming we'll go that direction, there are some advantages. If we used
 `bp_groups_has_members()` for the loops, we could also then use
 `bp_group_member_joined_since()` (which seems useful) and easily add
 pagination when necessary to the admin and mod loops via

 I've run some performance comparisons, and with the loops as is, the page
 in my test environment (a small group) required 73 queries and .0327s of
 query time. Using `bp_groups_has_members()` for all three loops required
 77 queries and .0266s of query time. I’ll attach both versions of the
 patch, so others can check it out if they’d like.

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7105#comment:9>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac

More information about the buddypress-trac mailing list