[buddypress-trac] [BuddyPress Trac] #7157: UI to pick Template Packs

buddypress-trac noreply at wordpress.org
Thu Aug 18 01:35:03 UTC 2016

#7157: UI to pick Template Packs
 Reporter:  DJPaul                  |       Owner:
     Type:  defect (bug)            |      Status:  new
 Priority:  strategic               |   Milestone:  2.7
Component:  Administration          |     Version:
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |

Comment (by mercime):

 Replying to [comment:17 DJPaul]:
 > I imagine @mercime will be happy to help iterate on this form for
 accessibility guidance once the first version is committed, so don't worry
 too much yet.

 First pass. Worked in chrome browser and took some notes of initial check:
 * Need to move `<tfoot>...</tfoot>` to afer `</tbody>` in markup to
 improve accessibility of content. See #7065.
 * Remove extra and empty `<thead>` and `<tfoot>` markup showing up in
 source code following each `<thead>` and `<tfoot>` respectively.
 * Add `wp-list-table` to `table` class attribute to enjoy the list table
 responsive goodness.
 * Add `column-primary` to class attribute of the 2nd column of each row
 for responsive goodness to work.
 * Screenshot of first pass working it in the browser
 https://cldup.com/cJtExK9BxO.png which has additional information

 Note: excuse the change between `input type="radio"` and `input
 type="checkbox"` in above screenshot of source code and the image below.
 The `checkbox` for `<thead>` and `<tfoot>` and `radio` input for the
 template pack row.

 > Some inline CSS, can we move to one of the admin stylesheets?
 +1 Move styles to admin stylesheet.

 > Empty span in the `plugin-title` block. And `row-actions-visible`.
 The span can be removed unless you want to add a dashicon, SVG, or image,
 etc. The div for `row-actions-visible` can be removed as well if not
 planning to add anything there.

 >That check-column th is also suspiciously empty. Maybe copy what
 WordPress does -- I will be surprised if it should be left blank.
 I added a disabled `checkbox` in first column of  `<thead>` and `<tfoot>`
 to remove validation warnings. e.g. in recent
 core-admin-components.php#L173 Components] screen update.

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7157#comment:18>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac

More information about the buddypress-trac mailing list