[buddypress-trac] [BuddyPress Trac] #6977: Audit all DB fetch methods to return integers where appropriate

[buddypress-trac]

#6977: Audit all DB fetch methods to return integers where appropriate
------------------------------------+-----------------------------
 Reporter:  r-a-y                   |       Owner:
     Type:  enhancement             |      Status:  new
 Priority:  normal                  |   Milestone:  Future Release
Component:  Component - Any/All     |     Version:
 Severity:  normal                  |  Resolution:
 Keywords:  dev-feedback has-patch  |
------------------------------------+-----------------------------

Comment (by r-a-y):

 > If casting group_id to an int makes unit tests fail, that doesn't mean
 we should skip it, it means we should fix the unit tests.

 When I uploaded `01.patch`, it was late in the day and I couldn't for the
 life of me figure out whereabouts the xprofile unit tests were failing :)

 02.patch fixes this up.  I forgot to cast some other properties in
 `BP_XProfile_Group::get()`.

 > What does "omitting 'parent_id' for safety" mean? It sounds scary :)

 Disregard my idiocy :)

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6977#comment:9>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac