[buddypress-trac] [BuddyPress Trac] #6605: Check box should have label in group invite page for making the consistency

[buddypress-trac]

#6605: Check box should have label in group invite page for making the consistency
-------------------------------------+------------------
 Reporter:  Ankit K Gupta            |       Owner:
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  2.4
Component:  Component - Groups       |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |
-------------------------------------+------------------

Comment (by hnla):

 Replying to [comment:3 Ankit K Gupta]:

 Thanks Ankit it's a good dpot, we've spent soem time in this area and
 surprised we missed this.

 You're right we should label these.

 I ran the patch and modified slightly to add 'for' attr to the label even
 though it's an implicit association to the input.

 There does appear to be an issue though with the WP 'checked()' function,
 it's echoing the checked function as a string  we need to return it
 rather than echo it so really need to add the third optional param 'false'
 to counter the default setting 'true' `checked($checked, 1, false)` or the
 equivalent that works for BP's current implementation which is slightly
 quirky?

 I'd update patch but haven't found a solution that works yet, also not
 sure why this hasn't come to light before, so could do with a second set
 of eyes on this!

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6605#comment:4>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac