[buddypress-trac] [BuddyPress Trac] #6630: Issue posting comment on links using buddypress

[buddypress-trac]

#6630: Issue posting comment on links using buddypress
----------------------------------+-----------------------
 Reporter:  camaro4d              |       Owner:
     Type:  defect (bug)          |      Status:  reopened
 Priority:  normal                |   Milestone:  2.4
Component:  Component - Activity  |     Version:  1.7
 Severity:  normal                |  Resolution:
 Keywords:  needs-patch           |
----------------------------------+-----------------------

Comment (by MrMaz):

 Just some feedback on my case... testing the number of arguments is the
 best/safest clue I have to check for the regression issue because I
 *think* that sometimes `$_POST['object']` can be empty/false or at least
 eval to false. So I can't simply check if the first arg is a bool/int vs
 string. Even if that was reliable, I am still faced with handling a
 variable number of args.

 Comparing versions doesn't help because it's called with a different
 number of args from different locations in the same version.

 My vote would be to revert it to three args and document when the
 regression was introduced and when corrected in the filter doc block,
 which is what I *think* @boonebgorges is saying. That being said... I
 already have to leave the compat code in my plugin forever, so it's kind
 of moot.

 As far as moving forward, I couldn't find enough context as to what
 problem #6021 was actually correcting, so I can't comment on that.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6630#comment:12>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac