[buddypress-trac] [BuddyPress Trac] #5089: Avatar rotation fix for iOS

buddypress-trac noreply at wordpress.org
Fri Oct 2 08:23:54 UTC 2015

#5089: Avatar rotation fix for iOS
 Reporter:  modemlooper              |       Owner:
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  2.4
Component:  Component - Attachments  |     Version:  1.0
 Severity:  normal                   |  Resolution:
 Keywords:  needs-testing has-patch  |

Comment (by DJPaul):

 Quick review:

 * phpDoc for new get_image_data() has incorrect `@return`; it could return
 a bool as well as an array.
 * Are you sure we need to suppress errors on the `exif_read_data` function
 call? I can't see any notes on the php.net page explaining why.
 * Have you timed how much longer it takes for the tests to run after these
 new tests? Is it significant? I think the file copying could be slow,
 especially on a heavily-virtualised environment.
 * ABSPATH is set by default with a trailing slash, you don't need one at
 the start of the rest of the string.

 Other than that, I haven't tested it yet, but the code looks fine.

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5089#comment:25>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac

More information about the buddypress-trac mailing list