[buddypress-trac] [BuddyPress Trac] #6457: buddypress.css stylesheet overloading behavior change in 2.3-RC1

buddypress-trac noreply at wordpress.org
Sun May 31 19:00:08 UTC 2015

#6457: buddypress.css stylesheet overloading behavior change in 2.3-RC1
 Reporter:  dcavins                     |       Owner:
     Type:  defect (bug)                |      Status:  new
 Priority:  high                        |   Milestone:  2.3
Component:  Appearance - Template Pack  |     Version:
 Severity:  blocker                     |  Resolution:
 Keywords:  has-patch                   |

Comment (by r-a-y):

 If we want to do `02.patch`, let's wait until 2.4.

 `01.patch` gets us back to what we were doing since 2.1.1 (#5888), which
 is not looking for minified assets in parent and child themes.

 The main issue I have with `02.patch` -- looking for another `.min` asset
 in the stack -- is this adds a maximum of six more `file_exists()` calls
 for each asset check.  Multiply that by 4 if we count every single call to
 `locate_asset_in_stack()`.  Multiply that by 6 if the site is RTL.

 Most themes will not be overriding our assets with a minified CSS file /
 JS file.  If there are themes that do, they probably will have already
 made this change in their build environments since we've added asset stack
 checks since v1.9 (#4949).  In this case, we'd be adding another `.min`
 asset check for no reason.

 If we're getting rid of the `BP_SOURCE_SUBDIRECTORY` constant, we might
 need to deprecate it.  Though, this isn't that big of a deal because this
 only affects development installs.

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6457#comment:12>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac

More information about the buddypress-trac mailing list