[buddypress-trac] [BuddyPress Trac] #6218: bp_friend_get_total_requests_count() could use already cached data

[buddypress-trac]

#6218: bp_friend_get_total_requests_count() could use already cached data
------------------------------------------+------------------
 Reporter:  wpdennis                      |       Owner:
     Type:  enhancement                   |      Status:  new
 Priority:  normal                        |   Milestone:  2.3
Component:  Component - Friends           |     Version:
 Severity:  normal                        |  Resolution:
 Keywords:  needs-patch needs-unit-tests  |
------------------------------------------+------------------
Changes (by boonebgorges):

 * keywords:  2nd-opinion dev-feedback => needs-patch needs-unit-tests


Comment:

 >  If we're going to deprecated one of those function, I think
 get_friendship_request_user_ids() should be our choice. Since
 BP_Friends_Friendship::get_friend_user_ids() can return same values and
 more. But this gonna make caching in later function bit complicated, where
 we should change cache group based on args.

 Agreed. The caching will be more complicated but will have benefits beyond
 this use case. If we're going to add caching here, we'll need a decent set
 of unit tests to demonstrate invalidation on new requests, defriending,
 user spam/delete, etc.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6218#comment:3>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac