[buddypress-trac] [BuddyPress Trac] #6107: Missing site titles for BP pages in Twenty Fifteen and new themes which add support to the new title-tag feature

[buddypress-trac]

#6107: Missing site titles for BP pages in Twenty Fifteen and new themes which add
support to the new title-tag feature
------------------------------+-----------------------
 Reporter:  mercime           |       Owner:  hnla
     Type:  defect (bug)      |      Status:  assigned
 Priority:  normal            |   Milestone:  2.2.2
Component:  Component - Core  |     Version:
 Severity:  major             |  Resolution:
 Keywords:  has-patch         |
------------------------------+-----------------------

Comment (by johnjamesjacoby):

 [https://buddypress.trac.wordpress.org/attachment/ticket/6107/6107.06.patch
 6107.06.patch] builds off math's patch a few different ways:

 * Adds a `is_buddypress()` check at the beginning. This is basically the
 opposite of `bp_is_blog_page()` but, I think `is_buddypress()` is a more
 oft suggested approach, and since it has its own filter is worth including
 regardless.
 * Removes the anonymous function for PHP 5.2 combat
 * Refreshes for BuddyPress 2.2 branch
 * Fakes a `current_theme_supports( 'title-tag' )` check with a direct
 touch to the `$_wp_theme_features` global, and by `strstr()`ing the
 `$title` for `blogname()` to see if it was previously included. This
 maintains compatibility with core themes that are doing-it-both right and
 wrong (if you believe `wp_title()` is ever right.)

 We should probably write some tests for all this. Lots of plugins use
 `wp_title()` and lots of users get really mad when something narfs them
 up. Plus we've all spent a decent amount of time on this already, and
 tests will help ensure we can spend less time on this later.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6107#comment:33>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac