[buddypress-trac] [BuddyPress Trac] #6513: New Filter for Groups Widgets and Members Widgets

buddypress-trac noreply at wordpress.org
Fri Jun 19 13:14:08 UTC 2015

#6513: New Filter for Groups Widgets and Members Widgets
 Reporter:  dunhakdis                   |       Owner:
     Type:  defect (bug)                |      Status:  new
 Priority:  normal                      |   Milestone:  2.4
Component:  General - UX/UI             |     Version:
 Severity:  normal                      |  Resolution:
 Keywords:  good-first-bug needs-patch  |

Comment (by hnla):

 >But let's not lose sight of the fact that all the reporter is asking for
 is a way to change the separator

 Absolutely, and believe me my remarks above were made with that in mind,
 but it's important to note we need to address deeper issues and to try and
 improve as much as logically possible in each iteration just in case it
 has to last for longer than we cared for it to.

 So, and sorry if this is all longwided, we should for the moment add the
 filter, based on the fact that we can live with the filter regardless of
 what other changes may be effected.

 As suggested the filter would be stored to a variable lets then output
 that variable to markup adding a class and aria role, so:
 <span class="bp-separator" role="separator"><?php echo esc_html(
 $separator ); ?></span>

 Thus we at least have our characters wrapped in a suitable element and not
 floating around haplessly, we have a styling hook and an aria control for
 good measure.

 For clarity inlne anchors used in this manner essentially read as a
 sentence with hyperlinks and thus is why the instruction is made that a
 separator of some nature is provided in order that the links are broken,
 really the 'pipe' character is the correct option here for this. This
 instruction is not a decorative or visual cue though it's an assistive

 If or when we markup these links in a ul construct the hard character is
 redundant as the ul construct conveys the semantic information naturally
 via it's 'li' elements then it's perfectly acceptable to use a separator
 but it now becomes purely a decorative item, then we should use CSS for
 it's presentational purpose to provide these  either as border-left or as
 said using pseudo elements

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6513#comment:9>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac

More information about the buddypress-trac mailing list