[buddypress-trac] [BuddyPress Trac] #6513: New Filter for Groups Widgets and Members Widgets

buddypress-trac noreply at wordpress.org
Fri Jun 19 08:15:47 UTC 2015

#6513: New Filter for Groups Widgets and Members Widgets
 Reporter:  dunhakdis                   |       Owner:
     Type:  defect (bug)                |      Status:  new
 Priority:  normal                      |   Milestone:  2.4
Component:  General - UX/UI             |     Version:
 Severity:  normal                      |  Resolution:
 Keywords:  good-first-bug needs-patch  |

Comment (by hnla):

 A few things to consider here.

 While in principle the notion of providing access to modify these
 characters is undeniably a good thing we are leaping over some far more
 fundamental issues that should be addressed.

 - The use of a series of inline anchors for what amounts to nav links.

 - Outputting bare naked character data to an aggregating non semantic
 element, not a good thing, it's hard to target those characters and
 technically upsets formatting blocks.

 Ideally we ought to update this and the other widgets that have these
 'sort' links to use a construct that can better manage styling and provide
 some semantic context, classically a ul construct. To ensure we don't
 upset existing layouts we would add rulesets to manage this new markup to
 replicate the look we currently default to i.e. horizontal, with a
 separator that is now largely a decorative visual aid rather than
 something we need to add in order to vaguely comply with guidelines when
 links are used for navigation without any semantic expression of their

 If not updating the links in this fashion then we need  - at the least -
 to wrap the characters in span tags to provide formatting context, ease of
 styling, and ability to provide attr then we can/could provide aria scope

 The solution proposed uses a filter to access the output, I'm not clear
 why we need to use this approach as it's somewhat technical (I don't
 propose it's not provided but it's additional to...) for general users and
 where we're talking about a widget which by definition passes args back so
 why are we not updating the widget control to include a text input or
 maybe safer a set select dropdown of available options for separator
 characters to use and which we would output to span markup.

 We need now to be tackling aspects such as this as fully and finally as
 possible and I see this as part of the larger task I would like us to
 begin to tackle with BP templates in the next release/s.

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6513#comment:7>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac

More information about the buddypress-trac mailing list