[buddypress-trac] [BuddyPress Trac] #6125: Small improvements to Member Types functions

buddypress-trac noreply at wordpress.org
Thu Jan 15 21:24:32 UTC 2015

#6125: Small improvements to Member Types functions
 Reporter:  Offereins     |       Owner:  boonebgorges
     Type:  defect (bug)  |      Status:  closed
 Priority:  normal        |   Milestone:  2.2
Component:  Members       |     Version:
 Severity:  normal        |  Resolution:  fixed
 Keywords:  has-patch     |

Comment (by johnjamesjacoby):

 Replying to [comment:6 boonebgorges]:
 > One of the goals here was to make the API look exactly like WP's post
 type API. So `bp_get_member_types()` has a function signature identical to
 `get_post_types()`. Unless there's a powerful argument to the contrary
 (like a bug that it introduces), I'd prefer not to break the filter logic
 out into a separate function.

 I figured it was something like this. My only concern with it how it is
 now, is the hardcoded limitation we put on `names` vs. any other possible
 field that someone may want to pluck by, and the odd position it puts the
 filter in. As it sits now, we've whitelisted `names` for no reason, as
 each usage overrides it to `objects`, which makes it look accidental or

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6125#comment:8>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac

More information about the buddypress-trac mailing list