[buddypress-trac] [BuddyPress Trac] #6116: Message ajax search not working

buddypress-trac noreply at wordpress.org
Tue Jan 13 18:12:06 UTC 2015

#6116: Message ajax search not working
 Reporter:  johnjamesjacoby  |       Owner:
     Type:  defect (bug)     |      Status:  new
 Priority:  normal           |   Milestone:  2.2
Component:  Messaging        |     Version:
 Severity:  normal           |  Resolution:
 Keywords:  has-patch        |

Comment (by hnla):

 >This makes more sense to me. I don't love the idea of making a bunch of
 assumptions about random ID's in the DOM, but it does work, is the
 fastest, and mirrors our existing JS approaches elsewhere.

 We did do a lot of work trawling through the file removing many vague
 'have a look around and gather up any tokens you might find'  .parent
 approaches in favour of .closest and also removed a tonne of too strictly
 binding selectors and tokens, problem with .parent is it has to traverse
 all the way to the top of the DOM then cache the whole damned lot so is
 hugely expensive.

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6116#comment:11>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac

More information about the buddypress-trac mailing list