[buddypress-trac] [BuddyPress Trac] #6209: Add tests for group invitations and membership request functions

[buddypress-trac]

#6209: Add tests for group invitations and membership request functions
----------------------------------------+------------------
 Reporter:  dcavins                     |       Owner:
     Type:  task                        |      Status:  new
 Priority:  normal                      |   Milestone:  2.3
Component:  Component - Groups          |     Version:
 Severity:  normal                      |  Resolution:
 Keywords:  needs-unit-tests has-patch  |
----------------------------------------+------------------
Changes (by boonebgorges):

 * milestone:  Awaiting Review => 2.3


Comment:

 dcavins - The tests look generally good. Some feedback:

 - Use two separate `@group` annotations, not two function names separated
 by 'and'. These group annotations can then be used at the command line: `$
 phpunit --group foo`
 - Each of your existing methods should be separated into threeish methods.
 Then make the method names more descriptive:
 `test_bp_groups_uninvite_user_should_leave_confirmed_memberships_intact()`.
 Don't worry if you need to do more setup to make this work - it's more
 important to have the methods be as narrow as possible.
 - Go ahead and separate out the tests that are currently passing, and
 commit them. Commit the failing tests at the same time as the issue is
 fixed. #6223

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6209#comment:1>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac