[buddypress-trac] [BuddyPress Trac] #6213: buddypress.css is never minified

buddypress-trac noreply at wordpress.org
Wed Feb 11 17:37:08 UTC 2015


#6213: buddypress.css is never minified
----------------------------------------+-----------------------------
 Reporter:  wpdennis                    |      Owner:
     Type:  defect (bug)                |     Status:  new
 Priority:  normal                      |  Milestone:  Awaiting Review
Component:  Appearance - Template Pack  |    Version:
 Severity:  normal                      |   Keywords:  dev-feedback
----------------------------------------+-----------------------------
 in [https://buddypress.trac.wordpress.org/browser/tags/2.2.0/src/bp-
 templates/bp-legacy/buddypress-functions.php#L205 enqueue_styles()] it
 checks, whether the minified version should be included:

 {{{
 $min = defined( 'SCRIPT_DEBUG' ) && SCRIPT_DEBUG ? '' : '.min';
 }}}

 But in [https://buddypress.trac.wordpress.org/browser/tags/2.2.0/src/bp-
 templates/bp-legacy/buddypress-functions.php#L308 locate_asset_in_stack()]
 the ".min" will always be stripped, e.g.:

 {{{
 $locations['bp-legacy'] = array(
     'dir'  => bp_get_theme_compat_dir(),
     'uri'  => bp_get_theme_compat_url(),
     'file' => str_replace( '.min', '', $file )
 );
 }}}

 I don't think the ''str_replace'' should be there, should it? Even
 buddypress.org itself doesn't deliver the minified stylesheets.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6213>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list