[buddypress-trac] [BuddyPress Trac] #6207: BP user blogs count display in user nav not classed.

buddypress-trac noreply at wordpress.org
Tue Feb 10 19:33:38 UTC 2015


#6207: BP user blogs count display in user nav not classed.
-------------------------------+-----------------------
 Reporter:  hnla               |      Owner:
     Type:  defect (bug)       |     Status:  new
 Priority:  low                |  Milestone:  2.2.1
Component:  Component - Blogs  |    Version:
 Severity:  minor              |   Keywords:  has-patch
-------------------------------+-----------------------
 The user navs display counts in spans on various nav tabs e.g
 notifications, these span elements are classed either as 'no-count' or
 'count'.

 The Sites tab link has never had these classes added to it's span count.

 This patch corrects this for uniformity.

 @lead-devs please check this as I had to cast
 `bp_get_total_blog_count_for_user` as an '(int)' as in replicating other
 examples of how we do this a strict comparison is used but that failed on
 my re-working originally I used a `< 1` as a check but wanted to mirror
 how the others handled it but ` 0===` failed when it shouldn't have,
 tracking the function back wasn't clear what the value being passed was.
 As it's a clear count it seemed appropriate to cast it to an int and it's
 use doesn't move outside the scope it's used in here.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6207>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list