[buddypress-trac] [BuddyPress Trac] #6197: Register/Activate pages and bp_core_get_directory_page_ids() since 2.2

[buddypress-trac]

#6197: Register/Activate pages and bp_core_get_directory_page_ids() since 2.2
-----------------------------------------+--------------------
 Reporter:  imath                        |       Owner:
     Type:  defect (bug)                 |      Status:  new
 Priority:  normal                       |   Milestone:  2.2.1
Component:  API - Sign ups & Activation  |     Version:  2.2
 Severity:  normal                       |  Resolution:
 Keywords:  has-patch                    |
-----------------------------------------+--------------------

Comment (by imath):

 I must admit my first tests was over complicated! Sorry for that
 boonebgorges

 I actually added another test in 6197.unittests.02.patch :
 {{{test_bp_core_get_directory_pages_register_activate_page_notcreated_signups_notallowed()}}}
 it directly covers the case
 > where signups are *closed* and where 'register' and 'activate' *do not
 exist*

 {{{test_bp_core_get_directory_page_ids_should_not_contain_register_and_activet_pages_when_registration_is_closed()}}}
 is creating pages then deleting them then checking register and activate
 are not in page_ids. So it might be a good idea to remove it. I actually
 adapted it because he was here before.

 I've created a [https://gist.github.com/imath/07e79c2244c5ab2e0a1b small
 script to add in bp-custom.php] file to retain the activate/register page
 ids, i think it's safer to ask people testing it instead of asking them to
 edit a core file.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6197#comment:11>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac