[buddypress-trac] [BuddyPress Trac] #6197: Register/Activate pages and bp_core_get_directory_page_ids() since 2.2

[buddypress-trac]

#6197: Register/Activate pages and bp_core_get_directory_page_ids() since 2.2
-----------------------------------------+--------------------
 Reporter:  imath                        |       Owner:
     Type:  defect (bug)                 |      Status:  new
 Priority:  normal                       |   Milestone:  2.2.1
Component:  API - Sign ups & Activation  |     Version:  2.2
 Severity:  normal                       |  Resolution:
 Keywords:  has-patch                    |
-----------------------------------------+--------------------

Comment (by boonebgorges):

 I guess I trust you here, but I'm still confused about what's happening
 and what you intend to be testing. At a glance, it seems like we need
 tests for the following:

 - Ensure that `bp_core_get_directory_pages()` returns 'register' and
 'activate' when registration is active and the pages exist
 - Ensure that `bp_core_get_directory_pages()` returns 'register' and
 'activate' when registration is *inactive* and the pages exist (right?)
 - Ensure that `bp_core_get_directory_pages()` does not 'register' and
 'activate' when registration is active and the pages don't exist
 - Ensure that a notice is thrown when registration is active and the pages
 don't exist
 - Ensure that the notice is not thrown when registration is active and the
 pages do exist

 Exactly *how* the pages are created during the tests is not terribly
 important.

 Again, though, I don't 100% understand the issue here. For me, the
 systematic tests are a way to make the problem easier to understand, and
 in this case I feel like the tests don't cover all the cases. That being
 said, if you do understand it and are confident with your solution, then
 go with it :)

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6197#comment:6>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac