[buddypress-trac] [BuddyPress Trac] #6774: Re-factor Groups manage requests template

buddypress-trac noreply at wordpress.org
Mon Dec 14 18:34:19 UTC 2015

#6774: Re-factor Groups manage requests template
 Reporter:  hnla                         |      Owner:
     Type:  enhancement                  |     Status:  new
 Priority:  normal                       |  Milestone:  2.5
Component:  Appearance - Template Parts  |    Version:
 Severity:  normal                       |   Keywords:  needs-patch
 This ticket is prompted by #6771 and issues spotted and noted by @DJPaul.

 On the screen that displays pending group join requests (i.e private group
 and user requests to join) we loop out requests by user currently that
 markup isn't ideal as optional user comments are rendered in the heading
 tag and this reads badly as well as being semantically poor. Styling
 across the twenty* style sheets is sub optimal but

 * Admin manage > sent requests screen pushes out the optional user reason
 to accept text nested in the heading element(h4) this is wrong and
 incorrect/inappropriate use of a heading element. that request text should
 be a paragraph and located outside the heading.

 * On request sent success screen in the group, our messages could be
 better displayed, currently we still display the request instruction
 message along with success request sent message but this pushes down the
 object nav and original message which looks clumsy.

 This ticket will address the two points above, updating the user request
 comments text moving it out to it's own position after the heading, in a
 similar manner to other bp list elements meta handling, and attempt a
 better experience with the success screen when a user has made a request,
 removing original screen message and moving success message down below the
 object nav.

 Styling across the twenty* style sheets is sub optimal as noted in the SC
 on the other ticker this will be addressed after template changes as the
 template changes will impact the styles, with some sheets probably not
 requiring much attention.

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6774>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac

More information about the buddypress-trac mailing list