[buddypress-trac] [BuddyPress Trac] #6574: Attachment API conflicts with wp_enqueue_media()

buddypress-trac noreply at wordpress.org
Sat Aug 29 10:48:15 UTC 2015

#6574: Attachment API conflicts with wp_enqueue_media()
 Reporter:  landwire       |       Owner:  imath
     Type:  defect (bug)   |      Status:  assigned
 Priority:  normal         |   Milestone:  2.4
Component:  API - Avatars  |     Version:  2.3.2
 Severity:  normal         |  Resolution:
 Keywords:  has-patch      |

Comment (by imath):

 I've been thinking about this. I think just like `buddypress()` or `$bp`
 we need the `window.bp` to be available so that it can be extended. Eg:
 avatar.js is extending it and so does webcam.js and so does mentions.js in
 a way and so does at least 2 of my plugins :)

 But i agree .02.patch is not ideal because it's resetting completely the
 `window.bp` global to the part we need from the `window.wp` global. So
 just like  `buddypress()` or `$bp` i think we need to be carefull to
 always extend it and not reset it.

 So i'm suggesting 2 new patches which are basically doing the same, the
 first option is doing it in 1 line, the second one in 3 lines. The second
 one may be more comprehensive.

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6574#comment:21>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac

More information about the buddypress-trac mailing list