[buddypress-trac] [BuddyPress Trac] #6331: Star Private Messages

buddypress-trac noreply at wordpress.org
Thu Apr 30 11:26:31 UTC 2015

#6331: Star Private Messages
 Reporter:  r-a-y                   |       Owner:  r-a-y
     Type:  enhancement             |      Status:  assigned
 Priority:  normal                  |   Milestone:  2.3
Component:  Component - Messaging   |     Version:
 Severity:  normal                  |  Resolution:
 Keywords:  dev-feedback has-patch  |

Comment (by boonebgorges):

 Regarding file organization. I see imath's point. But I would argue that
 if our organizational rules lead to files like the 6000-line bp-groups-
 template.php, then we should probably reconsider our rules. One thing I
 definitely like about r-a-y's approach is that disabling the feature will
 result in the file's not being loaded; this seems like a big improvement
 from the point of view of performance and modularity.

 Regarding naming. `bp_messages_is_starred_enabled()` is a bit awkward when
 spoken. Something like "is starring enabled" or even the ungrammatical "is
 stars enabled" sounds more natural to me. I probably would've chosen
 `bp_messages_stars_` as the default prefix, and adjusted it to `starred`
 when grammatically appropriate. But this is a small point :)

 > Should this function be named bp_messages_the_starred_action_link()?

 I think so. It sounds like the `unread` function is incorrectly named.

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6331#comment:13>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac

More information about the buddypress-trac mailing list