[buddypress-trac] [BuddyPress Trac] #6278: Attachment Library

buddypress-trac noreply at wordpress.org
Wed Apr 29 03:15:41 UTC 2015

#6278: Attachment Library
 Reporter:  imath                   |       Owner:  imath
     Type:  enhancement             |      Status:  assigned
 Priority:  normal                  |   Milestone:  2.3
Component:  API                     |     Version:
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |

Comment (by imath):

 What a night! Ok here's the situation:

 Since WordPress 4.0, an important filter for the API is dynamically built.
 In WordPress < 4.0 this filter was static `wp_handle_upload_prefilter` so
 we simply need to add/remove it before/after upload and it should be ok
 because in 3.9/3.8/3.7/3.6 WordPress was using `extract()` and the
 parameter names we're passing into the overrides arguments (e.g.:
 'upload_error_strings' ) are matching with the var used inside

 So in 6278.10.patch i'm adding the fix for WordPress < 4.0, the unit
 tests, and a more dynamic way to build the available avatar allowed
 extensions which is needed since r9760.

 @DJPaul, before i commit, could you check how the file extensions are
 listed into the error message. I've tried to find what you were talking
 about when saying :
 > I'm not sure it's quite right (not every language will use a comma to
 separate a list of items, I guess)

 The only thing i've found was how WordPress was comma separating the post
 tags, so i've simply reproduced. Is That ok for you ?

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6278#comment:74>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac

More information about the buddypress-trac mailing list