[buddypress-trac] [BuddyPress Trac] #6354: `xprofile_insert_field()` `empty()` checks break booleans when updating existing field

[buddypress-trac]

#6354: `xprofile_insert_field()` `empty()` checks break booleans when updating
existing field
----------------------------------+-----------------
 Reporter:  boonebgorges          |      Owner:
     Type:  defect (bug)          |     Status:  new
 Priority:  normal                |  Milestone:  2.3
Component:  Component - XProfile  |    Version:
 Severity:  normal                |   Keywords:
----------------------------------+-----------------
 If you pass a 'field_id' to `xprofile_insert_field()` to update an
 existing field, it's not possible to set any `true` field to `false`. This
 is because all of the checks look like:

 {{{
 if ( ! empty( $r['foo'] ) ) {
     $this->foo = $r['foo'];
 }
 }}}

 and `false` will not pass the test.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6354>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac