[buddypress-trac] [BuddyPress Trac] #6008: Remove HTML from post_title for groups

[buddypress-trac]

#6008: Remove HTML from post_title for groups
-------------------------------+------------------------------
 Reporter:  alexander.rohmann  |       Owner:
     Type:  defect (bug)       |      Status:  new
 Priority:  high               |   Milestone:  Awaiting Review
Component:  Groups             |     Version:  2.1
 Severity:  major              |  Resolution:
 Keywords:                     |
-------------------------------+------------------------------

Comment (by boonebgorges):

 Replying to [comment:18 imath]:
 > Yes, sorry too, i thought of it after my comment :)
 >
 > But i think the ID should be 0 as we resetting it in the screens file,
 so it might not be the one of the bp_pages.
 >
 > I'd also suggest to reference the filter(s) once we are sure it's
 {{{is_buddypress()}}} territory and very late in do_action( 'wp_head' ). I
 think we could also take benefits of the various actions templates are
 containing to remove the filter asap (eg:
 {{{'bp_before_directory_groups_page'}}}).

 Gah, I think you're right about 0.

 In terms of juggling and carefully timing filters, I think we are already
 doing enough confusing stuff here. The original problem in this ticket is
 that we're engaging in some sorcery that effectively cannot be undone by
 theme developers. My suggestion was to use a simple `add_filter()`, so
 that theme devs could use a simple `remove_filter()` to undo it. If we're
 going to have to do all sorts of nested `add_action()` calls, it negates
 most of the benefit of moving to a filter.

 On that note, I guess I lean toward removing the HTML altogether. Let
 themes decide whether they want the item title to be a link. This will
 change the existing behavior, but I wonder if anyone will notice (who is
 clicking on the group title when already looking at the group page?). As
 for Create a Blog and Create a Group buttons, we'd have to find a new
 place for them, within 'the_content'. I don't think this by itself is the
 end of the world, though it's probably worth reading over #5144 [7942]
 before going too far down this road.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6008#comment:19>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac