[buddypress-trac] [BuddyPress Trac] #5994: Use bp_core_new_subnav_item() to generate group's manage subnav

[buddypress-trac]

#5994: Use bp_core_new_subnav_item() to generate group's manage subnav
-------------------------+------------------
 Reporter:  imath        |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  2.2
Component:  Groups       |     Version:
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |
-------------------------+------------------
Changes (by boonebgorges):

 * keywords:  has-patch 2nd-opinion => has-patch


Comment:

 Thanks for doing this, imath. I'm pretty sure I wrote that comment you
 refer to, and the inconsistency here has long been a point of annoyance
 for me. What's held me back from fixing it is the backward compatibility
 issue, but it looks like you've solved that in a clever way.

 I might even suggest that if you detect a plugin adding content on the
 `groups_admin_tabs` hook, you throw a `_doing_it_wrong()` notice.

 Aside from that, patch looks good to me.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5994#comment:1>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac