[buddypress-trac] [BuddyPress Trac] #5633: Group Administration - Add new members metabox & changing opinion

[buddypress-trac]

#5633: Group Administration - Add new members metabox & changing opinion
--------------------------+------------------
 Reporter:  imath         |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  2.1
Component:  Groups        |     Version:  2.0
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+------------------

Comment (by boonebgorges):

 > Short of re-working all the JS to not have use a hidden field(s), patch
 looks OK

 I guess I probably originally wrote this, but I don't know why I would
 have done it this way. First thought was no-js support, but this technique
 certainly does not do *that*.

 imath, your patch is fine, but if you felt like rewriting this section so
 that the hidden input is not required, feel free. (Maybe put `data-`
 fields into the `#bp-groups-new-members-list` items containing the user
 IDs, and then pre-submit, grab all of those IDs and put them into a single
 hidden input. Or even into `.bp-suggest-user` as comma-separated
 user_login values, which would have the bonus of providing true no-js
 support.)

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5633#comment:2>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac