[buddypress-trac] [BuddyPress Trac] #5440: Add pagination to group membership requests admin page

[buddypress-trac]

#5440: Add pagination to group membership requests admin page
-------------------------------------+--------------------
 Reporter:  dcavins                  |       Owner:
     Type:  enhancement              |      Status:  new
 Priority:  normal                   |   Milestone:  2.0
Component:  Groups                   |     Version:  1.9.2
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-refresh  |
-------------------------------------+--------------------
Changes (by dcavins):

 * cc: david.cavins@… (added)


Comment:

 Thanks very much for working on this. I believe I was able to make the
 changes you requested.

 The `$group_id` global was included because the `$groups_template` global
 isn't reliable when used in an AJAX context. I was able to use
 `buddypress()->groups->current_group` where I needed access to the same
 bits, and it solves the problem I was having.

 I switched the template functions (`bp_get_group_request_reject_link()`
 and `bp_get_group_request_accept_link()`) over to use your new table id
 `membership_id` (added in r8069) instead of the less descriptive `id`.
 It's not a necessary change, but it makes the code easier to follow.

 I've tested this in my bp-compat theme, twenty twelve and Frisco. In a
 theme that doesn't include the structures for pagination, only the ten
 most recent requests are shown (but that's the current behavior anyway,
 which is part of why I wanted to make these changes).

 Please let me know if you notice anything that I need to revisit or have
 other suggestions.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5440#comment:4>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac