[buddypress-trac] [BuddyPress Trac] #5629: Slow queries with BP_Activity_Activity::get()

buddypress-trac noreply at wordpress.org
Sat Jun 7 18:18:38 UTC 2014

#5629: Slow queries with BP_Activity_Activity::get()
 Reporter:  Clean-Cole   |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  2.1
Component:  Activity     |     Version:  2.0
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |
Changes (by boonebgorges):

 * priority:  lowest => normal


 5629.02.patch is an update with the following changes:

 - In the `activity-loop.php` template, I've removed the `<noscript>` block
 containing activity pagination (since it no longer works correctly anyway)
 - Made some minor mods to `BP_Activity_Template` so that the `'acpage'`
 param is available in the template loop global
 - Switched the href of the Load More link from '#more' (which was a dummy
 link that did nothing) to `http://example.com/activity/?acpage=x+1`. This
 provides noscript support for browsing through pages

 I think this is a pretty elegant solution, but there are a few backpat
 concerns. Any theme that has overridden activity-loop.php will not inherit
 the change. And any bp-default derivative theme will not get the change.
 In both of these cases, the Load More link won't work (though this is not
 a regression), and the non-functional `<noscript>` pagination block will
 still be there. My initial thought is that this is an acceptable side-
 effect of the change - remember that we're only talking about users
 without Javascript, which will be a small percentage of the users of the
 small percentage of affected themes. We can publish some documentation
 about making the necessary manual template changes around the time of 2.1.

 Do others have thoughts about this backward compatibility issue?

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5629#comment:10>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac

More information about the buddypress-trac mailing list