[buddypress-trac] [BuddyPress Trac] #5652: root_blog_id problem since trunk has been "gruntified" for website using trunk version

buddypress-trac noreply at wordpress.org
Wed Jul 30 16:27:10 UTC 2014


#5652: root_blog_id problem since trunk has been "gruntified" for website using
trunk version
------------------------------------+-----------------------
 Reporter:  imath                   |       Owner:  DJPaul
     Type:  defect (bug)            |      Status:  assigned
 Priority:  high                    |   Milestone:  2.1
Component:  Core                    |     Version:  2.0
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |
------------------------------------+-----------------------

Comment (by boonebgorges):

 >  As far as I'm concerned, the patch looks pretty clever. :)

 Yes, logic looks good to me. Only small quibble is that 'BP_LOAD_MODE' is
 a not-entirely-semantic name for this constant. Strictly speaking, the
 "load mode" would be something like: 'build', 'src', or 'distribution'
 (the wp.org version). An empty "load mode" doesn't seem like a mode at
 all. What the constant really is is the mode-subdirectory. That said, I
 can't think of a great alternative off the top of my head, so maybe we can
 just have an extra line of inline documentation on what BP_LOAD_MODE
 stands for.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5652#comment:18>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list